859287 - After the toolbar customization dialog is used, the "Get Mail" pull down does not display full width until TB is restarted.

Status: RESOLVED FIXED

(Thunderbird :: Toolbars and Tabs, defect)

Description

[Josiah Bruner [:jsbruner]]

Attachment: Screenshot of the bug.

On the current Daily (V. 23), when using the Icon Only mode, the get mail pull down menu does not display it's full width and dramatically cuts off the names of each account.

The issue does *not* occur on Thunderbird V. 17.0.5.

Attached is a screenshot of the issue.

Comment 1

[Josiah Bruner [:jsbruner]]

Odd, after trying again, I can not reproduce it. Going to try to find the cause of this...

Comment 2

[Josiah Bruner [:jsbruner]]

Ah, there we go. This issue still happens only on V. 23, but only occurs when the first click after you change the tab icon type. (E.G. Text to Text beside icons, etc).

Comment 3

[:aceman]

Confirming on Win XP. After restart of TB with the Icons only mode, the popup is fine.

It also happens just after switching from Icons only to "Icons beside text" mode.

So it happens after any switch.

I wonder if this isn't caused by bug 860093.
Josiah, maybe you could try the trivial change proposed in bug 860093 and see if it helps.

Comment 5

[Josiah Bruner [:jsbruner]]

Re-opening bug. Tried the patch and it does not fix the issue.

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

I can reproduce on latest beta, aurora and daily. Looking onto the list of patches in bug 824150 which landed until mid-February, I don't think that this is a regression by that bug.

Comment 7

[:aceman]

I get this error when closing the Customize palette:
Error: TypeError: toolbox.getElementById is not a function
Source file: chrome://messenger/content/mailCore.js

But bug 860093 does not fix the problem here.

I think this may be fallout from bug 813218. Who would have expected the Get Mail menupopup parasites on a folder picker :)

Comment 8

[Richard Marti (:Paenglab)]

When switching the mode the button-getMsgPopup gets a width="100" on Win7 (not checked other platform but it would be the same) which makes the small popup. After reboot no width is set.

Comment 9

[:aceman]

Yes, that's the new code added in bug 813218. When we get into the customize mode (have id.startsWith("wrapper")) I set width=100 and save the original width in another attribute. But for this popup the original width is never restored back after leaving the customize mode.

I'm on it.

Comment 10

[:aceman]

Attachment: patch

This seems to do it.
Josiah, can you confirm?

Comment 11

[Josiah Bruner [:jsbruner]]

(In reply to :aceman from comment #10)
> Created attachment 735933 [details] [diff] [review]
> patch
> 
> This seems to do it.
> Josiah, can you confirm?

Yep, issue fixed. Thanks Ace.

Comment 12

[[e-mail]]

Comment on attachment 735933 [details] [diff] [review]
patch

Sorry, I can't review this because I don't have a test case
(Thunderbird doesn't count to me as a test case).

Comment 13

[:aceman]

(In reply to Josiah Bruner [:JosiahOne] from comment #2)
> Ah, there we go. This issue still happens only on V. 23, but only occurs
> when the first click after you change the tab icon type. (E.G. Text to Text
> beside icons, etc).

If this is really a regression from bug 813218 then this should happen since TB21. And for me it is enough to just open the Customize dialog and clicking Done.

Comment 14

[:aceman]

(In reply to [e-mail] from comment #12)
> Sorry, I can't review this because I don't have a test case
> (Thunderbird doesn't count to me as a test case).
OK, I see Seamonkey's Get mail menulist is made via rdf, not the folder picker.

Comment 15

[Magnus Melin [:mkmelin]]

Comment on attachment 735933 [details] [diff] [review]
patch

Review of attachment 735933 [details] [diff] [review]:
-----------------------------------------------------------------

Seems to fix it! r=mkmelin

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/41b14c833e76