[updates] wrong behavior when the manifest changes but not the packaged zip

VERIFIED FIXED in Firefox 23

Status

VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: julienw, Assigned: fabrice)

Tracking

unspecified
B2G C4 (2jan on)
x86_64
Linux

Firefox Tracking Flags

(blocking-b2g:tef+, firefox21 wontfix, firefox22 wontfix, firefox23 fixed, b2g18 fixed, b2g18-v1.0.0 wontfix, b2g18-v1.0.1 fixed)

Details

Attachments

(1 attachment)

STR:
* install a packaged app where you control the files
* change the manifest.webapp (for example: increment the version string)
* check for update, accept the update

Expected:
* the update happens 

Actual:
* the update fails, and the notification stays at 0 bytes forever

According to [1], we get a downloadapplied event but no downloadsuccess (because |aSuccess| is not called).

I don't know if we should fix gecko (sending a downloadsuccess event before downloadapplied) or gaia (getting downloadapplied should remove the notification as a downloadsuccess would do).

I'd rather fix gecko because this feels inconsistent to me, but Fabrice, Étienne, what do you think ?

Asking tef? too. This does not brick the phone but this makes a broken notification stay forever until the phone is rebooted.

[1] http://mxr.mozilla.org/mozilla-central/source/dom/apps/src/Webapps.jsm#2226
Flags: needinfo?(etienne)
Flags: needinfo?(fabrice)
Hitting this as an end user is very uncomfortable: you think (I did) update failed :/

Updated

5 years ago
Blocks: 728081
(Assignee)

Comment 2

5 years ago
I don't mind sending a downloadsuccess before downloadapplied from gecko. I also agree this should be tef+.
Flags: needinfo?(fabrice)
(Assignee)

Comment 3

5 years ago
Created attachment 734842 [details] [diff] [review]
patch

Julien, that works for me, but please verify.
Assignee: nobody → fabrice
Attachment #734842 - Flags: review?(ferjmoreno)

Updated

5 years ago
blocking-b2g: tef? → tef+
Flags: needinfo?(etienne)
This fixes it for me too !
Attachment #734842 - Flags: feedback+
Attachment #734842 - Flags: review?(ferjmoreno) → review+
https://hg.mozilla.org/mozilla-central/rev/9a364c95741a
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → B2G C4 (2jan on)

Updated

5 years ago
Keywords: verifyme
QA Contact: jsmith
https://hg.mozilla.org/releases/mozilla-b2g18/rev/8faf9b364a8f
https://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/935ff9a97f7b
status-b2g18: --- → fixed
status-b2g18-v1.0.0: --- → wontfix
status-b2g18-v1.0.1: --- → fixed
status-firefox21: --- → wontfix
status-firefox22: --- → wontfix
status-firefox23: --- → fixed
This patch definitely isn't working for me on the b2g 18 branch.

I tried a test case that did the following:

1. Install a packaged app with icon X referenced in the package zip with state1.zip as name
2. Change the packaged app to have the same name, but icon Y is now referenced
3. Check for updates

Result - I'm not finding an update at all.
Keywords: verifyme
Filed bug 861793 for a followup.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.