Closed Bug 859307 Opened 8 years ago Closed 8 years ago
[updates] wrong behavior when the manifest changes but not the packaged zip
STR: * install a packaged app where you control the files * change the manifest.webapp (for example: increment the version string) * check for update, accept the update Expected: * the update happens Actual: * the update fails, and the notification stays at 0 bytes forever According to , we get a downloadapplied event but no downloadsuccess (because |aSuccess| is not called). I don't know if we should fix gecko (sending a downloadsuccess event before downloadapplied) or gaia (getting downloadapplied should remove the notification as a downloadsuccess would do). I'd rather fix gecko because this feels inconsistent to me, but Fabrice, Étienne, what do you think ? Asking tef? too. This does not brick the phone but this makes a broken notification stay forever until the phone is rebooted.  http://mxr.mozilla.org/mozilla-central/source/dom/apps/src/Webapps.jsm#2226
Hitting this as an end user is very uncomfortable: you think (I did) update failed :/
I don't mind sending a downloadsuccess before downloadapplied from gecko. I also agree this should be tef+.
Julien, that works for me, but please verify.
Assignee: nobody → fabrice
Attachment #734842 - Flags: review?(ferjmoreno)
This fixes it for me too !
Attachment #734842 - Flags: review?(ferjmoreno) → review+
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → B2G C4 (2jan on)
This patch definitely isn't working for me on the b2g 18 branch. I tried a test case that did the following: 1. Install a packaged app with icon X referenced in the package zip with state1.zip as name 2. Change the packaged app to have the same name, but icon Y is now referenced 3. Check for updates Result - I'm not finding an update at all.
Filed bug 861793 for a followup.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.