859307 - [updates] wrong behavior when the manifest changes but not the packaged zip

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Julien Wajsberg [:julienw]]

STR:
* install a packaged app where you control the files
* change the manifest.webapp (for example: increment the version string)
* check for update, accept the update

Expected:
* the update happens 

Actual:
* the update fails, and the notification stays at 0 bytes forever

According to [1], we get a downloadapplied event but no downloadsuccess (because |aSuccess| is not called).

I don't know if we should fix gecko (sending a downloadsuccess event before downloadapplied) or gaia (getting downloadapplied should remove the notification as a downloadsuccess would do).

I'd rather fix gecko because this feels inconsistent to me, but Fabrice, Étienne, what do you think ?

Asking tef? too. This does not brick the phone but this makes a broken notification stay forever until the phone is rebooted.

[1] http://mxr.mozilla.org/mozilla-central/source/dom/apps/src/Webapps.jsm#2226

Comment 1

[:gerard-majax]

Hitting this as an end user is very uncomfortable: you think (I did) update failed :/

Comment 2

[[:fabrice] Fabrice Desré]

I don't mind sending a downloadsuccess before downloadapplied from gecko. I also agree this should be tef+.

Comment 3

[[:fabrice] Fabrice Desré]

Attachment: patch

Julien, that works for me, but please verify.

Comment 4

[Julien Wajsberg [:julienw]]

This fixes it for me too !

Comment 5

[[:fabrice] Fabrice Desré]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9a364c95741a

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9a364c95741a

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/8faf9b364a8f
https://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/935ff9a97f7b

Comment 8

[Jason Smith [:jsmith]]

This patch definitely isn't working for me on the b2g 18 branch.

I tried a test case that did the following:

1. Install a packaged app with icon X referenced in the package zip with state1.zip as name
2. Change the packaged app to have the same name, but icon Y is now referenced
3. Check for updates

Result - I'm not finding an update at all.

Comment 9

[Jason Smith [:jsmith]]

Filed bug 861793 for a followup.