Intermittent B2G emulator Marionette test_outgoing_reject.js | ScriptTimeoutException: timed out and others

RESOLVED FIXED in Firefox 25, Firefox OS v1.1hd

Status

RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: RyanVM, Assigned: rwood)

Tracking

({intermittent-failure})

Trunk
mozilla25
ARM
Gonk (Firefox OS)
intermittent-failure
Points:
---

Firefox Tracking Flags

(firefox23 wontfix, firefox24 wontfix, firefox25 fixed, b2g18 fixed, b2g18-v1.0.0 wontfix, b2g18-v1.0.1 wontfix, b2g-v1.1hd fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

6 years ago
https://tbpl.mozilla.org/php/getParsedLog.php?id=21561588&tree=Mozilla-Inbound

b2g_ics_armv7a_gecko_emulator_vm mozilla-inbound opt test marionette-webapi on 2013-04-08 07:41:22 PDT for push 99cfae75ee7c
slave: tst-linux64-ec2-356

14:54:09     INFO -  TEST-START test_outgoing_reject.js
14:54:20     INFO -  /builds/slave/test/build/tests/marionette/tests/dom/telephony/test/marionette/test_outgoing_reject.js, runTest (marionette_test.MarionetteJSTestCase) ... ERROR
14:54:20     INFO -  ======================================================================
14:54:20     INFO -  ERROR: /builds/slave/test/build/tests/marionette/tests/dom/telephony/test/marionette/test_outgoing_reject.js, runTest (marionette_test.MarionetteJSTestCase)
14:54:20     INFO -  ----------------------------------------------------------------------
14:54:20     INFO -  Traceback (most recent call last):
14:54:20     INFO -    File "/builds/slave/test/build/tests/marionette/marionette/marionette_test.py", line 212, in runTest
14:54:20     INFO -      results = self.marionette.execute_js_script(js, args, special_powers=True)
14:54:20     INFO -    File "/builds/slave/test/build/tests/marionette/marionette/marionette.py", line 560, in execute_js_script
14:54:20     INFO -      scriptTimeout=script_timeout)
14:54:20     INFO -    File "/builds/slave/test/build/tests/marionette/marionette/marionette.py", line 320, in _send_message
14:54:20     INFO -      self._handle_error(response)
14:54:20     INFO -    File "/builds/slave/test/build/tests/marionette/marionette/marionette.py", line 369, in _handle_error
14:54:20    ERROR -      raise ScriptTimeoutException(message=message, status=status, stacktrace=stacktrace)
14:54:20    ERROR -  TEST-UNEXPECTED-FAIL | test_outgoing_reject.js | ScriptTimeoutException: timed out
14:54:20     INFO -  ----------------------------------------------------------------------
14:54:20     INFO -  Ran 1 test in 11.017s
14:54:20  WARNING -  FAILED (errors=1)

etc...
This is another case where an emulator callback took a long time, causing the test to fail.
Blocks: 846091
Blocks: 838047
No longer blocks: 846091
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
(Assignee)

Comment 6

5 years ago
I'll have a look...
Comment hidden (Treeherder Robot)
(Assignee)

Comment 8

5 years ago
Created attachment 773333 [details] [diff] [review]
Fix intermittent failures

Fix intermittent failure by ensuring the previous emulator command has finished before issuing the next one (the emulator was falling behind). Also addresses the same type of failure in the telephony test in Bug 842322.
Attachment #773333 - Flags: review?(jgriffin)
Comment on attachment 773333 [details] [diff] [review]
Fix intermittent failures

Review of attachment 773333 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

::: dom/telephony/test/marionette/test_outgoing_already_held.js
@@ +84,4 @@
>      });
>    };
> +
> +  rcvdEmulatorCallback = false;

use 'let' here

@@ +208,4 @@
>      });
>    };
> +
> +  rcvdEmulatorCallback = false;

use 'let' here

@@ +221,5 @@
> +    is(result[0], "inbound from " + inNumber + " : held");
> +    is(result[1], "outbound to  " + outNumber + " : active");
> +    is(result[2], "OK");
> +    hangUpIncoming();
> +  });	

nit: extra whitespace at end of this line

::: dom/telephony/test/marionette/test_outgoing_reject.js
@@ +107,4 @@
>      });
>    };
> +
> +  rcvdEmulatorCallback = false;

use 'let' here
Attachment #773333 - Flags: review?(jgriffin) → review+
(Assignee)

Comment 10

5 years ago
Created attachment 773923 [details] [diff] [review]
Fix intermittent failures (updated)

Updated patch as per review comments (thanks JGriffin), carrying forward the r+.
Attachment #773333 - Attachment is obsolete: true
Attachment #773923 - Flags: review+
(Assignee)

Comment 12

5 years ago
Been awhile since I pushed to try, the syntax changed... pushed to try again:

https://tbpl.mozilla.org/?tree=Try&rev=8b73d4b8c9a7
https://hg.mozilla.org/mozilla-central/rev/35eaef5f2124
Assignee: nobody → rwood
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
(Assignee)

Comment 15

5 years ago
Setting checkin-needed for b2g18 whenever you're doing your next bunch of uplifts Ryan, thanks!
Keywords: checkin-needed
Whiteboard: [checkin-needed]
(Reporter)

Comment 16

5 years ago
https://hg.mozilla.org/releases/mozilla-b2g18/rev/09368ed138e9
status-b2g18: --- → fixed
status-b2g18-v1.0.0: --- → wontfix
status-b2g18-v1.0.1: --- → wontfix
status-b2g-v1.1hd: --- → affected
status-firefox23: --- → wontfix
status-firefox24: --- → wontfix
status-firefox25: --- → fixed
Keywords: checkin-needed
Whiteboard: [checkin-needed]
You need to log in before you can comment on or make changes to this bug.