860121 - Animating the landscape tab menu on tablets yield a white gap between the sidebar and the tab count button

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aaron Train [:aaronmt]]

Attachment: Nightly (04/09) - Screenshot

See screenshot. This looks really jarring while the sidebar is in animating, this keeps flickering.

--
Nexus 7 (Android 4.2.2)
Nightly (04/09)

Comment 1

[Lucas Rocha (:lucasr)]

My guess is that this is related to some of the recent changes sriram made on the toolbar layout. Sriram?

Comment 2

[Sriram Ramasubramanian [:sriram]]

I've seen this in the past. The only change my patch did is to remove the "dark tabs fake layer" behind the tabs button. Do we want to add that back? That's clearly an overdraw. This feels like the elements are dropping frames while animating,

Comment 3

[Lucas Rocha (:lucasr)]

This will be fixed with the patch for bug 867554.

Comment 4

[Lucas Rocha (:lucasr)]

Pushed: https://hg.mozilla.org/integration/mozilla-inbound/rev/e6c09bae2a13

We'll probably need to fix this in Aurora too but this patch is too big and has too many dependencies with other large patches to be upliftable. So, we still need a patch for aurora.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Lucas Rocha (:lucasr) from comment #4)
> Pushed: https://hg.mozilla.org/integration/mozilla-inbound/rev/e6c09bae2a13
> 
> We'll probably need to fix this in Aurora too but this patch is too big and
> has too many dependencies with other large patches to be upliftable. So, we
> still need a patch for aurora.

Probably not needed for Fx22. Looks like it's tracking Fx23 only.

Comment 6

[Lucas Rocha (:lucasr)]

Fixed: https://hg.mozilla.org/mozilla-central/rev/e6c09bae2a13