Closed Bug 860121 Opened 7 years ago Closed 7 years ago

Animating the landscape tab menu on tablets yield a white gap between the sidebar and the tab count button

Categories

(Firefox for Android :: General, defect)

ARM
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Tracking Status
fennec 23+ ---

People

(Reporter: aaronmt, Assigned: lucasr)

References

Details

(Whiteboard: ui-hackathon)

Attachments

(1 file)

See screenshot. This looks really jarring while the sidebar is in animating, this keeps flickering.

--
Nexus 7 (Android 4.2.2)
Nightly (04/09)
tracking-fennec: --- → ?
My guess is that this is related to some of the recent changes sriram made on the toolbar layout. Sriram?
Flags: needinfo?(sriram)
tracking-fennec: ? → 23+
I've seen this in the past. The only change my patch did is to remove the "dark tabs fake layer" behind the tabs button. Do we want to add that back? That's clearly an overdraw. This feels like the elements are dropping frames while animating,
Flags: needinfo?(sriram)
Whiteboard: ui-hackathon
Assignee: nobody → lucasr.at.mozilla
This will be fixed with the patch for bug 867554.
Depends on: 867554
Pushed: https://hg.mozilla.org/integration/mozilla-inbound/rev/e6c09bae2a13

We'll probably need to fix this in Aurora too but this patch is too big and has too many dependencies with other large patches to be upliftable. So, we still need a patch for aurora.
(In reply to Lucas Rocha (:lucasr) from comment #4)
> Pushed: https://hg.mozilla.org/integration/mozilla-inbound/rev/e6c09bae2a13
> 
> We'll probably need to fix this in Aurora too but this patch is too big and
> has too many dependencies with other large patches to be upliftable. So, we
> still need a patch for aurora.

Probably not needed for Fx22. Looks like it's tracking Fx23 only.
Fixed: https://hg.mozilla.org/mozilla-central/rev/e6c09bae2a13
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.