860158 - Language in search box changes while typing

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Keyboards and IME, defect)

Description

[Sergey]

User Agent: Mozilla/5.0 (Android; Mobile; rv:21.0) Gecko/21.0 Firefox/21.0
Build ID: 20130401191647

Steps to reproduce:

Both Firefox 20 and Firefox Beta 21, russian localization
Phone: LG optimus L7 2 (P713), russian language
Android 4.1.2
Kernel version 3.4.0

When I have tab opened with some site loaded already and I want to make search, I tap on address bar, keyboard appears with english letters, I switch to russian language, type in first word in russian, press space and then keyboard switches to english, though I didn't touch language button.

For example, on bugzilla's page I tap address bar, type in "красная " and keyboard language switches to english and I see english letters on it. I can't reproduce it on new opened tab, only on tab with already loaded site (no matter what language it uses)


Actual results:

Keyboard's language switched by itself


Expected results:

Keyboard's language should have remained unchanged until I change it myself

Comment 1

[Aaron Train [:aaronmt]]

Hi Sergey,

Which Android keyboard are you using?

Comment 2

[Sergey]

Default keyboard, it's named LG keyboard

(In reply to Aaron Train [:aaronmt] from comment #1)
> Hi Sergey,
> 
> Which Android keyboard are you using?

Comment 3

[Matvey]

I can confirm this — wanted to file this bug, too. It is easily reproducible, happens all the time. Seing it on Samsung Galaxy S3, and seen earlier on S2. Stock Androids, 4.1.x and 2.3.x respectively, default Samsung keyboards.

Just tried it in Firefox Beta 21, steps to reproduce exactly like Sergey says, but I have Firefox with english localization and Android with English (United States) an system language. This bug occurred for me since several versions ago.

I'm going to make a video demo of it later.

Comment 4

[Aaron Train [:aaronmt]]

Hi Matvey/Sergey,

If you can provide exact steps to reproduce that would be great. I have an SII (i9100), but am confused at what your system language is when you start Firefox and when you are changing languages. Any clarification would help, thanks.

Comment 5

[Matvey]

Hi, Aaron.

0) in Samsung keyboard settings, have more than one Input Languages. I have English(UK), Русский, Українська

1) load some webpage in Firefox
2) tap into the address bar, keyboard appears.
3) switch the keyboard language to Russian by sliding the spacebar.
4) type any word into the address bar, type space after the word. I entered «тест »

The keyboard changes its language back to English when space is entered.

This occurs with search suggestion both enabled and disabled, just in case.

Comment 6

[Sergey]

Aaron,

In my case I have two input languages: english and russian.

1) Load some page
2) Tap address bar. Keyboard apperas with default language english
3) Switch language to russian by tapping "en" button on keyboard
4) Type any word then type space

By the way, if I type space at first - same thing happens - language changes.

And if I change language again to russian (without hiding keyboard) and start typing with any sequence of charachters - everything will be fine.

Comment 7

[Aaron Train [:aaronmt]]

Thanks for the steps. I haven't any luck thus far able to reproduce on my SII (i9100, 4.0.4); nor with my Nexus 4 (Android 4.2.2). Is your device system language set as English or Russian?

This is starting to sound like a device/OS specific issue.

Jim, can you take a look at this?

Comment 8

[Matvey]

SGSIII (i9300) with Android 4.1.2
Device language set to English (United States)

Comment 9

[Aaron Train [:aaronmt]]

Aha, I was able to reproduce testing on a Galaxy Note II (Android 4.1.2, Samsung keyboard: English (en-US) and Russian (Российская) as my input languages). Steps used :: went to http://techmeme.com, tapped the address-bar and entered тест, and hit the spacebar and it did indeed switch over back to english. I wonder if this is a Samsung bug in Jellybean?

Comment 10

[Matvey]

(In reply to Aaron Train [:aaronmt] from comment #9)
> I wonder if this is a Samsung bug in Jellybean?

I tested this in Opera Mobile, Beta (webkit), Mini, Chrome and Android browser. The language doesn't switch there this way.

Comment 11

[(inactive) Jim Chen [:jchen] [:darchons]]

I can reproduce. Will look at later.


(In reply to Matvey from comment #10)
> (In reply to Aaron Train [:aaronmt] from comment #9)
> > I wonder if this is a Samsung bug in Jellybean?
> 
> I tested this in Opera Mobile, Beta (webkit), Mini, Chrome and Android
> browser. The language doesn't switch there this way.

Firefox's address bar switches from "URL" mode to "search" mode when you enter a space, and that apparently confuses the Samsung keyboard.

Comment 12

[Sergey]

My device is LG, not Samsung, a bit later will try to reproduce on HTC One X, will feedback about result.

Comment 13

[Sergey]

On HTC One X a bit different: language changes after first letter input

Comment 14

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Unset URL input type when entering search string for all IMEs (v1)

This patch switches from URL mode to text mode when entering search string for all IMEs (not just gesture ones). AwesomeBar.onWindowFocusChanged() was removed because we don't have to detect IME changing anymore. Also, InputMethods.isGestureKeyboard() was kept for possible future use, but it can be removed too.

Comment 15

[Chris Peterson [:cpeterson]]

Comment on attachment 740601 [details] [diff] [review]
Unset URL input type when entering search string for all IMEs (v1)

Review of attachment 740601 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM. I don't like to leave unused code, but I agree that leaving InputMethods.isGestureKeyboard() is reasonable because it has some quirky logic that might be overlooked by anyone doing future work with gesture keyboards.

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/658cd8210aec

Comment 17

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/658cd8210aec

Comment 18

[Aaron Train [:aaronmt]]

Uplift?

Comment 19

[(inactive) Jim Chen [:jchen] [:darchons]]

This depends on bug 862069, so that would have to be uplifted first.

Comment 20

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Patch for beta uplift

[Approval Request Comment]

Bug caused by (feature/regressing bug #): N/A

User impact if declined: Bug 861943, unable to select all of URL for copying, bad user experience

Testing completed (on m-c, etc.): Locally, Aurora, Nightly

Risk to taking this patch (and alternatives if risky): Very little; the patch has been tested in Aurora and Nightly for many weeks.

String or IDL/UUID changes made by this patch: None

Comment 21

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Patch for beta uplift

[Approval Request Comment]

Bug caused by (feature/regressing bug #): N/A

User impact if declined: Bug 861943, unable to select all of URL for copying, bad user experience

Testing completed (on m-c, etc.): Locally, Aurora, Nightly

Risk to taking this patch (and alternatives if risky): Very little; the patch has been tested in Aurora and Nightly for many weeks.

String or IDL/UUID changes made by this patch: None

Comment 22

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 758846 [details] [diff] [review]
Patch for beta uplift

approving for b5 uplift as per https://bugzilla.mozilla.org/show_bug.cgi?id=861943#c11 and akeybl's comment https://bugzilla.mozilla.org/show_bug.cgi?id=862069#c12

Comment 23

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/4694500fe3f6

Comment 24

[Sergey]

For a moment I experience opposite language problem: when typed in first word in english and then space, language switches to russian. First situation (First word in russian) now works fine.

Comment 25

[Sergey]

Added:
This only happens when I'm located on page with russian search word, example:
On blank page I tap url bar, type in "андроид", hit enter button, then I get google's search page results for "андроид" request. After search pge load I tap url bar, english keyboard appears, I type in "android" then space and language switches to russian.

If first search word is in english, language won't switch.