860284 - Gaia browser broken against mozilla-central

Status: RESOLVED INVALID

(Firefox OS Graveyard :: Gaia::Browser, defect)

Description

[Benoit Jacob [:bjacob] (mostly away)]

Well, I'm using the graphics branch, but it should be no different from mozilla-central in this respect, and people on #b2g confirmed similar symptoms on mozilla-central.

Some of the symptoms are:
 - no 'Browser' process in 'adb shell b2g-ps'
 - pinch-zoom not working
 - browser does not remember any history (it seems)

I need a working Gaia browser in a separate process to reproduce/test graphics bugs.

Comment 1

[Patrick Wang (Chih-Kai Wang) (:kk1fff)]

Could you try changing this line: https://github.com/mozilla-b2g/gaia/blob/c998c9ce045a8a858b7e155944b7b4f6573d2c22/apps/browser/js/browser.js#L1437 to iframe.setAttribute('mozbrowser', true)? if this fixes the problem, it could because iframe WebIDL landed on central, and Browser App needs corresponding change. (The change landed in Gaia's master branch.)

Comment 2

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

That seems to fix the problem.

Comment 3

[Ben Francis [:benfrancis]]

What branch of gaia are you using, and will the WebIDL changes be uplifted to 1.0.1 and 1.1?

If so, then this may become tef+ or leo+ in future and require an uplift.

Comment 4

[Benoit Jacob [:bjacob] (mostly away)]

For the record, I was using the default Gaia from B2G 1.0. I didn't realize that I should switch to "gaia master" or however it's called.

Comment 5

[Ben Francis [:benfrancis]]

Patrick,

What were the bug numbers for the Gecko and Gaia changes in mozilla-central and gaia? We should mark the dependency in case one of them gets uplifted.

Comment 6

[Patrick Wang (Chih-Kai Wang) (:kk1fff)]

Bug 844169 is Gecko change and Gaia change is in Bug 853845. None of them are marked to uplift.

Comment 7

[Ben Francis [:benfrancis]]

Shouldn't be an issue if you use the version of Gaia with the corresponding version of Gecko.