Closed
Bug 860338
Opened 11 years ago
Closed 11 years ago
remove MOZ_WEBVTT
Categories
(Core :: Audio/Video, defect)
Core
Audio/Video
Tracking
()
RESOLVED
FIXED
mozilla23
People
(Reporter: rillian, Assigned: rillian)
References
Details
Attachments
(1 file, 4 obsolete files)
3.11 KB,
patch
|
Details | Diff | Splinter Review |
The webvtt dom implementation and parser are a small amount of code. Given the tendency of these build-time switches to bitrot, it's not worth keeping this MOZ_WEBVTT. forked from https://bugzilla.mozilla.org/show_bug.cgi?id=833385#c33
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #736025 -
Flags: review?(ted)
Updated•11 years ago
|
Attachment #736025 -
Flags: review?(ted) → review+
Assignee | ||
Comment 2•11 years ago
|
||
Thanks for the review. Turns out I missed an instance in layout/media/Makefile.in. Updating the patch to add this one.
Attachment #736025 -
Attachment is obsolete: true
Assignee | ||
Comment 3•11 years ago
|
||
Carrying forward earlier r+. https://hg.mozilla.org/integration/mozilla-inbound/rev/d757eeebcc43
Assignee | ||
Comment 4•11 years ago
|
||
Commit didn't build on inbound. Philor suggested pushing with a clobber update. Backed out as https://hg.mozilla.org/integration/mozilla-inbound/rev/d757eeebcc43
Comment 5•11 years ago
|
||
Relanded with /CLOBBER in https://hg.mozilla.org/integration/mozilla-inbound/rev/f21835504604, filed bug 861579 on needing to clobber.
Comment 6•11 years ago
|
||
Turns out what I meant was "oh, look, every single build you got that said it was a clobber failed, probably if you ask khuey about it he'd say 'it's not clear to me how that patch is expected to build at all since it builds media/webvtt after layout/media ...'." Backed out again in http://hg.mozilla.org/integration/mozilla-inbound/rev/7c09ade1b900
Comment on attachment 736986 [details] [diff] [review] updated patch You changed the build order and put media/webvtt after layout/media, so when we try to link gkmedias WebVTT isn't built yet, unless we happen to have a copy of it sitting around from the previous build in the objdir.
Attachment #736986 -
Flags: review-
Assignee | ||
Comment 8•11 years ago
|
||
Given the tendency of build-time switches to bitrot, it's not worth keeping this one. The webvtt dom implementation and parser are a small amount of code. Given the tendency of build-time switches to bitrot, it's not worth keeping this one.
Assignee | ||
Comment 9•11 years ago
|
||
Comment on attachment 737202 [details] [diff] [review] remove MOZ_WEBVTT. webvtt dom implementation and parser are a small amount of code. Move add_tier_dir back to the original location so it's built before layout tries to link it.
Attachment #737202 -
Flags: review?(khuey)
Assignee | ||
Updated•11 years ago
|
Attachment #736986 -
Attachment is obsolete: true
Attachment #737202 -
Flags: review?(khuey) → review+
Please don't duplicate the commit message btw.
Assignee | ||
Comment 11•11 years ago
|
||
Thanks for pointing out the actual problem we were having. Updating the patch to remove the duplicate commit message. Carrying forward r+.
Attachment #737202 -
Attachment is obsolete: true
Assignee | ||
Updated•11 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 12•11 years ago
|
||
Restore updated reviewer tag. Saturday-night hg is not my strong point.
Attachment #737206 -
Attachment is obsolete: true
Comment 13•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/fe71fc5d8267
Keywords: checkin-needed
Comment 14•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/fe71fc5d8267
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
Updated•11 years ago
|
Assignee | ||
Comment 15•11 years ago
|
||
Thanks for cleaning up the metadata. I don't think we need to keywords on the bug. MOZ_WEBVTT was never documented on developer.mozilla.org and behaviour won't change until the run-time pref in bug 833385 is flipped in the default build.
Keywords: dev-doc-needed,
site-compat
You need to log in
before you can comment on or make changes to this bug.
Description
•