860371 - Remove dist/bin when starting a build

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

See bug 819493 comment 47 as to why this is a necessary evil.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Remove dist/bin when starting a build

This sucks, but it's better than clobbering when we remove files. At least until we handle things in a better way.

Comment 2

[Gregory Szorc [:gps]]

Comment on attachment 735858 [details] [diff] [review]
Remove dist/bin when starting a build

Review of attachment 735858 [details] [diff] [review]:
-----------------------------------------------------------------

Reluctant r+ makes sad panda sadder.

Comment 3

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/859361dea2f0

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/859361dea2f0

Comment 5

[(not currently active) Ted Mielczarek]

This made Win32 PGO builds not use any profiling input, because they expect to get it from dist/bin:
http://hg.mozilla.org/mozilla-central/annotate/7b8ed29c6bc0/config/rules.mk#l713

We run the binaries from dist/firefox, but we move the pgc files to dist/bin:
http://mxr.mozilla.org/mozilla-central/source/Makefile.in#169

This was apparently to support PGOing NSPR in bug 675593.

Comment 6

[Boris Zbarsky [:bzbarsky]]

So do we need to back this out to fix PGO builds, then?

Comment 7

[Mike Hommey [:glandium]]

Backed out from m-c
https://hg.mozilla.org/mozilla-central/rev/7712e67a7c1e

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e8fc37e73844

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e8fc37e73844

Comment 10

[Randell Jesup [:jesup] (needinfo me)]

Is there any way that instead of removing dist/bin, we could empty it instead?  (Even better would be to empty it of files we create, but that's a minor nice-to-have - jprof and some other uses default to saving output in the current directory i.e. bin.)

The use case is: I keep a shell in bin often, and build in another shell, to avoid constant pushd/popd.  Sometimes when debugging I'll rebuild and not leave gdb, just do "file firefox" to avoid losing all my debugging setup (breakpoints, etc)

Comment 11

[Mike Hommey [:glandium]]

Please don't change bug status for a question.

We don't have a list of what in dist/bin is a product of the build or not, so no, it's not possible.

Comment 12

[Randell Jesup [:jesup] (needinfo me)]

Sorry, status change must have been automatic; I didn't touch it.  Is emptying the directory possible instead of removing it?  That would solve most of my use-cases.

Comment 13

[Mike Hommey [:glandium]]

(In reply to Randell Jesup [:jesup] from comment #12)
> Is emptying the directory possible instead of removing it?  That would solve
> most of my use-cases.

That would be possible. Please file a followup