Closed Bug 860371 Opened 7 years ago Closed 7 years ago

Remove dist/bin when starting a build

Categories

(Firefox Build System :: General, defect)

x86_64
Linux
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla23

People

(Reporter: glandium, Assigned: glandium)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

See bug 819493 comment 47 as to why this is a necessary evil.
This sucks, but it's better than clobbering when we remove files. At least until we handle things in a better way.
Attachment #735858 - Flags: review?(gps)
Assignee: nobody → mh+mozilla
Comment on attachment 735858 [details] [diff] [review]
Remove dist/bin when starting a build

Review of attachment 735858 [details] [diff] [review]:
-----------------------------------------------------------------

Reluctant r+ makes sad panda sadder.
Attachment #735858 - Flags: review?(gps) → review+
https://hg.mozilla.org/mozilla-central/rev/859361dea2f0
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
This made Win32 PGO builds not use any profiling input, because they expect to get it from dist/bin:
http://hg.mozilla.org/mozilla-central/annotate/7b8ed29c6bc0/config/rules.mk#l713

We run the binaries from dist/firefox, but we move the pgc files to dist/bin:
http://mxr.mozilla.org/mozilla-central/source/Makefile.in#169

This was apparently to support PGOing NSPR in bug 675593.
So do we need to back this out to fix PGO builds, then?
Depends on: 861178
Backed out from m-c
https://hg.mozilla.org/mozilla-central/rev/7712e67a7c1e
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
https://hg.mozilla.org/mozilla-central/rev/e8fc37e73844
Status: REOPENED → RESOLVED
Closed: 7 years ago7 years ago
Resolution: --- → FIXED
Is there any way that instead of removing dist/bin, we could empty it instead?  (Even better would be to empty it of files we create, but that's a minor nice-to-have - jprof and some other uses default to saving output in the current directory i.e. bin.)

The use case is: I keep a shell in bin often, and build in another shell, to avoid constant pushd/popd.  Sometimes when debugging I'll rebuild and not leave gdb, just do "file firefox" to avoid losing all my debugging setup (breakpoints, etc)
Status: RESOLVED → REOPENED
Flags: needinfo?(mh+mozilla)
Resolution: FIXED → ---
Please don't change bug status for a question.

We don't have a list of what in dist/bin is a product of the build or not, so no, it's not possible.
Status: REOPENED → RESOLVED
Closed: 7 years ago7 years ago
Flags: needinfo?(mh+mozilla)
Resolution: --- → FIXED
Sorry, status change must have been automatic; I didn't touch it.  Is emptying the directory possible instead of removing it?  That would solve most of my use-cases.
(In reply to Randell Jesup [:jesup] from comment #12)
> Is emptying the directory possible instead of removing it?  That would solve
> most of my use-cases.

That would be possible. Please file a followup
Depends on: 861158
No longer depends on: 861158
Depends on: 868284
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.