Closed Bug 860537 Opened 7 years ago Closed 7 years ago

Some parts of click-to-play don't work if you disable doorhangers

Categories

(SeaMonkey :: UI Design, defect)

defect
Not set

Tracking

(seamonkey2.17 unaffected, seamonkey2.18 fixed, seamonkey2.19 fixed, seamonkey2.20 fixed)

RESOLVED FIXED
seamonkey2.20
Tracking Status
seamonkey2.17 --- unaffected
seamonkey2.18 --- fixed
seamonkey2.19 --- fixed
seamonkey2.20 --- fixed

People

(Reporter: neil, Assigned: neil)

References

Details

Attachments

(1 file)

Bug 807664 added code to the doorhanger-only section of notification.xml, and then bug 837399 compounded the issue by adding more code.
Attached patch Proposed patchSplinter Review
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #736029 - Flags: review?(philip.chee)
Comment on attachment 736029 [details] [diff] [review]
Proposed patch

r=me
Attachment #736029 - Flags: review?(philip.chee) → review+
Pushed comm-central changeset 0e185eec4ded.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.20
Comment on attachment 736029 [details] [diff] [review]
Proposed patch

[Approval Request Comment]
Regression caused by (bug #): 807664
User impact if declined: Can't decline click-to-play without doorhangers
Testing completed (on m-c, etc.): Landed on c-c
Risk to taking this patch (and alternatives if risky): Low, mostly moved code
String changes made by this patch: None
Attachment #736029 - Flags: approval-comm-beta?
Attachment #736029 - Flags: approval-comm-aurora?
Attachment #736029 - Flags: approval-comm-beta?
Attachment #736029 - Flags: approval-comm-beta+
Attachment #736029 - Flags: approval-comm-aurora?
Attachment #736029 - Flags: approval-comm-aurora+
You need to log in before you can comment on or make changes to this bug.