860559 - Contacts API: add pref field

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Gregor Wagner [:gwagner]]

From:
https://wiki.mozilla.org/ContactsAPI

We should add the pref field:
 interface ContactField : nsISupports
 {
   attribute DOMString[] type;   // "home", "work", etc.
   attribute DOMString   value;
   attribute integer     pref; // 0 = no pref, 1 = preferred (vCard3 type:PREF)
 };

Reuben can you take this?

Comment 1

[Tantek Çelik]

Also in interface ContactAddress.

Comment 2

[Reuben Morais [:reuben]]

Attachment: Add pref field

Holding up on the review until bug 856358 lands to avoid rebase hell.

Comment 3

[Gregor Wagner [:gwagner]]

Comment on attachment 736472 [details] [diff] [review]
Add pref field

Review of attachment 736472 [details] [diff] [review]:
-----------------------------------------------------------------

Adding Jonas for the IDL review.

::: dom/interfaces/contacts/nsIContactProperties.idl
@@ +8,4 @@
>  interface nsIContactAddress : nsISupports
>  {
>    attribute DOMString type;
> +  attribute integer   pref; // 0 = no pref, 1 = preferred (vCard3 type:PREF)

We should change it to a bool because the sysapps group is in favor of a bool pref.

@@ +23,2 @@
>    attribute DOMString value;
> +  attribute integer   pref; // 0 = no pref, 1 = preferred (vCard3 type:PREF)

bool as well

Comment 4

[Tantek Çelik]

Spec updated accordingly as well for a boolean pref:

https://wiki.mozilla.org/WebAPI/ContactsAPI#ContactField

Comment 5

[Mounir Lamouri (:mounir)]

Comment on attachment 736472 [details] [diff] [review]
Add pref field

Review of attachment 736472 [details] [diff] [review]:
-----------------------------------------------------------------

sr=me if you use bool

Comment 6

[Reuben Morais [:reuben]]

https://hg.mozilla.org/projects/birch/rev/9ae254158eae

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9ae254158eae

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f9969228d973