860603 - The incoming call only displays in status bar for landscape locked fullscreen apps

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect, P2)

Description

[sync-1]

+++ This bug was initially created as a clone of Bug #430734 +++
 
 AU_LINUX_GECKO_ICS_STRAWBERRY_V1.01.00.01.19.044
 Firefox os  v1.0.1
 Mozilla build ID: 20130319070203
 
 DEFECT DESCRIPTION:
 
 The incoming call only display in status bar.
 
 APK name:Poppit
 
 REPRODUCING PROCEDURES:
 
 1.Launch Poppit->play game
 2.Incoming a call->it will only display in status bar==>KO,details as video.
 
 EXPECTED BEHAVIOUR:
 ==>Should display normally.
 
 ASSOCIATE SPECIFICATION:
 
 TEST PLAN REFERENCE:
 
 TOOLS AND PLATFORMS USED:SW115
 
 USER IMPACT:Medium
 
 REPRODUCING RATE:4/5
 
 For FT PR, Please list reference mobile's behavior:
 
 ++++++++++ end of initial bug #430734 description ++++++++++
 
 
 
 CONTACT INFO (Name,Phone number):
 
  DEFECT DESCRIPTION:
 
  REPRODUCING PROCEDURES:
 
  EXPECTED BEHAVIOUR:
 
  ASSOCIATE SPECIFICATION:
 
  TEST PLAN REFERENCE:
 
  TOOLS AND PLATFORMS USED:
 
  USER IMPACT:
 
  REPRODUCING RATE:
 
  For FT PR, Please list reference mobile's behavior:

Comment 1

[sync-1]

reproduced in sw123+dt

Comment 2

[Lisa Brewster [:adora]]

Is there anything the developer is doing to cause this behavior, or is it a platform issue?

Comment 3

[ying.tan]

I'm not sure, but the issue only on poppit

Comment 4

[lbrewster]

Jason, can you shed some light on this?

Comment 5

[Jason Smith [:jsmith]]

I doubt this is a bug on the app developer's side.

[e-mail] - Can you attach that video you are mentioning above?

Comment 6

[ying.tan]

Attachment: incoming call when playing poppit

Comment 7

[Jason Smith [:jsmith]]

Thanks for the video.

This is purely a dialer issue unrelated to the specific app. Technically if you click the phone number, you'll still be able to access and answer the call.

The UX feels quite odd here though.

Can someone UX check this to see if this right vs. wrong behavior?

Comment 8

[Beatriz Rodríguez [:brg]]

This issue is very critical for the behaviour of the phone, please fix it.
Nominating to TEF?

Comment 9

[Jason Smith [:jsmith]]

I'm guessing the above comment implies this is not right behavior then. Clearing the needinfo flag.

Comment 10

[Tony Chung [:tchung]]

Confirmed.  a full screen locked app like poppit, will display the status bar incoming call only.

Tested against vendor build

Gecko 
Gaia   fd2e9d7501d326db3f1cb66d2c2b6787d61d888a
BuildID 20130508152640
Version 18.0

Comment 11

[Etienne Segonzac (:etienne)]

I wasn't able to reproduce the bug.
I tried:
- a fullscreen app
- a fullscreen app locked in landscape orientation

- from master
- from v1-train

And poppit isn't installing (download error).

Any pointers (other apps that make the bug reproducible...)?

Comment 12

[Etienne Segonzac (:etienne)]

Note that at 00:07 in the video we see the app disappear (showing the phone's background), which may point to an inadvertently pressed home button, which would cause the call screen to be in "status bar mode".

Comment 13

[Jeni]

Issue repros.  
Unagi Build ID: 20130513070209
Kernel Date: Dec 5
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/6e1dbf036d34
Gaia: 54dfb62735c81152eef74eb1768e2bf621c0a258

When user is playing Poppit and receives a phone call the call gets stuck in status bar and user is unable to answer.  Repro rate 2/5 times

Comment 14

[Etienne Segonzac (:etienne)]

The Poppit application is still not installable from the marketplace.
We need complete STR and Comment 12 addressed to unblock this bug.

Comment 15

[buri.blff]

(In reply to Etienne Segonzac (:etienne) from comment #14)
> The Poppit application is still not installable from the marketplace.
> We need complete STR and Comment 12 addressed to unblock this bug.

STR:
1. A is a FFOS phone, B is another phone.
2. Play poppit on phone A.
3. Phone B call phone A. You can see the phone A screen at 00:04 of the video. 
   There's only a number on wallpaper, no buttons.

During the operation as video shows, we never touch the phone A.
At 00:10 we just hang up phone B so phone A go back to homescreen automatically.

Comment 16

[Jason Smith [:jsmith]]

(In reply to Etienne Segonzac (:etienne) from comment #14)
> The Poppit application is still not installable from the marketplace.
> We need complete STR and Comment 12 addressed to unblock this bug.

I can help out with that. I've got an older version of the app here - http://mozqa.com/webapi-permissions-tests/ under Packaged App Test Case 20. if the older version doesn't reproduce this, then I can get the updated one uploaded.

Comment 17

[ying.tan]

 I can update poppit from market place now,the url is OK.
https://marketplace.firefox.com/app/d37cb5ed-525a-408e-a7cf-ec848064e041/manifest.webapp

Comment 18

[ying.tan]

 I can update poppit from market place now,the url is OK.
https://marketplace.firefox.com/app/d37cb5ed-525a-408e-a7cf-ec848064e041/manifest.webapp

Comment 19

[Etienne Segonzac (:etienne)]

(In reply to Jason Smith [:jsmith] from comment #16)
> (In reply to Etienne Segonzac (:etienne) from comment #14)
> > The Poppit application is still not installable from the marketplace.
> > We need complete STR and Comment 12 addressed to unblock this bug.
> 
> I can help out with that. I've got an older version of the app here -
> http://mozqa.com/webapi-permissions-tests/ under Packaged App Test Case 20.
> if the older version doesn't reproduce this, then I can get the updated one
> uploaded.

Thanks Jason!
I'm finally able to reproduce the bug.

Let's fix it now :)

Comment 20

[Etienne Segonzac (:etienne)]

Attachment: Patch proposal

It's the fact that the Poppit app is oom killed when receiving a call that was causing the issue.
Here is a patch keeping the call screen open in this case.

Comment 21

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 750421 [details] [diff] [review]
Patch proposal

Review of attachment 750421 [details] [diff] [review]:
-----------------------------------------------------------------

Sounds a simple fix. Thanks.

Comment 22

[Kai-Chih Hu [:khu]]

Thank you, Vivien! 
Can we land this before May 21th? Thanks!

Comment 23

[Etienne Segonzac (:etienne)]

https://github.com/mozilla-b2g/gaia/commit/af15e30051af05a150d85fbe29e5fa9b6bbc2570

Comment 24

[Gareth Aye [:gaye] (back from PTO)]

Uplifted af15e30051af05a150d85fbe29e5fa9b6bbc2570 to:
v1-train: a3036f43e906e59d2af26160776fefcd38738ed8
v1.0.1: 424d7f0523530c9bfea01d6267b81d0c84da038a

Comment 25

[Jason Smith [:jsmith]]

So this works on 1.01 in it's general concept, but I'm seeing two fallouts:

- We are transitioning a landscape app to portrait, so we're getting broken UI in the case of a landscape locked app

- Accepting the call then ending it will kill the app originally in use, even if there were no other apps currently in use

Comment 26

[Jason Smith [:jsmith]]

Filed the following bugs that I found (might be completely unrelated to this bug though):

- bug 874181
- bug 874182