860905 - Context menu Open Link in New Window broken in MailNews [gContextMenu.openLink is not a function]

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: General, defect)

Description

[Jens Hatlak (:InvisibleSmiley)]

STR: Try "Open Link in New Window" from inside MailNews (e.g. the "SeaMonkey" link in the MailNews start page header)

Starting with 2.18b1, nothing happens (2.17 is fine).
The following appears on the Error Console:

Error: TypeError: gContextMenu.openLink is not a function
Source: chrome://messenger/content/messenger.xul
Line: 1

Neil, Ian, Philip, can you help track down the bug that caused this? I guess it was a suite-global change rather than one limited to MailNews. Maybe related to private browsing?

We shall get this fixed ASAP so we have time to verify and request branch approvals before 2.18 leaves the beta stage.

Comment 1

[[e-mail]]

Attachment: Draft patch

Presumably at some point we'll want to open links from mail into private windows, but unfortunately the access key is used by Delete, so that won't work right now.

Comment 2

[[e-mail]]

Attachment: Proposed patch

Comment 3

[Philip Chee]

Comment on attachment 736536 [details] [diff] [review]
Proposed patch

WFM r=me

Comment 4

[[e-mail]]

Pushed comm-central changeset 9ba43addb8ab.

Comment 5

[[e-mail]]

Comment on attachment 736536 [details] [diff] [review]
Proposed patch

[Approval Request Comment]
Regression caused by (bug #): 841230
User impact if declined: Menuitem does not work
Testing completed (on m-c, etc.): Landed on c-c
Risk to taking this patch (and alternatives if risky): Low
String changes made by this patch: None

Comment 6

[[e-mail]]

https://hg.mozilla.org/releases/comm-aurora/rev/90d5ca3ecce6
https://hg.mozilla.org/releases/comm-beta/rev/aa541a194882