Last Comment Bug 860905 - Context menu Open Link in New Window broken in MailNews [gContextMenu.openLink is not a function]
: Context menu Open Link in New Window broken in MailNews [gContextMenu.openLin...
: regression
Product: SeaMonkey
Classification: Client Software
Component: MailNews: General (show other bugs)
: Trunk
: All All
-- major with 1 vote (vote)
: seamonkey2.20
Assigned To:
Depends on:
Blocks: 841230
  Show dependency treegraph
Reported: 2013-04-11 13:42 PDT by Jens Hatlak (:InvisibleSmiley)
Modified: 2013-04-14 15:27 PDT (History)
4 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---

Draft patch (1.35 KB, patch)
2013-04-11 15:42 PDT,
no flags Details | Diff | Splinter Review
Proposed patch (1.11 KB, patch)
2013-04-11 15:44 PDT,
philip.chee: review+
iann_bugzilla: review+
iann_bugzilla: approval‑comm‑aurora+
iann_bugzilla: approval‑comm‑beta+
Details | Diff | Splinter Review

Description User image Jens Hatlak (:InvisibleSmiley) 2013-04-11 13:42:13 PDT
STR: Try "Open Link in New Window" from inside MailNews (e.g. the "SeaMonkey" link in the MailNews start page header)

Starting with 2.18b1, nothing happens (2.17 is fine).
The following appears on the Error Console:

Error: TypeError: gContextMenu.openLink is not a function
Source: chrome://messenger/content/messenger.xul
Line: 1

Neil, Ian, Philip, can you help track down the bug that caused this? I guess it was a suite-global change rather than one limited to MailNews. Maybe related to private browsing?

We shall get this fixed ASAP so we have time to verify and request branch approvals before 2.18 leaves the beta stage.
Comment 1 User image 2013-04-11 15:42:43 PDT
Created attachment 736534 [details] [diff] [review]
Draft patch

Presumably at some point we'll want to open links from mail into private windows, but unfortunately the access key is used by Delete, so that won't work right now.
Comment 2 User image 2013-04-11 15:44:42 PDT
Created attachment 736536 [details] [diff] [review]
Proposed patch
Comment 3 User image Philip Chee 2013-04-12 07:03:04 PDT
Comment on attachment 736536 [details] [diff] [review]
Proposed patch

WFM r=me
Comment 4 User image 2013-04-12 16:00:43 PDT
Pushed comm-central changeset 9ba43addb8ab.
Comment 5 User image 2013-04-12 16:01:49 PDT
Comment on attachment 736536 [details] [diff] [review]
Proposed patch

[Approval Request Comment]
Regression caused by (bug #): 841230
User impact if declined: Menuitem does not work
Testing completed (on m-c, etc.): Landed on c-c
Risk to taking this patch (and alternatives if risky): Low
String changes made by this patch: None

Note You need to log in before you can comment on or make changes to this bug.