860966 - Compile failure in msgMapiImp.cpp with Visual Studio 2012

Status: RESOLVED FIXED

(MailNews Core :: Simple MAPI, defect)

Description

[Frank Wein [:mcsmurf]]

When trying to compile SeaMonkey with Visual Studio 2012, the builds stops when trying to compile msgMapiImp.cpp because of those two errors:
http://hg.mozilla.org/comm-central/annotate/724e23e39c73/mailnews/mapi/mapihook/src/msgMapiImp.cpp#l339
Returning an nserror in a function with a LONG return type

and
http://hg.mozilla.org/comm-central/annotate/724e23e39c73/mailnews/mapi/mapihook/src/msgMapiImp.cpp#l385
Returning an nserror in a function with a HRESULT return type (says the compiler)

Comment 1

[[e-mail]]

Previous versions of VC don't support strongly typed enums so they silently cast nsresult to LONG/HRESULT/whatever. Anyway, we shouldn't be returning NS_ERROR_FAILURE, we should be using Microsoft error codes.

Comment 2

[:aceman]

Something like MAPI_E_FAILURE ?

Comment 3

[Frank Wein [:mcsmurf]]

Attachment: Patch

This patch fixes the build, but still need to check if everything works as expected. I'm not sure what the meaning of the "// get the singelton obj" comment is in that context (when returning because of an error).

Comment 4

[Frank Wein [:mcsmurf]]

Attachment: Patch

This one is the correct patch, mixed up two patches there.

Comment 6

[Mark Banner (:standard8)]

Comment on attachment 736914 [details] [diff] [review]
Patch

Looks good to me.

Comment 7

[Makoto Kato [:m_kato]]

https://hg.mozilla.org/comm-central/rev/7ec742c695b8