860995 - [B2G] [Contacts]: Contact Search by Phone Number Does Not Highlight That Number

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[mlevin]

Description:
The phone number searched for is not highlighted, when searching for a contact in the Contact app when that contact has more than one phone number stored.

Prerequisite:
Have multiple contact stored or imported in the Contact app. Ensure that one of the contacts has more than one phone number associated with it.

Repro Steps:
1) Manually update to Unagi Build ID: 20130411070205
2) Open up the Contacts app.
3) Tap into the search field.
4) Type a phone number which will bring up a contact which has multiple phone numbers stored in it.

Actual:
Upon tapping the contact name found, the phone number entered in the search field is not highlighted.

Expected:
Upon tapping the contact name found, the phone number entered in the search field to be highlighted.

Environmental  Variables:
Kernel Date: Dec 5
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/f671fa539473
Gaia: e7e338a765e22334b40ced41489a785941382c66

Notes:
Repro frequency: (4/4)
Test Suite Name: Contacts
UCID: (contacts-001)
Link to failed test case: https://moztrap.mozilla.org/results/cases/?pagenumber=1&pagesize=20&sortfield=created_on&sortdirection=desc&filter-id=7035
Q Analysts Test Team Priority: 3

Comment 1

[sarsenyev]

This issue reproduces on Inari device.
The search result is not highlighted 

Environmental  Variables:
Inari Build ID: 20130515070208
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/d06cfe7d67c2
Gaia: 0ddb515f15cbc6b74fc2742b7599d6ae74c6413f

Comment 2

[Chris Kreinbring [:CKreinbring]]

Still repros on Leo 1.1 commercial and Unagi 1.2 mozilla RILs.  Selecting a searched contact via phone numbers will not highlight the number when the contact is selected.

Leo
Build ID: 20130812041203
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/36bbc5943448
Gaia: c60e3507d9df160e006d2e25967d26df2dc543cb
Platform Version: 18.1
RIL Version: 01.01.00.019.184

Unagi
Build ID: 20130811040204
Gecko: http://hg.mozilla.org/mozilla-central/rev/3d20597e0a07
Gaia: 1b9019acdc1eea9cfe78edeb914eba6e8153fbbe
Platform Version: 26.0a1

Comment 3

[Neeraj]

Attachment: Proposed patch for this bug.

Hello,

Here is the patch for this bug : https://github.com/mozilla-b2g/gaia/pull/11533

Please review this and let me know if any changes is required.

Regards,

Comment 4

[Francisco Jordano [:arcturus] [:francisco]]

Jose is on PTO till 1st of september, if you want this change to be reviewed please assing Ben Kelly or myself to this review.

Cheers,
F.

Comment 5

[Neeraj]

Attachment: Patch for this bug.

Hello Francisco,

I have updated the PR with your suggestions on github. Please review and let me know if this works :)

Regards,
Neeraj

Comment 6

[Francisco Jordano [:arcturus] [:francisco]]

Is this part of leo or koi work?

I have to prioritize my review queue and don't know if this is part of any of those target milestones.

Thanks,
F.

Comment 7

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 792143 [details]
Patch for this bug.

Sorry but this patch doesnt point to anything I can review.

Could you provide the correct patch?

Thanks!
F.

Comment 8

[Neeraj]

(In reply to Francisco Jordano [:arcturus] from comment #7)
> Comment on attachment 792143 [details]
> Patch for this bug.
> 
> Sorry but this patch doesnt point to anything I can review.
> 
> Could you provide the correct patch?
> 
> Thanks!
> F.

Hello Francisco,

I have update the same pull request. Here is the link for ur reference : https://github.com/mozilla-b2g/gaia/pull/11533 . 

BTW thanks a lot for your review :)

Regards,
Neeraj

Comment 9

[Francisco Jordano [:arcturus] [:francisco]]

Hi Neeraj!

Could you change the flag to r+ again, so I will get noticed that there is a new version of the PR :)

Thanks!

Comment 10

[Neeraj]

Comment on attachment 792143 [details]
Patch for this bug.

DONE and below is the link : 
https://github.com/mozilla-b2g/gaia/pull/11533
 
Regards :)

Comment 11

[Borja Salguero [:borjasalguero]]

Comment on attachment 790181 [details] [review]
Proposed patch for this bug.

Taking the review due to Jose Manuel is on holidays!

Comment 12

[Borja Salguero [:borjasalguero]]

Comment on attachment 790181 [details] [review]
Proposed patch for this bug.

Patch reviewed. I've found some issues, but Im concerned overall about the UX needed for fixing this bug. The style added to this patch should be aligned with UX, so I will ask for help to UX Team here. Please take a look to the comments! Thanks! ;)

Comment 13

[Borja Salguero [:borjasalguero]]

Victoria, could you help us on this? Thanks!

Comment 14

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 792143 [details]
Patch for this bug.

The patch itself doesnt contains any patch :(

Comment 15

[Victoria Gerchinhoren [:vicky]]

Visually, there's a pattern that covers this, highlighting the portion of information that matches the search. But if there's any extra logic needed to cover the case when a single contact has more than one number, this should be specified in the interaction docs.

Ping Ayman to provide input here.

 (In reply to Borja Salguero [:borjasalguero] from comment #13)
> Victoria, could you help us on this? Thanks!

Comment 16

[ayman maat :maat]

(In reply to Victoria Gerchinhoren from comment #15)
> Visually, there's a pattern that covers this, highlighting the portion of
> information that matches the search. But if there's any extra logic needed
> to cover the case when a single contact has more than one number, this
> should be specified in the interaction docs.
> 
> Ping Ayman to provide input here.
> 
>  (In reply to Borja Salguero [:borjasalguero] from comment #13)
> > Victoria, could you help us on this? Thanks!

Yeh, we need to do some updates/enhancements to the UX and specs here.. nothing has moved in the spec since Dan Oliver did the original ones pre V1...

will knock something up and post here. leaving ni? to self until i post

Comment 17

[ayman maat :maat]

Attachment: FFOS_Search_V1.2_20130912_V1.0.pdf

this is a proposition for enhancements we should make to the presentation of search results within the Contacts app.

Comment 18

[Johan Lorenzo [:jlorenzo]]

If I remember correctly, we stopped highlighting numbers in 2.0. There is no need to fix this particular case then. I removed the test case for version 2.2 and 3.0.