Modify --testing-modules-dir for android xpcshell tests

RESOLVED FIXED

Status

Release Engineering
General Automation
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: gbrown, Assigned: Callek)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
In bug 828069, I asked :Callek to pass --testing-modules-dir to remotexpcshelltests.py, and he implemented that accurately.

But from the discussion in bug 857252, I'm pretty sure I was completely wrong: we should not pass --testing-modules-dir at all and should instead rely on the hack at https://hg.mozilla.org/mozilla-central/file/7712e67a7c1e/testing/xpcshell/runxpcshelltests.py#l690.

It looks to me like --testing-modules-dir is not passed when running the desktop xpcshell tests.

Using --testing-modules-dir for android xpcshell tests does not cause any problems currently, but causes various failures when trying to run additional tests: https://tbpl.mozilla.org/?tree=Try&rev=9581bc27560a

(See bug 762837 for the original work on testing-modules-dir.)
(Assignee)

Updated

5 years ago
Assignee: nobody → bugspam.Callek
(Reporter)

Comment 1

5 years ago
It turns out that if --testing-modules-dir is not passed to remotexpcshelltests.py, the hack in runxpcshelltests.py is not effective: https://tbpl.mozilla.org/?tree=Try&rev=6b0dea0f831e.

Basically the hack sets the modules directory too late for the remote script to do the correct initialization/setup.

Moving the hack such that it is effective for the remote case looks complicated.

I could duplicate the hack in remotexpcshelltests.py, but I wonder if it wouldn't be better if we simply pass the correct modules directory on the command line. This try run verifies that --testing-modules-dir=xpcshell/../modules works fine: https://tbpl.mozilla.org/?tree=Try&rev=b57b9152dce9. 

I think "--testing-modules-dir=modules" ought to work fine.
(Reporter)

Updated

5 years ago
Summary: Do not pass --testing-modules-dir when running android xpcshell tests → Modify --testing-modules-dir for android xpcshell tests
(Reporter)

Updated

5 years ago
Blocks: 865006
(Assignee)

Comment 2

5 years ago
Created attachment 743149 [details] [diff] [review]
[custom] use modules/ instead

This should do it
Attachment #743149 - Flags: review?(rail)
Attachment #743149 - Flags: feedback?(gbrown)
Comment on attachment 743149 [details] [diff] [review]
[custom] use modules/ instead

Will this somehow affect other branches?
(Assignee)

Comment 4

5 years ago
(In reply to Rail Aliiev [:rail] from comment #3)
> Comment on attachment 743149 [details] [diff] [review]
> [custom] use modules/ instead
> 
> Will this somehow affect other branches?

No, its only active on trunk/related. It was a newly added test suite. And this change won't break/hurt any test that is already running this anyway (we only enabled one test so far, where the modules/ is not technically required, this change allows us to enable more tests)
Attachment #743149 - Flags: review?(rail) → review+
(Reporter)

Comment 5

5 years ago
Comment on attachment 743149 [details] [diff] [review]
[custom] use modules/ instead

Review of attachment 743149 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #743149 - Flags: feedback?(gbrown) → feedback+
(Assignee)

Comment 6

5 years ago
Comment on attachment 743149 [details] [diff] [review]
[custom] use modules/ instead

https://hg.mozilla.org/build/buildbotcustom/rev/08dcd33abccb
Attachment #743149 - Flags: checked-in+
In production
(Assignee)

Updated

5 years ago
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.