Closed Bug 861601 Opened 9 years ago Closed 9 years ago

Suppress gcc -Wmultichar warnings from Android's Stagefright header files

Categories

(Core :: Audio/Video, defect)

All
Android
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla23
Tracking Status
firefox22 --- wontfix
firefox23 --- fixed

People

(Reporter: cpeterson, Assigned: cpeterson)

References

Details

Attachments

(1 file)

Firefox for Android has more -Wmultichar warnings than any other warning type. All 185 of these warnings come from Android's Stagefright header files, which use multichar enum values, e.g. enum { kKeyMIMEType = 'mime' }

  media/omx-plugin/include/froyo/stagefright/MetaData.h:32:20 [-Wmultichar] multi-character character constant
...

Q: Should this media makefile change be reviewed by a build peer?
Attachment #737215 - Flags: review?(chris.double)
Comment on attachment 737215 [details] [diff] [review]
suppress-Wmultichar-warnings.patch

Review of attachment 737215 [details] [diff] [review]:
-----------------------------------------------------------------

I don't know if it needs a build peer but it looks good to me.
Attachment #737215 - Flags: review?(chris.double) → review+
Comment on attachment 737215 [details] [diff] [review]
suppress-Wmultichar-warnings.patch

khuey: Do I need a build peer to r+ this Makefile.in change?
Attachment #737215 - Flags: review?(khuey)
Comment on attachment 737215 [details] [diff] [review]
suppress-Wmultichar-warnings.patch

r? for makefile change
https://hg.mozilla.org/mozilla-central/rev/52fa74fb7b0f
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
Depends on: 989203
You need to log in before you can comment on or make changes to this bug.