Suppress gcc -Wmultichar warnings from Android's Stagefright header files

RESOLVED FIXED in Firefox 23

Status

()

Core
Audio/Video
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: cpeterson, Assigned: cpeterson)

Tracking

unspecified
mozilla23
All
Android
Points:
---

Firefox Tracking Flags

(firefox22 wontfix, firefox23 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 737215 [details] [diff] [review]
suppress-Wmultichar-warnings.patch

Firefox for Android has more -Wmultichar warnings than any other warning type. All 185 of these warnings come from Android's Stagefright header files, which use multichar enum values, e.g. enum { kKeyMIMEType = 'mime' }

  media/omx-plugin/include/froyo/stagefright/MetaData.h:32:20 [-Wmultichar] multi-character character constant
...

Q: Should this media makefile change be reviewed by a build peer?
Attachment #737215 - Flags: review?(chris.double)

Comment 1

5 years ago
Comment on attachment 737215 [details] [diff] [review]
suppress-Wmultichar-warnings.patch

Review of attachment 737215 [details] [diff] [review]:
-----------------------------------------------------------------

I don't know if it needs a build peer but it looks good to me.
Attachment #737215 - Flags: review?(chris.double) → review+
(Assignee)

Comment 2

5 years ago
Comment on attachment 737215 [details] [diff] [review]
suppress-Wmultichar-warnings.patch

khuey: Do I need a build peer to r+ this Makefile.in change?
Attachment #737215 - Flags: review?(khuey)
(Assignee)

Comment 3

5 years ago
Comment on attachment 737215 [details] [diff] [review]
suppress-Wmultichar-warnings.patch

r? for makefile change
(Assignee)

Comment 4

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/52fa74fb7b0f
status-firefox22: --- → wontfix
status-firefox23: --- → fixed

Comment 5

5 years ago
https://hg.mozilla.org/mozilla-central/rev/52fa74fb7b0f
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
(Assignee)

Updated

4 years ago
Depends on: 989203
You need to log in before you can comment on or make changes to this bug.