861601 - Suppress gcc -Wmultichar warnings from Android's Stagefright header files

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Chris Peterson [:cpeterson]]

Attachment: suppress-Wmultichar-warnings.patch

Firefox for Android has more -Wmultichar warnings than any other warning type. All 185 of these warnings come from Android's Stagefright header files, which use multichar enum values, e.g. enum { kKeyMIMEType = 'mime' }

  media/omx-plugin/include/froyo/stagefright/MetaData.h:32:20 [-Wmultichar] multi-character character constant
...

Q: Should this media makefile change be reviewed by a build peer?

Comment 1

[cajbir (:cajbir)]

Comment on attachment 737215 [details] [diff] [review]
suppress-Wmultichar-warnings.patch

Review of attachment 737215 [details] [diff] [review]:
-----------------------------------------------------------------

I don't know if it needs a build peer but it looks good to me.

Comment 2

[Chris Peterson [:cpeterson]]

Comment on attachment 737215 [details] [diff] [review]
suppress-Wmultichar-warnings.patch

khuey: Do I need a build peer to r+ this Makefile.in change?

Comment 3

[Chris Peterson [:cpeterson]]

Comment on attachment 737215 [details] [diff] [review]
suppress-Wmultichar-warnings.patch

r? for makefile change

Comment 4

[Chris Peterson [:cpeterson]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/52fa74fb7b0f

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/52fa74fb7b0f