861620 - Improve test coverage in backend components

Status: RESOLVED FIXED

(Calendar :: General, defect)

Description

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

The components in base/src/ can easily be tested using unit tests, we should improve our test coverage in that area.

While creating a patch for this bug, I have also found some issues with our code.

Comment 1

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: New and Improved Testcases - v1

These are the testcases that will cover the other patches.

Comment 2

[Matthew Mecca [:mmecca]]

Comment on attachment 737267 [details] [diff] [review]
New and Improved Testcases - v1

Review of attachment 737267 [details] [diff] [review]:
-----------------------------------------------------------------

Everything looks good as far as I can see. r=mmecca

::: calendar/test/unit/test_alarm.js
@@ +145,5 @@
>      } catch (e) {}
>  
> +    // No attendee yet, should not be initialized
> +    do_check_throws(function() {
> +      alarm.icalComponent;

nit - a 4 space indent would match the rest of the file

::: calendar/test/unit/test_recur.js
@@ +385,3 @@
>      // removeOccurrenceAt/restoreOccurreceAt
> +    var occDate1 = cal.createDateTime("20020403T114500Z");
> +    var occDate2 = cal.createDateTime("20020404T114500Z");

A few var's could be changed to let's in this file

Comment 3

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Pushed to comm-central changeset d1605239dd10