861905 - Contacts API: Shortcut permission check in the child

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Gregor Wagner [:gwagner]]

We spend a lot of time checking the permission for the call log and in the sms app. We can avoid one child-parent roundtrip per DB entry.

Comment 1

[Gregor Wagner [:gwagner]]

Attachment: patch

Comment 2

[Gregor Wagner [:gwagner]]

Attachment: patch

Comment 3

[Gregor Wagner [:gwagner]]

Attachment: patch

Comment 4

[Reuben Morais [:reuben]]

Comment on attachment 737533 [details] [diff] [review]
patch

Review of attachment 737533 [details] [diff] [review]:
-----------------------------------------------------------------

Nice!

::: dom/contacts/ContactManager.js
@@ +562,5 @@
>        default:
>          access = "unknown";
>        }
>  
> +    // Shortcut for ALLOW_ACTION

Can you expand this explanation a little bit? Something like
// Avoid the IPC round trip if we don't have to prompt for the permission.

Comment 5

[Gregor Wagner [:gwagner]]

Comment on attachment 737533 [details] [diff] [review]
patch

Maybe Mounir has more time for a review.

Comment 6

[Mounir Lamouri (:mounir)]

Comment on attachment 737533 [details] [diff] [review]
patch

Review of attachment 737533 [details] [diff] [review]:
-----------------------------------------------------------------

r=me but it's not crystal clear to me why we were not doing that since the beginning. APIs should simply check for the permission on the child and anyway, the parent will kill them if the child request something that they should not be requesting.

Comment 7

[Gregor Wagner [:gwagner]]

Attachment: patch

Comment 8

[Gregor Wagner [:gwagner]]

Attachment: patch

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/projects/birch/rev/4f58c0e74b97

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4f58c0e74b97

Comment 11

[David Scravaglieri [:scravag]]

Blocks a leo+ bug so blocking.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/5fe874b8efbd

Comment 13

[Gregor Wagner [:gwagner]]

(In reply to David Scravaglieri [:scravag] from comment #11)
> Blocks a leo+ bug so blocking.

I guess everything is done here.