86197 - "all" or "any" radio group in the filter edit dialog looks bad in classic skin

Status: VERIFIED FIXED

(MailNews Core :: Filters, defect)

Description

[(not reading, please use [e-mail] instead)]

"all" or "any" radio group in the filter edit dialog looks bad in classic skin

it doesn't look bad in the modern skin.

it starts looking real fugly once you start toggling.

I'll get a screen shot.

Comment 1

[(not reading, please use [e-mail] instead)]

Attachment: this was after toggling a few times

Comment 2

[Håkan Waara]

Let's test this again when my patch from bug 82773 has landed.

Comment 3

[Håkan Waara]

Argh, this looks very bad in Classic even after my landing. The radiobuttons
toggles their positions each time you click.

Comment 4

[andreww]

most likely some fix got into modern and or win classic but mac got 
neglected .... argh.

Comment 5

[Håkan Waara]

No, this is not mac-only! I see it constantly on windows 98 classic.

Comment 6

[andreww]

I wonder if this is related to another bug in dialogs which have radio 
buttons... they do the same sort of moving around....

Comment 7

[laurel]

I'd already reported this (see bug 82013), but nobody paid attention ... it's
really great to have all this attention paid to these dialogs at the last minute.

Comment 8

[laurel]

*** Bug 82013 has been marked as a duplicate of this bug. ***

Comment 9

[Håkan Waara]

At the last minute? I'm doing everything I can to make the filters UI good again
- since no one has actively maintained it for a long, long time.

Comment 10

[Håkan Waara]

Will get fixed with the patch in bug 83763!

*** This bug has been marked as a duplicate of 83763 ***

Comment 11

[laurel]

Marking verified as a duplicate.
Someone else will need to verify this case is indeed fixed by the other bug's
patch.  I'm not going to look at the trunk until after Netscape's commercial RTM.

Comment 12

[(not reading, please use [e-mail] instead)]

I think a simple, one like patch could be created for this problem and landed on 
the 0.9.2 branch.

low risk, and good reward (for classic skin users)

Comment 13

[laurel]

If we're going to apply a single item patch for the branch, let's reopen this
and let it stand for the branch patch? 

Comment 14

[(not reading, please use [e-mail] instead)]

taking...

Comment 15

[(not reading, please use [e-mail] instead)]

low hanging fruit (for nsBranch)

Comment 16

[(not reading, please use [e-mail] instead)]

adding to the nsBranch list.

Comment 17

[Blake Ross]

I already fixed this for the search window, it's probably the same.  I think you 
just need to remove the autostretch from the radiogroup.

Comment 18

[(not reading, please use [e-mail] instead)]

right, I'm using blake's fix (from another bug).

it's a simple one liner, here comes the patch.

giving to blake (so he'll get the glory)

Comment 19

[(not reading, please use [e-mail] instead)]

Attachment: one line fix for the 0.9.2 branch

Comment 20

[(not reading, please use [e-mail] instead)]

that fix comes from something we already got r, and sr.

but sr=sspitzer once again.  now to go get permission to land.

Comment 21

[(not reading, please use [e-mail] instead)]

this nsBranch bug will land on the branch after 0.9.2 ships.

(I'll land it for blake.)

Comment 22

[(not reading, please use [e-mail] instead)]

a=asa.  fixed on the 0.9.2 branch and the trunk.

marking fixed.

Comment 23

[laurel]

OK using july 2 commercial 0.9.2 branch builds: mac OS 9.0, linux rh6.2, win98
OK for both filters and message search dialogs.

Comment 24

[laurel]

OK using aug10 commercial trunk build: win98, linux rh6.2, mac OS 9.0.
OK in Search Messages and Filter Rules.