Closed Bug 862145 Opened 12 years ago Closed 8 years ago

Use the wrapper cache for inner windows

Categories

(Core :: DOM: Core & HTML, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED DUPLICATE of bug 990158

People

(Reporter: bzbarsky, Unassigned)

Details

Right now we don't. No one really knows a reason not to, so we should.
In particular, the concern here is that inner windows implement the wrapper cache via their inheritance chain, but don't implement it via QI. But since the new DOM bindings use the inheritance chain to determine who implements nsWrapperCache, we may run into bugs where we create a second XPCWN for the inner after having found null in the wrapper cache. See the discussion around bug 862077 comment 5.
I think that when I added the wrapper cache to the outer window, I was snakebitten by other small and seemingly innocuous changes causing massive headaches. So I made the smallest possible change in order to appease the fickle gods of docshell and global windows. Basically, I'm trying to say that I had no good reason to restrict the wrapper cache to outer windows.
Fixed by bug 990158.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → DUPLICATE
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.