990158 - Make inner windows use their wrapper cache

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Peter Van der Beken [:peterv]]

Attachment: v1

Comment 1

[Peter Van der Beken [:peterv]]

Attachment: v1.1

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8402817 [details] [diff] [review]
v1.1

>@@ -2335,66 +2320,65 @@ nsGlobalWindow::SetNewDocument(nsIDocume
>     if (aState) {
>-      mInnerWindowHolder = wsh->GetInnerWindowHolder();

Why is that line being removed?

The rest looks fine, though the crash-on-touch bits seem like dead code?  Maybe a followup to nix it?

r=me with the above removal fixed or explained.

Comment 3

[Peter Van der Beken [:peterv]]

(In reply to Boris Zbarsky [:bz] from comment #2)
> >-      mInnerWindowHolder = wsh->GetInnerWindowHolder();
> 
> Why is that line being removed?

Yeah, looks iffy. It didn't seem to cause problems but I've moved it into the patch that actually removes mInnerWindowHolder.

https://hg.mozilla.org/integration/mozilla-inbound/rev/f1e4f0f82a9a

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f1e4f0f82a9a

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/874d97918b82