Closed
Bug 862306
Opened 12 years ago
Closed 12 years ago
Route audio stream to BT_SCO in AudioManager
Categories
(Core :: General, defect)
Tracking
()
People
(Reporter: gyeh, Assigned: rlin)
References
Details
(Whiteboard: [fixed-in-birch])
Attachments
(3 files)
1.36 KB,
patch
|
mwu
:
review+
|
Details | Diff | Splinter Review |
1.82 KB,
patch
|
Details | Diff | Splinter Review | |
1.81 KB,
patch
|
Details | Diff | Splinter Review |
Per Randy in https://bugzilla.mozilla.org/show_bug.cgi?id=859727#12, we'd like to route audio stream after bt_sco is established/broken in AudioManager.
Reporter | ||
Comment 1•12 years ago
|
||
Nominated as leo? since it blocks bug 859727(leo+).
blocking-b2g: --- → leo?
Assignee | ||
Comment 2•12 years ago
|
||
We want to remove the patch switch logic on bluetooth, so we decide to move the setforceuse from bluetooch to audioManager.
Attachment #737970 -
Flags: review?(fabrice)
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → rlin
Assignee | ||
Updated•12 years ago
|
Attachment #737970 -
Flags: review?(fabrice) → review?(mchen)
Comment 3•12 years ago
|
||
Comment on attachment 737970 [details] [diff] [review]
Route audio stream to BT_SCO in AudioManager
Hi Randy,
I have no right to review code in this file so transfer to Michael Wu.
Hi Michanel,
Could you help to review this patch?
Attachment #737970 -
Flags: review?(mchen) → review?(mwu)
Updated•12 years ago
|
blocking-b2g: leo? → leo+
Comment 4•12 years ago
|
||
Comment on attachment 737970 [details] [diff] [review]
Route audio stream to BT_SCO in AudioManager
Review of attachment 737970 [details] [diff] [review]:
-----------------------------------------------------------------
Code looks right but I don't understand one comment.
::: dom/system/gonk/AudioManager.cpp
@@ +154,4 @@
> AUDIO_POLICY_DEVICE_STATE_AVAILABLE, address);
> AudioSystem::setDeviceConnectionState(AUDIO_DEVICE_IN_BLUETOOTH_SCO_HEADSET,
> AUDIO_POLICY_DEVICE_STATE_AVAILABLE, address);
> + // Phase in the a2dp profile, this should be called when phone call is established.
Can you rephrase this? I don't understand what this means.
Attachment #737970 -
Flags: review?(mwu) → review+
Assignee | ||
Comment 5•12 years ago
|
||
remove the comment,
It's just remonder we should have another change when a2dp feature is enabled.
Assignee | ||
Comment 6•12 years ago
|
||
this patch should apply with the bug 859727 at the same time.
Whiteboard: checkin-needed
Reporter | ||
Comment 7•12 years ago
|
||
Thanks, Randy. I'll land it with bug 859727 to birch.
Reporter | ||
Comment 8•12 years ago
|
||
Reporter | ||
Updated•12 years ago
|
Whiteboard: checkin-needed → checkin-needed [fixed-in-birch]
Updated•12 years ago
|
Whiteboard: checkin-needed [fixed-in-birch] → [fixed-in-birch]
Comment 9•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
Comment 10•12 years ago
|
||
status-b2g18:
--- → fixed
status-b2g18-v1.0.0:
--- → wontfix
status-b2g18-v1.0.1:
--- → wontfix
status-firefox21:
--- → wontfix
status-firefox22:
--- → wontfix
status-firefox23:
--- → fixed
Comment 11•11 years ago
|
||
This patch is required by bug 872428, which is tef+, so I'm requesting tef+ here so we can uplift this.
blocking-b2g: leo+ → tef?
Updated•11 years ago
|
Updated•11 years ago
|
Whiteboard: [fixed-in-birch] → [status: needs uplift][fixed-in-birch]
Comment 14•11 years ago
|
||
Whiteboard: [status: needs uplift][fixed-in-birch] → [fixed-in-birch]
You need to log in
before you can comment on or make changes to this bug.
Description
•