872428 - [Bluetooth][Certification]Audio path does not route to Bluetooth SCO

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Bluetooth, defect)

Description

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

While testing AG_ACS, we found audio path does not output to correct path in v1.0.1.
After patch of Bug 830213 applied, the code of audio path shall also be changed.

Comment 1

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Attachment: Patch1:V1 for b2g18-v101

This is must have patch, otherwise BT SCO audio path get screw up.

Comment 2

[Randy Lin [:rlin] - Be Mozillian on 2015/01/26]

Comment on attachment 749738 [details] [diff] [review]
Patch1:V1 for b2g18-v101

Review of attachment 749738 [details] [diff] [review]:
-----------------------------------------------------------------

The patch looks to me. But needs mwu to give r+.

Comment 3

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Attachment: Patch1:V1 for central,

Comment 4

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Attachment: Patch1:V1 for b2g18

b2g18 version

Comment 5

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

For central, b2g18 patch, if aData is empty Bluetooth address, it shall do setForce to None. Without this, it can also cause serious audio path missing problem.

Comment 6

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

I've tested the following scenarios:
Scenario A:
1. Connected BT headset, during call session, turn off BT headset
2. Check audio path correctly switch back to earpiece

Scenario B:
1. Connected BT headset, during call session, switch to speaker, turn off BT headset
2. Check audio path correctly switch back to speaker
3. Switch to earpieces again and check audio path routed to earpieces

Scenario C:
1. Turn off Bt headset, make a phone call, during the call session, turn on BT headset
2. Check audio path correctly switch back to BT headset
3. Switch to speaker again check path to speaker

Comment 7

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Sorry, update comment but touch blocking-b2g:tef+.

Comment 8

[Kai-Chih Hu [:khu]]

tef+ again.

Comment 9

[Michael Wu [:mwu]]

Comment on attachment 749749 [details] [diff] [review]
Patch1:V1 for central,

Review of attachment 749749 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/system/gonk/AudioManager.cpp
@@ +144,5 @@
>                        const char* aTopic,
>                        const PRUnichar* aData)
>  {
>    if (!strcmp(aTopic, BLUETOOTH_SCO_STATUS_CHANGED)) {
> +    if (NS_strlen(aData) > 0) {

Testing for *aData would be the fastest way, though perhaps not the most obvious.

Comment 10

[Michael Wu [:mwu]]

Comment on attachment 749738 [details] [diff] [review]
Patch1:V1 for b2g18-v101

This looks identical to the m-c patch + bug 862306. I'm going to request tef+ for bug 862306 so you can uplift that.

Comment 11

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Attachment: b2g18-v101:Bug 872428 - Fix missing setForceUse to BT SCO for audio path, r=mwu, a=tef+

Comment 12

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Attachment: b2g18:Bug 872428 - Fix missing setForceUse to BT SCO for audio path, r=mwu, a=tef+

Comment 13

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Attachment: central:Bug 872428 - Fix missing setForceUse to BT SCO for audio path, r=mwu, a=tef+

Comment 14

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Note: b2g18v101 patch depend on bug 862306. So bug 862306 needs to uplift first.

Comment 15

[Eric Chou [:ericchou] [:echou]]

birch: https://hg.mozilla.org/projects/birch/rev/1e5c4b1cd4c4

Comment 16

[Eric Chou [:ericchou] [:echou]]

(In reply to Shawn Huang from comment #14)
> Note: b2g18v101 patch depend on bug 862306. So bug 862306 needs to uplift
> first.

bug 862306 has been landed.

Comment 17

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Hello Ryan, can you help to uplift?

Comment 18

[Ryan VanderMeulen [:RyanVM]]

(In reply to Shawn Huang from comment #17)
> Hello Ryan, can you help to uplift?

As usual, once birch is merged to m-c next, I'll take care of the uplift, yes.

Comment 19

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1e5c4b1cd4c4

Comment 20

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/5001c6dc28c9
https://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/f1c7ac4070e2

Comment 21

[Mila Davydova]

Unable to verify. Lack of resources. Need Bluetooth PTS tool to verify.
Marking as QARegressExclude.