862467 - Tool for reviewers to edit feature profile

Status: VERIFIED FIXED

(Marketplace Graveyard :: Reviewer Tools, defect, P1)

Description

[Rob Hudson [:robhudson]]

Reviewers may need to change the feature profile of an app/version. Perhaps simply allow reviewers to access/edit the devhub's version of this.

Comment 1

[Mathieu Pillard [:mat]]

No need to depend on bug 862474 (rob confirmed on IRC). Also, see bug 862466 which is similar.

Comment 2

[Mathieu Pillard [:mat]]

I did some work on getting reviewers the rights to edit an app's features from devhub, but it gets really really ugly very quickly, especially for hosted apps.

See WIP at https://github.com/diox/zamboni/tree/reviewer_edit_features_profile if you are interested.

I think it's going to be much much easier & cleaner to simply re-use the AppFeaturesForm in the reviewer pages so I'm going to try that instead.

Comment 3

[Mathieu Pillard [:mat]]

Fixed in https://github.com/mozilla/zamboni/commit/354da9a11c2b25a9ea47ca61bf8b1319f691af97

Steps to reproduce:
- Make sure buchets waffle flag is enabled
- Upload a new app, packaged or hosted
- Review this app. When selecting 'push to public', you should be able to override minimum requirements
- Check that the requirements changed when you do (they should be displayed on the reviewer interface as well thanks to bug 862466). 

Note that if the app was set to be published immediately and the reviewer changed the requirements, it should not be published automatically (similar to what happens when device are overridden by reviewer).

Comment 4

[Iulian Timis]

Verified as fixed in https://marketplace-dev.allizom.org/reviewers/ on FF24 (Win 7).
Postfix screencast http://screencast.com/t/Hnyz4KSDtOk
The requirements change in Reviewer tools when they are changed in Dev Hub.
Closing bug.