862590 - Grammar typo in bluetooth/transfer.html: "settings is correct" -- should say "are" instead of "is"

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Bluetooth, defect)

Description

[Daniel Holbert [:dholbert]]

bluetooth/transfer.html has a typo in the raw HTML:
>        <p data-l10n-id="error-transfer-settings">
>          Bluetooth file transfer failed. Check that the Bluetooth settings is correct.
https://github.com/mozilla-b2g/gaia/blob/master/apps/bluetooth/transfer.html#L45

That needs s/is/are/.

The corresponding .locale file has the correct string, which was fixed in
https://github.com/mozilla-b2g/gaia/commit/f6aa5f0e4379601c722173cd49f1eae5852e7595#L0L8
...but that fix apparently didn't make it to the HTML file.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix [as pull request link]

Comment 2

[Daniel Holbert [:dholbert]]

Not sure if this counts as a string-change, given that the en-US locale file is already correct and I assume (?) that localizers are using that as a template instead of using the html file's text...?  (and it's just a grammar typo with no change in meaning)

cc'ing Pike to see if I'm off-base on that. I don't touch strings much, so I'm unfamiliar with how we handle them.

Comment 3

[Daniel Holbert [:dholbert]]

For reference, the already-correct locale file is:
https://github.com/mozilla-b2g/gaia/blob/master/apps/bluetooth/locales/bluetooth.en-US.properties#L8

(and of course in comment 0, by ".locale file", I meant "locale .properties file")

Comment 4

[Daniel Holbert [:dholbert]]

(side note: the html file has "Ok"[1] where the corresponding locale file's string is "OK" [2], with a capital "K".  Should I file a followup on making that consistent, or does that matter?)

[1] https://github.com/mozilla-b2g/gaia/blob/master/apps/bluetooth/transfer.html#L76
[2] https://github.com/mozilla-b2g/gaia/blob/master/apps/bluetooth/locales/bluetooth.en-US.properties#L9

Comment 5

[Axel Hecht [:Pike]]

Updating the HTML only is fine.

Note: Some apps explicitly garbage the in-html strings, to check for non-exposed strings. There isn't a general rule that the inline strings must match what's in the .properties.

Comment 6

[Daniel Holbert [:dholbert]]

Thanks Axel!

Also: it looks like these strings-in-the-HTML might be going away or autogenerated or something, per bug 812993 and per bug 812977 comment 2.

So the "OK" vs "Ok" thing in comment 4 probably isn't an issue.  Still: until that happens, I think we might as well fix the grammar typo in the HTML, for professionalism/correctness if nothing else.

Comment 7

[Fabien Cazenave [:kaze]]

Comment on attachment 738243 [details]
fix [as pull request link]

Hi Daniel, thanks for the patch!

https://github.com/mozilla-b2g/gaia/commit/0e0265124b2c276ea1c52eacce70fc50cb7149c8

Comment 8

[Daniel Holbert [:dholbert]]

Thanks, kaze!