812977 - Copy review for the bucket 2 string freeze

Status: RESOLVED FIXED

Description

[Staś Małolepszy :stas]

Let's review the en-US strings for consistency, wording, style and grammar before we string-freeze for Bucket 2.

Comment 1

[Staś Małolepszy :stas]

Created attachment 683012 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/6485/files

Pointer to Github pull-request

Comment 2

[Staś Małolepszy :stas]

Comment on attachment 683012 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/6485/files

Kazé, the changes only touch .properties files.   I didn't change the string values in the HTML code.  It's mostly because I'd like to remove them entirely (bug 812993) so that would be a pointless exercise.

Comment 3

[Scoobidiver (away)]

Certain changes impact all locales (localizers wont' be warned of these changes as string labels are unchanged):
* Punctuation:
apps ⊃ dialer.properties ⊃ ussd-server-error
apps ⊃ settings.properties ⊃ shortStatus-connected
apps ⊃ settings.properties ⊃ shortStatus-connectingfailed
apps ⊃ settings.properties ⊃ shortStatus-disconnected
apps ⊃ costcontrol.properties ⊃ topup-confirmation-message
apps ⊃ costcontrol.properties ⊃ balance-error-message
apps ⊃ costcontrol.properties ⊃ application-error-message
apps ⊃ costcontrol.properties ⊃ top-up-in-progress
apps ⊃ costcontrol.properties ⊃ on-topup-not-confirmed-title
apps ⊃ email.properties ⊃ settings-password-empty
apps ⊃ settings.properties ⊃ fullStatus-connected
apps ⊃ settings.properties ⊃ fullStatus-connectingfailed
apps ⊃ settings.properties ⊃ fullStatus-disconnected
apps ⊃ settings.properties ⊃ shortStatus-connected
apps ⊃ settings.properties ⊃ shortStatus-connectingfailed
apps ⊃ settings.properties ⊃ shortStatus-disconnected
apps ⊃ settings.properties ⊃ fullStatus-wps-canceled
apps ⊃ settings.properties ⊃ fullStatus-wps-timedout
apps ⊃ settings.properties ⊃ fullStatus-wps-failed
apps ⊃ settings.properties ⊃ fullStatus-wps-overlapped
apps ⊃ settings.properties ⊃ retry-when-online
apps ⊃ system.properties ⊃ sdcard-in-use
* First letter upper case:
apps ⊃ contacts.properties ⊃ no-contacts
apps ⊃ contacts.properties ⊃ start-adding
apps ⊃ settings.properties ⊃ shortStatus-connecting
apps ⊃ settings.properties ⊃ security
apps ⊃ settings.properties ⊃ securityNone
apps ⊃ settings.properties ⊃ securityOpen
apps ⊃ settings.properties ⊃ password
apps ⊃ email.properties ⊃ envelope-cc
apps ⊃ email.properties ⊃ envelope-bcc
apps ⊃ email.properties ⊃ message-search-cancel-accessible
apps ⊃ settings.properties ⊃ error
apps ⊃ settings.properties ⊃ fullStatus-initializing
apps ⊃ settings.properties ⊃ fullStatus-connecting
apps ⊃ settings.properties ⊃ fullStatus-associated
apps ⊃ settings.properties ⊃ shortStatus-connecting
apps ⊃ settings.properties ⊃ shortStatus-associated
apps ⊃ settings.properties ⊃ securedBy
apps ⊃ settings.properties ⊃ security
apps ⊃ settings.properties ⊃ securityNone
apps ⊃ settings.properties ⊃ securityOpen
apps ⊃ settings.properties ⊃ linkSpeed
apps ⊃ settings.properties ⊃ signalStrength
apps ⊃ settings.properties ⊃ signalLevel0
apps ⊃ settings.properties ⊃ signalLevel1
apps ⊃ settings.properties ⊃ signalLevel2
apps ⊃ settings.properties ⊃ signalLevel3
apps ⊃ settings.properties ⊃ signalLevel4
apps ⊃ settings.properties ⊃ showPassword
apps ⊃ settings.properties ⊃ operator-status-connecting
apps ⊃ settings.properties ⊃ operator-status-connectingfailed
apps ⊃ settings.properties ⊃ operator-status-connected
apps ⊃ system.properties ⊃ confirm
* Other upper case:
apps ⊃ email.properties ⊃ dialog-button-ok
apps ⊃ email.properties ⊃ forward-header-cc
* Phrasing:
apps ⊃ settings.properties ⊃ doNotTrack-dd1
apps ⊃ sms.properties ⊃ deleteThreads-confirmation

Comment 4

[Fabien Cazenave [:kaze]]

Comment on attachment 683012 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/6485/files

nice work, merging

Comment 5

[Fabien Cazenave [:kaze]]

err, cannot merge — the patch has bitrotten. Staś, would you rebase it please?

Comment 6

[Staś Małolepszy :stas]

Comment on attachment 683012 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/6485/files

NOTE: If blocking-basecamp+ is set, just land it for now.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): n/a
User impact if declined:  Inconsistent strings in the UI, 
Testing completed: on a desktop build everything works
Risk to taking this patch (and alternatives if risky): it's l10n-only, almost none

Comment 7

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

This bug blocks some blockers. blocking+.

Comment 8

[Staś Małolepszy :stas]

Thanks!

A shout-out to Matej who found time in Singapore to go through all the Gaia apps and create this patch.  I just created the pull request and made a few minor tweaks :)

Comment 9

[Josh Carpenter [:jcarpenter]]

\ o /