Closed Bug 862602 Opened 7 years ago Closed 6 years ago

enable unlocking of not visible images in the current tab on Fennec

Categories

(Core :: Layout: Images, Video, and HTML Frames, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla27

People

(Reporter: tnikkel, Assigned: tnikkel)

References

(Blocks 1 open bug)

Details

(Whiteboard: [MemShrink:P1])

Attachments

(1 file)

Bug 689623 was only enabled on desktop, with mobile and b2g being followups due to the notion of visibility being different there. We should adapt and generalize so we use less memory for images on Fennec.
Whiteboard: [MemShrink:P1]
Attached patch flip the prefSplinter Review
I did some basic testing of this. It seems to work fine on timecube, nytimes, slashdot, google, google images, imgur, facebook.

I also tested that it prevents us from OOMing on my favourite images page http://congressoamericano.blogspot.ca/p/fotos-do-congresso-americano-iii.html

google maps seems to be broken on nightly right now (with the pref on or off), but turning the pref on in aurora seems to work fine. It briefly seemed like turning the pref on made google maps on nightly worse, but now I see the same broken behaviour on nightly with the pref on or off.

kats, do you have any suggestions for further testing before enabling this for all nightly users?
Assignee: nobody → tnikkel
Attachment #808928 - Flags: review?(bugmail.mozilla)
Comment on attachment 808928 [details] [diff] [review]
flip the pref

Review of attachment 808928 [details] [diff] [review]:
-----------------------------------------------------------------

The only thing I'd want to explicitly ensure testing for beyond desktop are some mobile-specific scenarios involving the meta-viewport tag. I don't know how much of this is covered by your basic testing above, but I think the testing should include at least:
(1) a page with no meta-viewport tag,
(2) a page with a meta-viewport tag set to width=device-width (or something similarly small) but that actually has wide content so you can zoom out,
(3) a page that starts off with no meta-viewport tag and later adds one (i.e. goes from case 1 to case 2) and
(4) a page that starts off with a meta-viewport tag and removes it (i.e. goes from case 2 to case 1).

If all those behave well, then I'm all thumbs-up to get this landed! :)
Attachment #808928 - Flags: review?(bugmail.mozilla) → review+
Ok, I tested those cases. No problems detected.
https://hg.mozilla.org/mozilla-central/rev/2c1d2d4368f7
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
Product: Core → Core Graveyard
Product: Core Graveyard → Core
You need to log in before you can comment on or make changes to this bug.