Bug 683284 (image-suck)

[meta] Images suck the snap out of Firefox (memory, flicker, decode/discard heuristics)

NEW
Unassigned

Status

()

Core
ImageLib
6 years ago
3 years ago

People

(Reporter: jrmuizel, Unassigned)

Tracking

(Depends on: 12 bugs, {footprint, meta, perf})

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [please read comment 1 before adding dependencies][snappy:p2])

(Reporter)

Description

6 years ago
This is tracking bug for all of the imagey things we do worse at than other browsers.
(Reporter)

Updated

6 years ago
Depends on: 682638
(Reporter)

Updated

6 years ago
Depends on: 683286
(Reporter)

Updated

6 years ago
Alias: image-suck
(Reporter)

Updated

6 years ago
Depends on: 683290
Blocks: 679775
Blocks: 682230
Depends on: 124608
Depends on: 661304

Updated

6 years ago
OS: Mac OS X → All
Hardware: x86 → All
(Reporter)

Comment 1

6 years ago
I'd like this bug to only address bugs where our behaviour is a clearly wrong compared to other browsers. It's not clear from 124608 what the problem actually is.
No longer depends on: 124608
Blocks: 660577

Updated

6 years ago
Blocks: 685821
No longer blocks: 685821
Whiteboard: [please read comment 1 before adding dependencies]
Depends on: 689623
Duplicate of this bug: 398983
Summary: We suck at images → [meta] We suck at images

Updated

6 years ago
Keywords: meta
Depends on: 689411
Depends on: 691169

Updated

6 years ago
Depends on: 511899
Depends on: 386451

Updated

6 years ago
Depends on: 516320, 684091, 685516, 573583
Keywords: footprint, perf
Summary: [meta] We suck at images → [meta] Images suck the snap out of Firefox (memory, flicker, decode/discard heuristics)
Depends on: 698969

Updated

6 years ago
Depends on: 699150
Depends on: 664291
Whiteboard: [please read comment 1 before adding dependencies] → [please read comment 1 before adding dependencies][MemShrink:P1]
Duplicate of this bug: 660577
Whiteboard: [please read comment 1 before adding dependencies][MemShrink:P1] → [please read comment 1 before adding dependencies]
Whiteboard: [please read comment 1 before adding dependencies] → [please read comment 1 before adding dependencies][snappy]
Depends on: 716725
No longer depends on: 716725
Depends on: 715919
Depends on: 715308
Depends on: 658790
Depends on: 542158
Depends on: 674547

Comment 4

6 years ago
My Firefox crashes almost 20-30 times during a working day because of imagery memory consumption. I miss the good behaving Firefox before. I can hardly recall when is this happening, but it seems that 7.0 or 8.0 may be a start.
> My Firefox crashes almost 20-30 times during a working day because of
> imagery memory consumption.

How do you know it's the memory for images that is the cause?  The only changes to image memory handling that I'm aware of lately should have reduced the memory usage.

Comment 6

6 years ago
Thanks for your correction, and I do not know indeed if it's a consumption problem or not.

But there is indeed problem in Firefox because other related bugs has direct me here.

Comment 7

6 years ago
(In reply to Robert Ciang from comment #4)
> My Firefox crashes almost 20-30 times during a working day because of
> imagery memory consumption. I miss the good behaving Firefox before. I can
> hardly recall when is this happening, but it seems that 7.0 or 8.0 may be a
> start.
Not much change since 4.0 on image heavy site, the good old days your mention was 3.6.

And 32bit Windows system is somehow worse, because an application can have only 2GB address space and Firefox will crash when it consumes about 1.5G RAM..
I summarized this bug and its dependents in this email thread:
https://groups.google.com/forum/#!topic/mozilla.dev.platform/9JZhTxGlG8k
> My Firefox crashes almost 20-30 times during a working day because of imagery memory consumption.

This is a metabug, for tracking multiple separate problems; it is not for discussing any one issue.  If you have steps which reliably cause you to crash, please file a separate bug and CC me on it; I'll follow up.

Updated

6 years ago
Whiteboard: [please read comment 1 before adding dependencies][snappy] → [please read comment 1 before adding dependencies][snappy:p2]
Depends on: 696680

Updated

6 years ago
Duplicate of this bug: 723390
Depends on: 731419

Updated

6 years ago
Blocks: 701625
Depends on: 732820

Comment 11

6 years ago
Bug 659220 which was marked duplicate of bug 660577 which was marked duplicate of this raised a question that I don't see in the remaining live bugs on image consumption. Specifically that DOM/JS image objects are small, even though the images they are holding on to may be large. Since they are small they may not trigger a JS GC, leaving the image layer thinking those images are still in use.

Updated

6 years ago
Duplicate of this bug: 685821

Updated

6 years ago
Depends on: 677727

Updated

5 years ago
Duplicate of this bug: 704680
Depends on: 739245
Duplicate of this bug: 658922
Depends on: 700545

Comment 15

5 years ago
This bug is related huge size about "images/content/used/uncompressed"?
It can reproduce easily in flickr.com slideshow.

Step 1. open this url in 3 more tabs.
http://www.flickr.com/photos/myplanetexperience/7090845767/lightbox/

Step 2. click "play button"

Step 3. 1 hour later, check about:memory

It's a BIG problem in mobile or embedded linux environments.
Thanks,
(In reply to HyungGon Baek from comment #15)
> This bug is related huge size about "images/content/used/uncompressed"?
> It can reproduce easily in flickr.com slideshow.
> 
> Step 1. open this url in 3 more tabs.
> http://www.flickr.com/photos/myplanetexperience/7090845767/lightbox/
> 
> Step 2. click "play button"
> 
> Step 3. 1 hour later, check about:memory
> 
> It's a BIG problem in mobile or embedded linux environments.
> Thanks,

That's roughly Bug 679775, and the fix is Bug 683290.

Comment 17

5 years ago
(In reply to Kyle Huey [:khuey] (khuey@mozilla.com) from comment #16)
> (In reply to HyungGon Baek from comment #15)
> > This bug is related huge size about "images/content/used/uncompressed"?
> > It can reproduce easily in flickr.com slideshow.
> > 
> > Step 1. open this url in 3 more tabs.
> > http://www.flickr.com/photos/myplanetexperience/7090845767/lightbox/
> > 
> > Step 2. click "play button"
> > 
> > Step 3. 1 hour later, check about:memory
> > 
> > It's a BIG problem in mobile or embedded linux environments.
> > Thanks,
> 
> That's roughly Bug 679775, and the fix is Bug 683290.

Thank you very much.
I've applied your patches on ff4.0 and I can't reporduce OOM freezing.

Thanks!!!
Depends on: 686905
Depends on: 651060
No longer depends on: 651060
Depends on: 761113
Depends on: 854783
Depends on: 862602
Depends on: 955884

Comment 18

4 years ago
Wouldn't these qualify for blocking this bug too?
https://bugzilla.mozilla.org/show_bug.cgi?id=941823
https://bugzilla.mozilla.org/show_bug.cgi?id=523950
Depends on: 523950

Updated

3 years ago
Depends on: 1115731
Depends on: 1116359
You need to log in before you can comment on or make changes to this bug.