862628 - security review for share

Status: RESOLVED FIXED

(mozilla.org :: Security Assurance: Review Request, task)

Description

[Shane Caraveo (:mixedpuppy)]

Bug 818675 has the implementation for the share functionality in socialapi.  Would like to get started towards a security review on the implementation.

Comment 1

[Simon Bennetts [:psiinon]]

Whats the target release for this?
Any other links worth looking at in addition to the implementation bug?
I've started reading up on this so will no doubt have more questions in a bit.

Comment 2

[Shane Caraveo (:mixedpuppy)]

I thought I had commented here, how weird.

Firefox 23!  Best bet is to ask me questions, otherwise look at the patch.  I'd be happy to take 5 minutes and explain the area's that you'll need to focus on.  The OpenGraphBuilder class is one.

Comment 3

[Simon Bennetts [:psiinon]]

Who should be invited to the review?
And when are good times for most people?
I'm UK based so earlier in the day is best for me :)
Ideally I'd like to do this next week (starting June 24th)

Comment 4

[Simon Bennetts [:psiinon]]

https://wiki.mozilla.org/Security/Reviews/SocialShare

Comment 5

[Shane Caraveo (:mixedpuppy)]

This is ancient and share has been out for a very long time, there were conversations around this, but I don't recall the results.  Not sure what to do with this bug.