862629 - Stop wrapping WebIDL callbacks into the compartment of the thing we're passing them to

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

This is causing failures with WebIDL event listeners, because if we addEventListener via an Xray we end up wrapping it into the content compartment, and then we can't get it's .handleEvent.

I talked to Kyle and Bobby and they both think we should just stop doing this wrapping altogether rather than special-casing Xrays somehow.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: part 1. Stop playing compartment games with WebIDL callbacks and just use the given object as-is.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: part 2. Remove the now-unused scope object bit in js-to-native conversions.

Comment 3

[Peter Van der Beken [:peterv]]

Comment on attachment 738298 [details] [diff] [review]
part 1.  Stop playing compartment games with WebIDL callbacks and just use the given object as-is.

Review of attachment 738298 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/bindings/CallbackFunction.h
@@ +30,2 @@
>    {
> +    MOZ_ASSERT(JS_ObjectIsCallable(nullptr, aCallable));

Want to file a bug on removing the cx argument or adding a friend api that doesn't need one?

Comment 4

[Boris Zbarsky [:bzbarsky]]

> Want to file a bug on removing the cx argument

Filed bug 865399.

Comment 5

[Boris Zbarsky [:bzbarsky]]

   https://hg.mozilla.org/integration/mozilla-inbound/rev/9129688d03de
   https://hg.mozilla.org/integration/mozilla-inbound/rev/170c15712591

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9129688d03de
https://hg.mozilla.org/mozilla-central/rev/170c15712591