862627 - Switch EventListener to WebIDL codegen

Status: RESOLVED FIXED

(Core :: DOM: Events, defect)

Description

[Boris Zbarsky [:bzbarsky]]

+++ This bug was initially created as a clone of Bug #835643 +++

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Patch that I can land once all the dependencies are fixed

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: An additional bit to rip out now-unused code

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: This should make the new Telephony bits happy

Comment 5

[Boris Zbarsky [:bzbarsky]]

Attachment: Main patch, merged to tip

Comment 6

[Boris Zbarsky [:bzbarsky]]

Attachment: Cleanup, merged to tip

Comment 7

[Boris Zbarsky [:bzbarsky]]

Try run with all dependencies except bug 840201 fixed: https://tbpl.mozilla.org/?tree=Try&rev=672313bc75e1

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

https://tbpl.mozilla.org/?tree=Try&rev=d627866a8122

Comment 9

[Boris Zbarsky [:bzbarsky]]

   https://hg.mozilla.org/integration/mozilla-inbound/rev/29b3256131f4
   https://hg.mozilla.org/integration/mozilla-inbound/rev/872d79fd1982

Halleluiah!

Comment 10

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

\o/

Comment 11

[Olli Pettay [:smaug][[e-mail]]]

Attachment: a test impl for workers

Since khuey had some problem using EventTarget on workers, here is a dummy
implementation. (Really dummmy - because of returning null GetParentObject,
EventReceiver on the main thread may work in a bit unusual way.)

Testcase is loading 
var retval = "FAIL"; var er = new EventReceiver(); er.addEventListener("PASS", function(e) {retval = e.type;}); er.dispatchEvent(new Event("PASS")); retval;
in http://mozilla.pettay.fi/workerconsole/

Comment 12

[Olli Pettay [:smaug][[e-mail]]]

Attachment: a simple thread agnostic EventTarget object

(this one behaves ok on main thread too, and is simpler)

Comment 13

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Happydance!!

Comment 14

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/29b3256131f4
https://hg.mozilla.org/mozilla-central/rev/872d79fd1982