Closed
Bug 862792
Opened 11 years ago
Closed 11 years ago
Replace placeholder selected state indicator for Firefox Start tiles
Categories
(Firefox for Metro Graveyard :: Firefox Start, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: sfoster, Assigned: sfoster)
References
Details
Attachments
(4 files, 1 obsolete file)
The selected tiles need a check image in the top right. Also note that the yellow border should actually overlap the content, not wrap it like a regular border.
Comment 1•11 years ago
|
||
Comment 2•11 years ago
|
||
Comment 4•11 years ago
|
||
Looks good! Only one thing: The origin of the selected image should be the top right of the thumbnail overlapping the border.
Flags: needinfo?(shorlander)
Assignee | ||
Comment 5•11 years ago
|
||
Updated with background-origin set for the selected check, and selected and pinned state adjusted to fit.
Attachment #738586 -
Attachment is obsolete: true
Assignee | ||
Comment 6•11 years ago
|
||
Most of this work landed with the patch on #854960, but theres a stupid typo preventing the selected styles from showing up propertly. This patch fixes that.
Assignee: nobody → sfoster
Attachment #739600 -
Flags: review?(jmathies)
Updated•11 years ago
|
Attachment #739600 -
Flags: review?(jmathies) → review+
Assignee | ||
Comment 7•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/621b1875145e
Assignee | ||
Comment 8•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/621b1875145e
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•