Story - Pin, Unpin, Hide, and Restore a Top Site

VERIFIED FIXED

Status

Tracking
Metro Operations
P2
normal
VERIFIED FIXED
6 years ago
4 years ago

People

(Reporter: asa, Assigned: sfoster)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: feature=story c=Awesome_screen u=metro_firefox_user p=13)

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
Created attachment 703488 [details]
UC-53 	 Pin, unpin, hide, and restore a Top Site
(Reporter)

Updated

6 years ago
Assignee: nobody → asa
Priority: -- → P1
Whiteboard: c=Awesome_screen u= p= → c=Awesome_screen u=metro_firefox_user p=
(Reporter)

Updated

6 years ago
Assignee: asa → nobody
(Reporter)

Updated

6 years ago
Priority: P1 → P2
(Reporter)

Updated

6 years ago
Whiteboard: c=Awesome_screen u=metro_firefox_user p= → c=Awesome_screen u=metro_firefox_user p=8
(Assignee)

Updated

6 years ago
Depends on: 812291
(Assignee)

Updated

6 years ago
Depends on: 832105
(Assignee)

Updated

6 years ago
Assignee: nobody → sfoster
OS: Windows 8 → Windows 8 Metro
Hardware: x86_64 → x86

Updated

6 years ago
Summary: Pin, unpin, hide, and restore a Top Site → Story - Pin, Unpin, Hide, and Restore a Top Site
Whiteboard: c=Awesome_screen u=metro_firefox_user p=8 → feature=story status=for_sprint c=Awesome_screen u=metro_firefox_user p=8

Updated

6 years ago
Status: NEW → ASSIGNED
(Reporter)

Updated

6 years ago
Depends on: 808770

Updated

6 years ago
Depends on: 836387

Updated

6 years ago
Blocks: 837145

Updated

5 years ago
No longer blocks: 837145

Updated

5 years ago
Blocks: 838081
Whiteboard: feature=story status=for_sprint c=Awesome_screen u=metro_firefox_user p=8 → feature=story c=Awesome_screen u=metro_firefox_user p=8

Updated

5 years ago
Blocks: 837155

Updated

5 years ago
No longer blocks: 838081

Updated

5 years ago
Blocks: 838081
No longer blocks: 837155

Updated

5 years ago
Blocks: 839392
No longer blocks: 838081

Updated

5 years ago
Depends on: 829056

Updated

5 years ago
Component: General → Metro Operations
Product: Firefox for Metro → Tracking
Version: unspecified → ---
(Reporter)

Updated

5 years ago
Priority: P2 → P3

Updated

5 years ago
Blocks: 838081
No longer blocks: 839392
Whiteboard: feature=story c=Awesome_screen u=metro_firefox_user p=8 → feature=story c=Awesome_screen u=metro_firefox_user p=13

Updated

5 years ago
Priority: P3 → P2

Updated

5 years ago
Blocks: 842108
No longer blocks: 838081
(Assignee)

Updated

5 years ago
Depends on: 851443
(Assignee)

Updated

5 years ago
Depends on: 854960

Updated

5 years ago
Blocks: 850809
No longer blocks: 842108

Updated

5 years ago
Blocks: 855905
No longer blocks: 850809
(Assignee)

Updated

5 years ago
Depends on: 862792
https://hg.mozilla.org/mozilla-central/rev/621b1875145e
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Assignee)

Comment 2

5 years ago
Mistaken ticket number on my commit maybe, this shouldnt have been closed yet.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Updated

5 years ago
Depends on: 864706
(Assignee)

Updated

5 years ago
Depends on: 865170

Updated

5 years ago
Status: REOPENED → ASSIGNED
(Assignee)

Comment 3

5 years ago
All dependent bugs now in m-c, this should be good to go
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago5 years ago
Resolution: --- → FIXED
Mozilla/5.0 (Windows NT 6.2; WOW64; rv:23.0) Gecko/20130429 Firefox/23.0

Verified the story:
- Right click on a Top Sites tile brings up the context app bar with "Hide" and "Pin tab" options;
- Right click a group of tiles in Top Sites brings up the context app bar with "Hide", "Pin tab" and "Remove selection" options;
- Clicking "Pin button" visually reflects the tile, or group of tiles, that they are in pinned state;
- Clicking "Unpin button" removes the pinned visual style from the tile or group of tiles;
- Clicking "Hide" makes the selected tile or group of tile to disappear;
- Clicking the "Restore" button makes the hidden tile or group of tiles to re-appear;
- For multiple selections, context app bar appears is raised, "Remove selection" button appears, clicking this button removes the selection of tiles.
Status: RESOLVED → VERIFIED
Depends on: 867163
I find it confusing that the same icon is used to delete tiles as is used to dismiss the appbar. The first time I clicked it I was thinkign it would dismiss my selection appbar, but it deleted my tiles.

The undo button is nice, but I think a different icon should be used anyway.
Flags: needinfo?(ywang)
Depends on: 875937
(In reply to Brian R. Bondy [:bbondy] from comment #5)
> I find it confusing that the same icon is used to delete tiles as is used to
> dismiss the appbar. The first time I clicked it I was thinkign it would
> dismiss my selection appbar, but it deleted my tiles.
> 
> The undo button is nice, but I think a different icon should be used anyway.

That's a good catch, Brian.
I agree that using the same "Close" btn for "Delete" action can be confusing. On the mockup Stephen posted, the icons all have labels below, which could help users identify them.

But I think a better solution here should be using a different metaphor for "Delete top sites", like "Trash can". 

Stephen, any thoughts on the "Delete" icon?
Flags: needinfo?(ywang)
Flags: needinfo?(shorlander)
Trash can would work
Did not find additional new issues for it8 testing other than what's mentioned in Comment 6 and already posted as a bug using today's Nightly build.
Yeah we have X icon overload. A trash could work. I will try it.
Flags: needinfo?(shorlander)
Depends on: 887621
Went through the following "Story" for iteration #9 testing and found a defect. Used the following build:

http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-06-26-03-11-00-mozilla-central/

- Went through the original story and the test cases that have been added in comment 4 and found a defect relating to the "Pin" icon not changing states when selected. Added Bug 887621

Updated

5 years ago
No longer depends on: 887621
User Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0
Build ID: 20130819030205
Built from http://hg.mozilla.org/mozilla-central/rev/c8c9bd74cc40

WFM
Tested on windows 8 using latest nightly for iteration-12. Followed steps provided in user story and comment4, and got expected result.
Depends on: 951635

Updated

5 years ago
Depends on: 957009

Updated

5 years ago
No longer depends on: 957009
Depends on: 964149
Depends on: 964285
OS: Windows 8 Metro → Windows 8.1
You need to log in before you can comment on or make changes to this bug.