862808 - Local Video is upside down on Android when in portrait mode

Status: VERIFIED FIXED

(Core :: WebRTC: Audio/Video, defect)

Description

[Mark Banner (:standard8)]

Using the demo at https://webrtc-demo.vcap.mozillalabs.com/ when in a video call, the video for the Android device is displayed upside down on both the Android and the Desktop display.

Tested on a Nexus 4.

Comment 2

[Gian-Carlo Pascutto [:gcp]]

I think this is only for the back cam, but with permissions disabled you can't choose any other :P

Comment 3

[Jason Smith [:jsmith]]

Sounds like a cut and dry blocker for gUM on Android.

Comment 4

[Aaron Train [:aaronmt]]

STR :: https://simpl.info/getusermedia/

--
Nightly (04/17) w/related prefs enabled
LG Nexus 4 (Android 4.2.2)

Comment 5

[Gian-Carlo Pascutto [:gcp]]

FWIW, for these kind of bugs it's going to be really helpful to check whether the bug exists on multiple devices. Also, the subject implies this is only true in portait mode. Is it?

Comment 6

[Gian-Carlo Pascutto [:gcp]]

>Also, the subject implies this is only true in portait mode. Is it?

Well darn, it is. That's...not what I would have expected.

Comment 7

[Gian-Carlo Pascutto [:gcp]]

Attachment: Patch 1. Fix rotation amount calculation

The "compensate the mirror" thing came from the Android docs:
http://developer.android.com/reference/android/hardware/Camera.html#setDisplayOrientation%28int%29
"So the users can see themselves as looking into a mirror."

However, we don't use setDisplayOrientation and show the image that is actually sent to the remote, which doesn't use "mirror" orientation (wtf would you want *that* anyway?).

Tested this on a Nexus 4 to give the correct result in all orientations/cameras.

Comment 8

[Gian-Carlo Pascutto [:gcp]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ff3cfa9675fd

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ff3cfa9675fd

Comment 10

[Gian-Carlo Pascutto [:gcp]]

Comment on attachment 751668 [details] [diff] [review]
Patch 1. Fix rotation amount calculation

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Bug 750010 and friends
User impact if declined: Stiff neck.
Testing completed (on m-c, etc.): Landed on m-c a few days ago.
Risk to taking this patch (and alternatives if risky): Little risk, change in preffed-off feature.

Comment 11

[Gian-Carlo Pascutto [:gcp]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/7c08df3249f9