862994 - Windows pymake in mail directory fails due to differing clang.manifest files

Status: RESOLVED DUPLICATE of bug 852745

(Thunderbird :: Build Config, defect)

Description

[Kent James (:rkent)]

I used to be able to do a shortened rebuild of Thunderbird debug builds by doing pymake in appropriate directories. But since bug 852745 I get this error:

Kent@BW32-1 /c/tb/1-central/tb-pydebug/mail
$ pymake
make.py[0]: Entering directory 'c:\tb\1-central\tb-pydebug\mail'
TEST-UNEXPECTED-FAIL | check-sync-dirs.py | build file copies are not in sync
TEST-INFO | check-sync-dirs.py | file(s) found in:               c:\tb\1-central\src\mail\config\tooltool-manifests
TEST-INFO | check-sync-dirs.py | differ from their originals in: c:\tb\1-central\src\mozilla\browser\config\tooltool-man
ifests
TEST-INFO | check-sync-dirs.py | differing file:                 .\linux32\clang.manifest
TEST-INFO | check-sync-dirs.py | differing file:                 .\linux64\clang.manifest
In general, the files in 'c:\tb\1-central\src\mail\config\tooltool-
manifests' should always be exact copies of originals in
'c:\tb\1-central\src\mozilla\browser\config\tooltool-manifests'.  A change
made to one should also be made to the other.  See 'check-sync-dirs.py' for
more details.
c:\tb\1-central\tb-pydebug\mail\Makefile:16:0: command 'c:/tb/1-central/tb-pydebug/mozilla/_virtualenv/Scripts/python.ex
e c:/tb/1-central/src/mozilla/js/src/config/check-sync-dirs.py \
   c:/tb/1-central/src/mail/config/tooltool-manifests c:/tb/1-central/src/mozilla/browser/config/tooltool-manifests' fai
led, return code 1

Comment 1

[Kent James (:rkent)]

I have no idea what a clang manifest is all about, but there seems to be one in mail that is supposed to be equal to the one in the browser.

Comment 2

[Mark Banner (:standard8)]

I've pushed a bustage fix for the check-sync-dirs bustage:

https://hg.mozilla.org/comm-central/rev/a9ccae227c13

However, this shouldn't happen unless you're running make check, which I don't think pymake does automatically.

Could you try adding:

.PHONY: check-sync-dirs

to mail/Makefile.in and see if that lets you build even if there's failures in that command?

Comment 3

[Kent James (:rkent)]

(In reply to Mark Banner (:standard8) from comment #2)
> However, this shouldn't happen unless you're running make check, which I
> don't think pymake does automatically.
> 

All that it takes to trigger the error is to cd to the {OBJ_DIR}/mail and run "pymake" so I am not explicitly running make check

Comment 4

[Kent James (:rkent)]

I added .PHONY as requested and still get the error. (I have not applied the patch https://hg.mozilla.org/comm-central/rev/a9ccae227c13 yet)

This is an excerpt from mail/Makefile.in as modified:

ifdef ENABLE_TESTS

check-sync-dirs::
	@$(PYTHON) $(topsrcdir)/mozilla/js/src/config/check-sync-dirs.py \
	   $(srcdir)/config/tooltool-manifests $(MOZILLA_SRCDIR)/browser/config/tooltool-manifests

check:: check-sync-dirs

.PHONY: check-sync-dirs
endif

Comment 5

[Kent James (:rkent)]

With the bustage fix from comment 2 loaded, I am not getting this error anymore. Duping to bug 852745 since that is where the fix was done.