Closed
Bug 862996
Opened 10 years ago
Closed 10 years ago
Put text headings back in the tab menu
Categories
(Firefox for Android Graveyard :: Theme and Visual Design, defect)
Tracking
(firefox23 verified)
VERIFIED
FIXED
Firefox 23
Tracking | Status | |
---|---|---|
firefox23 | --- | verified |
People
(Reporter: ibarlow, Assigned: sriram)
References
Details
(Whiteboard: ui-hackathon)
Attachments
(1 file)
7.48 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
http://cl.ly/image/0d3q243A2Q3A We've been getting a lot of negative feedback that the icons are unclear on their own, and using text labels instead is just a nicer, more communicative design. The fact that someone pointed out that they looked like a moustache and a tophat didn't help, either. Let's put text back in the tabs everywhere except in the tablet sidebar, where we'll keep the icons due to space constraints. I realize there are potential localization concerns, but given the smaller text label size and fewer elements in the title bar than before, we have more room to work with now. For the text, please use Roboto Bold 12sp, white with 60% opacity
Comment 1•10 years ago
|
||
(In reply to Ian Barlow (:ibarlow) from comment #0) > The fact that someone pointed out that they looked like a moustache > and a tophat didn't help, either. http://www.am.ub.edu/~carrasco/bichos/porco2.jpg
Reporter | ||
Comment 2•10 years ago
|
||
I rest my case. :)
Comment 3•10 years ago
|
||
\o/
Assignee | ||
Comment 4•10 years ago
|
||
OMG! OMG! OMG!!! So, I made the ImageButton a Button. Since Button inherits from TextView, the "iconified" one is just a compound-drawable. If it displays the text, it displays it happily! :O :O We are becoming super efficient in using very less layouts! :O
Attachment #738780 -
Flags: review?(mark.finkle)
Updated•10 years ago
|
Attachment #738780 -
Flags: review?(mark.finkle) → review+
Updated•10 years ago
|
Whiteboard: ui-hackathon
Updated•10 years ago
|
Status: NEW → ASSIGNED
Reporter | ||
Comment 6•10 years ago
|
||
Do it do it
Updated•10 years ago
|
Version: unspecified → Trunk
Comment 8•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/14be1f919f01
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 23
Updated•10 years ago
|
Status: RESOLVED → VERIFIED
status-firefox23:
--- → verified
Updated•10 years ago
|
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•