Put text headings back in the tab menu

VERIFIED FIXED in Firefox 23

Status

()

VERIFIED FIXED
6 years ago
3 years ago

People

(Reporter: ibarlow, Assigned: sriram)

Tracking

Trunk
Firefox 23
ARM
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox23 verified)

Details

(Whiteboard: ui-hackathon)

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
http://cl.ly/image/0d3q243A2Q3A

We've been getting a lot of negative feedback that the icons are unclear on their own, and using text labels instead is just a nicer, more communicative design. The fact that someone pointed out that they looked like a moustache and a tophat didn't help, either.


Let's put text back in the tabs everywhere except in the tablet sidebar, where we'll keep the icons due to space constraints.

I realize there are potential localization concerns, but given the smaller text label size and fewer elements in the title bar than before, we have more room to work with now. 


For the text, please use Roboto Bold 12sp, white with 60% opacity
(Reporter)

Updated

6 years ago
Blocks: 817675
(In reply to Ian Barlow (:ibarlow) from comment #0)
> The fact that someone pointed out that they looked like a moustache
> and a tophat didn't help, either.

http://www.am.ub.edu/~carrasco/bichos/porco2.jpg
(Reporter)

Comment 2

6 years ago
I rest my case. :)
(Assignee)

Comment 4

6 years ago
Created attachment 738780 [details] [diff] [review]
Patch

OMG! OMG! OMG!!!
So, I made the ImageButton a Button. Since Button inherits from TextView, the "iconified" one is just a compound-drawable. If it displays the text, it displays it happily! :O :O
We are becoming super efficient in using very less layouts! :O
Attachment #738780 - Flags: review?(mark.finkle)
Attachment #738780 - Flags: review?(mark.finkle) → review+
Whiteboard: ui-hackathon
Land it?
OS: Mac OS X → Android
Hardware: x86 → ARM
Status: NEW → ASSIGNED
(Reporter)

Comment 6

6 years ago
Do it do it
Version: unspecified → Trunk
https://hg.mozilla.org/mozilla-central/rev/14be1f919f01
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 23
Status: RESOLVED → VERIFIED
status-firefox23: --- → verified
Depends on: 874014
No longer depends on: 867566
You need to log in before you can comment on or make changes to this bug.