863165 - Wrong time format display for calendar new event view[spanish]

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Calendar, defect, P1)

Description

[Leo]

Attachment: The date format for spanish

Precondition: Please use spanish as the default language.
Test Action: 
  1. Go to new event creation view.
Symptom:
  The format for date is YYYY-MM-DD.
Expected:
  The format of date should be DD-MM-YYYY.

Comment 2

[Leo]

The time format displayed in system settings and calendar add-event view doesn't go together. In settings view, the time format tends to change w.r.t the applied locale. But, this is not the case with calendar.

The date format used in calendar is YYYY-MM-DD. The default date format for Spanish locale is DD-MM-YYYY. 

I would suggest the date format should be based on the applied locale.

Please let know your comments.

Comment 3

[Leo]

Attachment: screenshot for date format with a different locale

Comment 4

[Jason Smith [:jsmith]]

Makes sense to me.

Comment 5

[Wayne Chang [:wchang]]

Triage - block for inconsistent presentation and regional requirements.

Comment 6

[:gerard-majax]

I suspect it might come from the exportDate method in js/utils/input_parser.js of Calendar app.

Comment 7

[:gerard-majax]

In fact I also have the issue in french locale :)

Comment 8

[Jason Smith [:jsmith]]

This is also happening on 1.01.

Comment 9

[James Lal [:lightsofapollo]]

The input here is doing the right thing according to the spec [1]. To implement this correctly we should have an "overlay" which sits over the input which is localized to the users locale. 

http://www.w3.org/TR/html-markup/input.date.html [1]
http://tools.ietf.org/html/rfc3339#section-5

Comment 10

[Daniel Coloma:dcoloma]

I think is pretty bad, but not a blocker, I am moving this back to leo+

Comment 11

[Kevin Grandon :kgrandon]

(In reply to James Lal [:lightsofapollo] from comment #9)
> The input here is doing the right thing according to the spec [1]. To
> implement this correctly we should have an "overlay" which sits over the
> input which is localized to the users locale. 
> 
> http://www.w3.org/TR/html-markup/input.date.html [1]
> http://tools.ietf.org/html/rfc3339#section-5

I believe browser vendors are encouraged to display the date inside of an input type="date" according to the user's locale. Competing browsers do something like this, and we probably should as well.

That said, a simple gaia overlay as a workaround is probably going to be easier to implement :)

Comment 12

[:gerard-majax]

(In reply to Kevin Grandon :kgrandon from comment #11)
> (In reply to James Lal [:lightsofapollo] from comment #9)
> > The input here is doing the right thing according to the spec [1]. To
> > implement this correctly we should have an "overlay" which sits over the
> > input which is localized to the users locale. 
> > 
> > http://www.w3.org/TR/html-markup/input.date.html [1]
> > http://tools.ietf.org/html/rfc3339#section-5
> 
> I believe browser vendors are encouraged to display the date inside of an
> input type="date" according to the user's locale. Competing browsers do
> something like this, and we probably should as well.
> 
> That said, a simple gaia overlay as a workaround is probably going to be
> easier to implement :)

Yep, this is what I've figured out and starting working on.

Comment 13

[:gerard-majax]

(In reply to Alexandre LISSY :gerard-majax from comment #12)
> (In reply to Kevin Grandon :kgrandon from comment #11)
> > (In reply to James Lal [:lightsofapollo] from comment #9)
> > > The input here is doing the right thing according to the spec [1]. To
> > > implement this correctly we should have an "overlay" which sits over the
> > > input which is localized to the users locale. 
> > > 
> > > http://www.w3.org/TR/html-markup/input.date.html [1]
> > > http://tools.ietf.org/html/rfc3339#section-5
> > 
> > I believe browser vendors are encouraged to display the date inside of an
> > input type="date" according to the user's locale. Competing browsers do
> > something like this, and we probably should as well.
> > 
> > That said, a simple gaia overlay as a workaround is probably going to be
> > easier to implement :)
> 
> Yep, this is what I've figured out and starting working on.

I have the first bits in place, will need a bit of polish, though, but I should have a patch to propose soon.

Comment 14

[:gerard-majax]

Attachment: Formatting date according to locale: in spanish

A second screenshot showing the date formatted using spanish locale.

Comment 15

[:gerard-majax]

Attachment: Formatting date according to locale: in english

Please find attached a screenshot showing the formatting according to locale (dateTimeFormat_%x)

Comment 16

[:gerard-majax]

Attachment: Link to Github https://github.com/mozilla-b2g/gaia/pull/9750

Please find the pull request for v1-train.

Comment 17

[:gerard-majax]

Attachment: Link to Github https://github.com/mozilla-b2g/gaia/pull/9751

Please find the link for the pull request for master branch

Comment 18

[:gerard-majax]

Comment on attachment 749187 [details]
Link to Github https://github.com/mozilla-b2g/gaia/pull/9750

Removing this pull request because only one against master is needed.

Comment 19

[:gerard-majax]

Please note that the tests might fail due to bug 872424

Comment 20

[Kevin Grandon :kgrandon]

Comment on attachment 749189 [details]
Link to Github https://github.com/mozilla-b2g/gaia/pull/9751

I'll leave felash on review? in case there was something specific you wanted him to look at, otherwise this has landed on master.

Comment 21

[Kevin Grandon :kgrandon]

Landed in master: https://github.com/mozilla-b2g/gaia/commit/bbd6e46084370f3aee54231695880bb702299710

Comment 22

[Leo]

Requesting for v1-train uplift

Comment 23

[Jason Smith [:jsmith]]

(In reply to Leo from comment #22)
> Requesting for v1-train uplift

You've already got leo+ here. No need to nominate for uplift - someone will come by to uplift this.

Comment 24

[Julien Wajsberg [:julienw]]

Comment on attachment 749189 [details]
Link to Github https://github.com/mozilla-b2g/gaia/pull/9751

my r= was for the test part, that looks good to me.

Comment 25

[Julien Wajsberg [:julienw]]

(not tef -> wontfix 1.0.1)

Comment 27

[James Lal [:lightsofapollo]]

in master: https://github.com/mozilla-b2g/gaia/commit/bbd6e46084370f3aee54231695880bb702299710

Comment 28

[Gareth Aye [:gaye] (back from PTO)]

Uplifted bbd6e46084370f3aee54231695880bb702299710 to:
v1-train: 8de87b27aea21f81bd7f4bdbdc66aebae53d0a83

Comment 29

[Jason Smith [:jsmith]]

Verified on b2g18 on a 5/20 build with some sanity testing with the Spanish locale.

Comment 30

[:CSchmoeckel]

Added Calendar Suite Test Case #8757 [Calendar] Verify the correct time format is displayed while creating Calendar events in the Spanish language