863288 - java.lang.OutOfMemoryError: at android.graphics.BitmapFactory.nativeDecodeByteArray(Native Method) at org.mozilla.gecko.AboutHomeContent/TopSitesView.getThumbnailsFromCursor(TopSitesView.java)

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Scoobidiver (away)]

It's similar to bug 827248.

Here is a crash report: bp-52483582-7f66-4990-bc73-8433d2130414.

java.lang.OutOfMemoryError
	at android.graphics.BitmapFactory.nativeDecodeByteArray(Native Method)
	at android.graphics.BitmapFactory.decodeByteArray(BitmapFactory.java:430)
	at android.graphics.BitmapFactory.decodeByteArray(BitmapFactory.java:447)
	at org.mozilla.gecko.widget.TopSitesView.getThumbnailsFromCursor(TopSitesView.java:302)
	at org.mozilla.gecko.widget.TopSitesView$5.doInBackground(TopSitesView.java:324)
	at org.mozilla.gecko.widget.TopSitesView$5.doInBackground(TopSitesView.java:321)
	at org.mozilla.gecko.util.UiAsyncTask$BackgroundTaskRunnable.run(UiAsyncTask.java:48)
	at android.os.Handler.handleCallback(Handler.java:605)
	at android.os.Handler.dispatchMessage(Handler.java:92)
	at android.os.Looper.loop(Looper.java:137)
	at org.mozilla.gecko.util.GeckoBackgroundThread.run(GeckoBackgroundThread.java:32)

More reports at:
https://crash-stats.mozilla.com/query/query?product=FennecAndroid&query_search=signature&query_type=contains&query=android.graphics.BitmapFactory.nativeDecodeByteArray%28Native+Method%29+&&do_query=1

Comment 1

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

https://crash-stats.mozilla.com/report/list?signature=java.lang.OutOfMemoryError%3A%20at%20android.graphics.BitmapFactory.nativeDecodeByteArray%28Native%20Method%29

java.lang.OutOfMemoryError: at android.graphics.BitmapFactory.nativeDecodeByteArray(Native Method) 	6
Amazon KFTT 	4
Samsung SPH-L710 	1
Amazon KFJWA 	1


https://crash-stats.mozilla.com/report/list?signature=java.lang.OutOfMemoryError%3A%20bitmap%20size%20exceeds%20VM%20budget%20at%20android.graphics.BitmapFactory.nativeDecodeByteArray%28Native%20Method%29
Motorola DROIDX 	2
MID MT791 	1

Comment 2

[Chris Peterson [:cpeterson]]

Attachment: robustify-bitmap-decoding.patch

Add sanity checks and error logging for bitmap decoding. This patch won't "fix" the OutOfMemoryErrors, but it should avoid some random crashes.

Do we need to support bitmaps with width or height of 0 pixels?

Comment 3

[:Margaret Leibovic]

(Sriram is on PTO for the next 2 weeks, so you may want to find another reviewer.)

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Chris Peterson (:cpeterson) from comment #2)

> Do we need to support bitmaps with width or height of 0 pixels?

Not that I am aware.

Comment 5

[Chris Peterson [:cpeterson]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e64522db8661

Comment 6

[Phil Ringnalda (:philor)]

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/96c0eae610a2 - six of the seven Android 4.0 robocop-1 runs that have finished so far have hung starting up testAwesomebar.

Comment 7

[Chris Peterson [:cpeterson]]

(In reply to Phil Ringnalda (:philor) from comment #6)
> Backed out in
> https://hg.mozilla.org/integration/mozilla-inbound/rev/96c0eae610a2 - six of
> the seven Android 4.0 robocop-1 runs that have finished so far have hung
> starting up testAwesomebar.

Looks like the Android 4.0 rc1 tests are still hanging after the backout:
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=96c0eae610a2

Comment 8

[Phil Ringnalda (:philor)]

Fun, huh? By this morning, it's more like a 50% hang in the middle of testBookmarksTab, before it even gets to that testAwesomebar startup hang.

Comment 9

[Phil Ringnalda (:philor)]

Free to reland, I hid robocop-1 on pandas on mozilla-inbound and mozilla-central, bug 865557.

Comment 10

[Chris Peterson [:cpeterson]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cf9d73c44cbf

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/cf9d73c44cbf

Comment 12

[Chris Peterson [:cpeterson]]

Comment on attachment 740589 [details] [diff] [review]
robustify-bitmap-decoding.patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): N/A
User impact if declined: Some infrequent OOM crashes
Testing completed (on m-c, etc.): m-c
Risk to taking this patch (and alternatives if risky): Low risk. This patch tries to avoid crashing on a Java OutOfMemoryError when creating large bitmaps, but we might just be pushing the OOM exception to a later memory allocation.
String or IDL/UUID changes made by this patch: N/A

Comment 13

[Chris Peterson [:cpeterson]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/2da51521a18d