878424 - java.lang.IllegalArgumentException: bytes.length 0 must be a positive number at org.mozilla.gecko.gfx.BitmapUtils.decodeByteArray(BitmapUtils.java) at org.mozilla.gecko.AwesomeBarTab.updateFavicon(AwesomeBarTab.java)

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Scoobidiver (away)]

This bug tracks crashes not fixed by bug 867058.
It's currently #20 crasher in 22.0b3.

java.lang.IllegalArgumentException: bytes.length 0 must be a positive number
	at org.mozilla.gecko.gfx.BitmapUtils.decodeByteArray(BitmapUtils.java:33)
	at org.mozilla.gecko.gfx.BitmapUtils.decodeByteArray(BitmapUtils.java:28)
	at org.mozilla.gecko.AwesomeBarTab.updateFavicon(AwesomeBarTab.java:94)
	at org.mozilla.gecko.BookmarksTab$BookmarksListAdapter.getView(BookmarksTab.java:345)
	at android.widget.AbsListView.obtainView(AbsListView.java:2033)
	at android.widget.ListView.makeAndAddView(ListView.java:1779)
	at android.widget.ListView.fillDown(ListView.java:676)
	at android.widget.ListView.fillFromTop(ListView.java:736)
	at android.widget.ListView.layoutChildren(ListView.java:1632)
	at android.widget.AbsListView.onLayout(AbsListView.java:1863)
	at android.view.View.layout(View.java:11283)
	at android.view.ViewGroup.layout(ViewGroup.java:4230)
	at android.support.v4.view.ViewPager.onLayout(ViewPager.java:1388)
	at android.view.View.layout(View.java:11283)
	at android.view.ViewGroup.layout(ViewGroup.java:4230)
	at android.widget.LinearLayout.setChildFrame(LinearLayout.java:1628)
	at android.widget.LinearLayout.layoutVertical(LinearLayout.java:1486)
	at android.widget.LinearLayout.onLayout(LinearLayout.java:1399)
	at android.view.View.layout(View.java:11283)
	at android.view.ViewGroup.layout(ViewGroup.java:4230)
	at android.widget.FrameLayout.onLayout(FrameLayout.java:431)
	at android.view.View.layout(View.java:11283)
	at android.view.ViewGroup.layout(ViewGroup.java:4230)
	at android.widget.LinearLayout.setChildFrame(LinearLayout.java:1628)
	at android.widget.LinearLayout.layoutVertical(LinearLayout.java:1486)
	at android.widget.LinearLayout.onLayout(LinearLayout.java:1399)
	at android.view.View.layout(View.java:11283)
	at android.view.ViewGroup.layout(ViewGroup.java:4230)
	at android.widget.FrameLayout.onLayout(FrameLayout.java:431)
	at android.view.View.layout(View.java:11283)
	at android.view.ViewGroup.layout(ViewGroup.java:4230)
	at android.widget.LinearLayout.setChildFrame(LinearLayout.java:1628)
	at android.widget.LinearLayout.layoutVertical(LinearLayout.java:1486)
	at android.widget.LinearLayout.onLayout(LinearLayout.java:1399)
	at android.view.View.layout(View.java:11283)
	at android.view.ViewGroup.layout(ViewGroup.java:4230)
	at android.widget.FrameLayout.onLayout(FrameLayout.java:431)
	at android.view.View.layout(View.java:11283)
	at android.view.ViewGroup.layout(ViewGroup.java:4230)
	at android.view.ViewRootImpl.performTraversals(ViewRootImpl.java:1521)
	at android.view.ViewRootImpl.handleMessage(ViewRootImpl.java:2474)
	at android.os.Handler.dispatchMessage(Handler.java:99)
	at android.os.Looper.loop(Looper.java:137)
	at android.app.ActivityThread.main(ActivityThread.java:4447)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at java.lang.reflect.Method.invoke(Method.java:511)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:784)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:551)
	at dalvik.system.NativeStart.main(Native Method)

More reports at:
https://crash-stats.mozilla.com/report/list?signature=java.lang.IllegalArgumentException%3A+bytes.length+0+must+be+a+positive+number+at+org.mozilla.gecko.gfx.BitmapUtils.decodeByteArray%28BitmapUtils.java%29

Comment 1

[Brian Nicholson (:bnicholson)]

Attachment: Add last remaining bytes.length check for decodeByteArray()

There's another usage on beta that we don't have a check for.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 863288
User impact if declined: crashes in awesome screen
Testing completed (on m-c, etc.): none
Risk to taking this patch (and alternatives if risky): very low risk
String or IDL/UUID changes made by this patch:

Comment 2

[Alex Keybl [:akeybl]]

Comment on attachment 757018 [details] [diff] [review]
Add last remaining bytes.length check for decodeByteArray()

Very low risk fix for a new crash regression (although not a topcrash). Worth taking given that.

Comment 3

[Brian Nicholson (:bnicholson)]

https://hg.mozilla.org/releases/mozilla-beta/rev/3073a3829090

Comment 4

[Aaron Train [:aaronmt]]

Closing?