863297 - [l10n] PIN related labels are not correctly localized

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Juan Perez-Bedmar [:juanpbf]]

Attachment: [1]NewPinMenu.png

Ikura, 
gaia commit:
cc0e498 Merge pull request #8186 from jaoo/836257
gecko commit:
2ab9876 Bug 854302 - [Buri][WIFI]Cann't disconnect WIFI when connect AP use WPS. r=mrbkap, a=tef+


Some labels related to the PIN security are not properly translated. When language is set to Spanish, there still are some labels shown in English:
1- In settings-->SIM security-->Change PIN. The last label is in English [1]
2- Try to wrongly change the PIN code by code: Open dialer and dial **04*OLD*NEW*NEW# (where OLD is an incorrectly entered old PIN1 and NEW is the new PIN1) [2]
3- Try to correctly change the PIN code by code: Open dialer and dial **04*OLD*NEW*NEW# (where OLD is the old PIN1 and NEW is the new PIN1) [3]

Nominating to tef? just to discuss if solving is not risky

Comment 1

[Juan Perez-Bedmar [:juanpbf]]

Attachment: [2] PIN change wrong.png

Comment 2

[Juan Perez-Bedmar [:juanpbf]]

Attachment: [3]PIN_change.png

Comment 3

[Alex Keybl [:akeybl]]

Stas - is the English string in NewPinMenu localized on your end?

We're not sure where the second string is coming from.

Comment 4

[Andrew Overholt [:overholt]]

Evelyn/Etienne, do you know where this text is coming from?  I remember grepping through my gaia tree the other day and not seeing these strings.

Comment 5

[Etienne Segonzac (:etienne)]

Looks like the #simpin-dialog from the system app (which recently got l10n changes).

Comment 6

[Andrew Overholt [:overholt]]

(In reply to Juan Perez-Bedmar [:juanpbf] from comment #0)
> 1- In settings-->SIM security-->Change PIN. The last label is in English [1]

I think this was fixed by bug 854031.

> 2- Try to wrongly change the PIN code by code: Open dialer and dial
> **04*OLD*NEW*NEW# (where OLD is an incorrectly entered old PIN1 and NEW is
> the new PIN1) [2]
> 
> 3- Try to correctly change the PIN code by code: Open dialer and dial
> **04*OLD*NEW*NEW# (where OLD is the old PIN1 and NEW is the new PIN1) [3]

Can you re-test with a newer 1.0.1 build, Juan?  Then we can see what needs to be fixed l10n-wise.  Thanks.

Comment 7

[Juan Perez-Bedmar [:juanpbf]]

(In reply to Andrew Overholt [:overholt] from comment #6)
> > 1- In settings-->SIM security-->Change PIN. The last label is in English [1]
> 
> I think this was fixed by bug 854031.
Yes indeed. I have checked it with a newer version and this is solved

> > 2- Try to wrongly change the PIN code by code: Open dialer and dial
> > **04*OLD*NEW*NEW# (where OLD is an incorrectly entered old PIN1 and NEW is
> > the new PIN1) [2]
> > 
> > 3- Try to correctly change the PIN code by code: Open dialer and dial
> > **04*OLD*NEW*NEW# (where OLD is the old PIN1 and NEW is the new PIN1) [3]
> 
> Can you re-test with a newer 1.0.1 build, Juan?  Then we can see what needs
> to be fixed l10n-wise.  Thanks.
I'm afraid this is still failing. Behaviour is exactly the same

Comment 8

[Andrew Overholt [:overholt]]

Staś, are you the best assignee here and do you have everything you need to work on this?

Comment 9

[Axel Hecht [:Pike]]

Regarding 1.0.1: It seems that that string isn't going through l10n hooks, despite being localized.

apps/settings/locales/settings.en-US.properties:confirmNewSimPinMsg=Confirm new PIN

while in settings/index.html, it is

          <div data-l10n-id="confirmNewSimPinMsg">
            Confirm New PIN
          </div>

Given that the string in the screen shot has the upper-case New, there's something in the code that doesn't pick up the localized strings.

Note, gaia-l10n 1.0.1 repo has for 'es':

confirmNewSimPinMsg=Confirmar el nuevo número PIN


PS: assigning bugs for needinfo is probably not the smartest thing to see if bugs are owned or not.

Comment 10

[Andrew Overholt [:overholt]]

(In reply to Axel Hecht [:Pike] from comment #9)
> PS: assigning bugs for needinfo is probably not the smartest thing to see if
> bugs are owned or not.

I didn't want to just assign it since I honestly don't know if Staś is the best person here :)

Comment 11

[Axel Hecht [:Pike]]

Neither stas nor I are good owners for this bug, independent if it was a code or an l10n bug. We can help distinguishing the two, and dispatch to a localizer if needed, though.

Comment 12

[Fernando Campo (:fcampo)]

I'm gonna take it and give it a look, as per comment it's highly probable a regression from bug 860660

Comment 13

[Andrew Overholt [:overholt]]

Fernando, with bug 860660 almost finished, do you still think this was a regression from that?

Comment 14

[Fernando Campo (:fcampo)]

(In reply to Andrew Overholt [:overholt] from comment #13)
> Fernando, with bug 860660 almost finished, do you still think this was a
> regression from that?

After my tests on v1.0.1 and different languages (where I was unable to get the same strings that Juan but similar, I need to get exactly the same build), I see that is not a regression from bug 860660 (I also tried with master, where it already landed), but a lack of treatment of the messages that server returns after sending mmi codes.

I'm working on a patch, but it will need late-l10n

Comment 15

[Fernando Campo (:fcampo)]

Sorry guys for the delay, apparently this one fell off my list during tha last days.

So, I've been testing and I've been getting different messages than the ones posted originally. Actually I was unable to find those strings shown on the screen captures, so I have no idea where are coming from. And as the messages were different depending on the SIM card used, I'm starting to think that they are coming directly from the service provider. Anybody have any other hint about this?

2- Try to wrongly change the PIN code by code: Open dialer and dial **04*OLD*NEW*NEW# (where OLD is an incorrectly entered old PIN1 and NEW is the new PIN1) [2]
Here I get:
- 'The PIN was incorrect' message when trying with master
- IncorrectPassword message when trying with v1.0.1

3- Try to correctly change the PIN code by code: Open dialer and dial **04*OLD*NEW*NEW# (where OLD is the old PIN1 and NEW is the new PIN1) [3]
I get 'Message successfully sent' in all branches

And when I try to change the PIN with **04*OLD*NEW1*NEW2# with NEW1 != NEW2, I get a 'NEW_PIN_MISMATCH' message in all branches too.

So basically my patch would be adding some more error codes to the error handling function (https://github.com/mozilla-b2g/gaia/blob/master/apps/communications/dialer/js/mmi_ui.js#L184).

PS - Do we have a list of the different errors/messages returned when using mmi codes?

Comment 16

[Fernando Campo (:fcampo)]

Attachment: Link to PR https://github.com/mozilla-b2g/gaia/pull/9764

Comment 17

[Etienne Segonzac (:etienne)]

Comment on attachment 749344 [details]
Link to PR https://github.com/mozilla-b2g/gaia/pull/9764

r=me the code looks good.

But we should ask the reporter to verify this bug.

Comment 18

[Fernando Campo (:fcampo)]

(In reply to Etienne Segonzac (:etienne) from comment #17)
> 
> But we should ask the reporter to verify this bug.

Yeah, I agree with that, the patch was just to show the approach I was taking, as I can't actually fix the bug (I'm unable to get the same results as the reporter)

Comment 19

[Maria Angeles Oteo (:oteo)]

Certification people has told us that the current patch is enough to remove the blocking issue.
Fernando, please, merge

Comment 20

[Fernando Campo (:fcampo)]

Merged https://github.com/mozilla-b2g/gaia/commit/d510063ad9ea78cfa47fb27c85246b1c0cf85c44

As problem described in:
1 - was solved by bug 854031
2 - was solved by bug 860660

3 was solved by this merged PR, I'm marking bug as resolved while waiting for an answer from reporter about the original labels that I'm still unable to get.

Comment 21

[John Ford [:jhford] CET/CEST Berlin Time]

[v1-train a695cec] Merge pull request #9764 from fcampo/ussd-l10n
[v1.0.1 7dc2fd3] Merge pull request #9764 from fcampo/ussd-l10n