854031 - [B2G][l10n][Spanish] The Confirm New PIN text on the Enter PUK Code page is shown in English

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Chris Kreinbring [:CKreinbring]]

Attachment: Screenshot of English text on Spanish language PUK page

Description:
A user with their device set to display Spanish will have the "Confirm New PIN" text in the Enter PUK Code page displayed in English.

Repro Steps:
1) Updated to Unagi Build ID: 20130322070203
2) Select Settings, then Language, then change the language to Spanish.
3) Return to the Settings and select SIM Security.
4) Tap the SIM PIN switch and enter an incorrect code three times.
5) When the Enter PUK Code page appears, observe the text above the bottom text box.

Expected:
The text reads "Confirmar PIN nuevo"

Actual:
The text reads "Confirm New PIN"

Repro frequency:
100%

Environmental  Variables:
Kernel Date: Dec 5
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/4931ec89ebbe
Gaia: 85fd164691bb852f1cfaf82405df4380629ced6e

Notes:
Added screenshot of English text on Spanish language PUK page
Q Analysts Test Team Priority Rating: Pri 3

Comment 1

[Delphine Lebédel [:delphine - Use needinfo]]

Reproducible on Unagi pvt nightly v1.01 build

Gecko: 353867e8450799957646541e04470da57701ba66
Gaia: 5c3583a7a58f0c47da0e48b90273fa36cc508b0b
BuildID 20130326070208
Version 18.0

Comment 2

[Axel Hecht [:Pike]]

shira?->tef?

Comment 3

[Daniel Coloma:dcoloma]

Blocking as this a critical screen, user should clearly understand what is going on

Comment 4

[Axel Hecht [:Pike]]

Adding late-l10n keyword until we know exactly what's the problem.

Comment 5

[Andrew Overholt [:overholt]]

(In reply to Axel Hecht (pto - April 2) [:Pike] from comment #4)
> Adding late-l10n keyword until we know exactly what's the problem.

I thought the problem was just that "Confirm New PIN" isn't localized?

Comment 6

[Andrew Overholt [:overholt]]

kaze, do you know what's up here?

Comment 7

[Axel Hecht [:Pike]]

Copied from bug 854023 comment 5, made that in the wrong bug in the rush.

OK, this looks like we have that string in a non-localizable fashion twice,

https://github.com/mozilla-b2g/gaia/blob/v1.0.1/apps/system/index.html#L456
and
https://github.com/mozilla-b2g/gaia/blob/v1.0.1/apps/settings/index.html#L1593

Seems like it's https://github.com/mozilla-b2g/gaia/commit/c2e8e614c165ad26c02abfc7f4ef63ae1e106c2f for settings, and https://github.com/mozilla-b2g/gaia/commit/3e87646f87dc80f2df4a009f6ce855f9b07ef69f for system.

CCing evelyn and ochameau.

Daniel, I don't think we'll be able to get these strings localized, let alone tested this week.

Comment 8

[Fabien Cazenave [:kaze]]

Attachment: link to pull request

Comment 9

[Fabien Cazenave [:kaze]]

https://github.com/mozilla-b2g/gaia/pull/8879

(In reply to Axel Hecht (pto - April 2) [:Pike] from comment #7)
> I don't think we'll be able to get these strings localized, let
> alone tested this week.

The “Confirm New PIN” string has already been localized but the corresponding l10n-id attribute was missing in Settings and System.

Comment 10

[Fabien Cazenave [:kaze]]

Comment on attachment 730944 [details]
link to pull request

Asking Evelyn /or/ Tim to review this.

Comment 11

[Staś Małolepszy :stas]

(In reply to Fabien Cazenave [:kaze] from comment #9)

> The “Confirm New PIN” string has already been localized but the
> corresponding l10n-id attribute was missing in Settings and System.

Cool, looks like we got lucky this time and we can fix this without any impact on the string freeze.

Comment 12

[Axel Hecht [:Pike]]

Oh, the reason I had not found the string in system.en-US.properties was that the string there is "Confirm new PIN", with a lower-case 'new'.

Is that good or bad? I was surprised by seeing the new being upper-cased, so I would think that's good, but want to make sure.

Once we have this patch on devices, we should call these steps out for testing. Perhaps together with bug 854023 ?

Comment 13

[Fabien Cazenave [:kaze]]

https://github.com/mozilla-b2g/gaia/commit/452eaff2d2f25eda3addee8833df2aaaf7cbcdd3

Comment 14

[Fabien Cazenave [:kaze]]

(In reply to Axel Hecht (pto - April 2) [:Pike] from comment #12)
> Oh, the reason I had not found the string in system.en-US.properties was
> that the string there is "Confirm new PIN", with a lower-case 'new'.
> 
> Is that good or bad? I was surprised by seeing the new being upper-cased, so
> I would think that's good, but want to make sure.

I think it’s supposed to be in lower-case, see bug 798066 where we should apply “sentence case capitalization”.

> Once we have this patch on devices, we should call these steps out for
> testing. Perhaps together with bug 854023 ?

Right, these two bugs are affecting the same panel.

Comment 15

[John Ford [:jhford] CET/CEST Berlin Time]

I was not able to uplift this bug to v1-train and v1.0.1.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1-train and v1.0.1, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1-train
  git cherry-pick -x -m1 452eaff2d2f25eda3addee8833df2aaaf7cbcdd3
  <RESOLVE MERGE CONFLICTS>
  git commit
  git checkout v1.0.1
  git cherry-pick -x $(git log -n1 v1-train)

Comment 19

[Beatriz Rodríguez [:brg]]

We need this patch in v1.0.1
This is a certification blocker.
Adding dependencies.

Comment 20

[Fabien Cazenave [:kaze]]

Before uplifting this bug we need to uplift bug 828890 (approved), which depends on bug 858722 (not yet approved).

Comment 21

[Daniel Coloma:dcoloma]

(In reply to Fabien Cazenave [:kaze] from comment #20)
> Before uplifting this bug we need to uplift bug 828890 (approved), which
> depends on bug 858722 (not yet approved).

It seems like a big patch-chain for v1.0.1. Any chance we could have a branch-specific patch for this bug?

Comment 22

[Alex Keybl [:akeybl]]

I know that this is resolved on master, but since only open tef+ bugs are getting P1 attention, I'll reopen due to comment 21

Comment 23

[Fabien Cazenave [:kaze]]

v1-train: https://github.com/mozilla-b2g/gaia/commit/502653c27d86acbb82e170ccf4d226999458ca84

v1.0.1: https://github.com/mozilla-b2g/gaia/commit/2543428e16a5f1a716bd3e8c646119acba12b524

Comment 24

[John Ford [:jhford] CET/CEST Berlin Time]

per comment 23, fixed on branches.

Comment 25

[Carlos Martínez Toral [:carlosmartinez]]

Verified fixed on inari device with:

Gaia   e6d694f86e6a704fce00509de7c65aa976ade9f6
BuildID 20130418004045
Version 18.0