Closed Bug 863318 Opened 12 years ago Closed 12 years ago

Add l10-fixes to the desktop-helper

Categories

(Firefox OS Graveyard :: Gaia, defect)

Product:
Firefox OS Graveyard
Component:
Gaia
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(b2g18+ fixed)

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
b2g18 + fixed

People

(Reporter: vingtetun, Assigned: vingtetun)

References

Details

Attachments

(1 file, 1 obsolete file)

Github pull request pointer
218 bytes, text/html
kgrandon
: review+
lsblakk
: approval-gaia-v1+
Details
Seems like l10n_date.js has some issues with the %p argument for locales when you are in a locale where you don't use 'AM'/'PM'. Also the locale selected in settings does not match without this patch (which will be soo convenient for localizers I believe). I fixed also l10n.js that is returning a ready event even if the files are not loaded yet. This happens a lot on desktop since this is soo much faster.
Attached file Patch (obsolete) —
I fixes some l10n race condition as well.
Attachment #739130 - Flags: review?(kgrandon)
Comment on attachment 739130 [details] Patch ><html> ><head> ><meta http-equiv="Refresh" content="2; url=https://github.com/mozilla-b2g/gaia/pull/9344"> ></head> ><body> >Redirect to pull request 9344 ></body> ></html>
Attachment #739130 - Flags: review?(kgrandon) → review+
Attachment #739130 - Attachment is obsolete: true
Attachment #740369 - Flags: review+
Landed with one minor fix for unit tests: https://github.com/mozilla-b2g/gaia/commit/944526b951dcd3eec68bdcdf59c072142eea31ee
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
(In reply to Kevin Grandon :kgrandon from comment #4) > Landed with one minor fix for unit tests: > https://github.com/mozilla-b2g/gaia/commit/ > 944526b951dcd3eec68bdcdf59c072142eea31ee Thanks!
We are facing this bug in the simulator and end up with very wrong dates: https://github.com/mozilla/r2d2b2g/issues/502 As we are using v1-train branch, I was wondering if we can safely ask for this patch to be uplifted??
Flags: needinfo?(kgrandon)
Comment on attachment 740369 [details] Github pull request pointer We would like to uplift this to provide fixes developer experience fixes for the FFOS simulator. User impact if declined: Third party developers will have a poor experience when using the simulator. Testing completed: Manual testing and has been baking on master for serveral weeks now. Risk to taking this patch: I don't believe there should be any risks here as it's been on master for a while. Tested with various dates and localizations.
Attachment #740369 - Flags: approval-gaia-v1?
Flags: needinfo?(kgrandon)
Attachment #740369 - Flags: approval-gaia-v1? → approval-gaia-v1+
Oh I've been tricked by the mass uplift done in bug 865461. This bug has already been uplifted there. v1-train: 7c409abac27b85989e20a8b39599f51096087a2c
status-b2g18: affected → fixed
Depends on: 868654
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: