863339 - remove unneeded code that supports setting window.status

Status: NEW

(Core :: DOM: Core & HTML, defect, P5)

Description

[:Gavin Sharp [email: [e-mail]]]

See discussion in bug 862917 and bug 862540.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Attachment: potential patch

This takes a more drastic approach, killing nsIWebBrowserChrome2 and adding a new more specialized method (setOverLink) to nsIWebBrowserChrome to replace nsIWebBrowserChrome2::SetStatusWithContext(STATUS_LINK) callers. It gets rid of all non STATUS_LINK callers of SetStatusWithContext.

Are we OK with doing that, or do we actually need to avoid changing nsIWebBrowserChrome[2] for compatibility purposes?

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 739304 [details] [diff] [review]
potential patch

That all looks fine to me as long as the plugins change is, and as long as the basic premise that no Gecko app cares is true.

Comment 3

[Benjamin Smedberg]

We really totally disabled window.status? One of my game sites (atc-sim.com) relied on this, and I wondered why I couldn't see the status updates any more :-(

Certainly if we've stopped actually supporting window.status, then the effect this has on plugins really doesn't matter. It just makes me sad :-(

Comment 4

[Boris Zbarsky [:bzbarsky]]

The Firefox UI disabled it a while back, yeah...

Comment 5

[[e-mail]]

(In reply to Boris Zbarsky from comment #2)
> That all looks fine to me as long as the plugins change is, and as long as
> the basic premise that no Gecko app cares is true.

While it's in the spec, I think we should be allowed to implement it.

Comment 6

[:Gavin Sharp [email: [e-mail]]]

(In reply to [e-mail] from comment #5)
> While it's in the spec, I think we should be allowed to implement it.

The part that's in the spec explicitly says "do nothing on setting":
http://www.whatwg.org/specs/web-apps/current-work/multipage/browsers.html#dom-window-status

The only browser on Mac that I could find that supports it is Safari (I also tested Chrome, Firefox, Opera).

Comment 7

[[e-mail]]

(In reply to Gavin Sharp from comment #6)
> (In reply to comment #5)
> > While it's in the spec, I think we should be allowed to implement it.
> 
> The part that's in the spec explicitly says "do nothing on setting":

Well, we already had to break that for bug 862540...

Comment 8

[[e-mail]]

Anyway, where was I before I accidentally managed to submit my comment to Bugzilla? Oh yes, my apologies, I hadn't realised that window.status was proprietary to Netscape.

Comment 9

[Boris Zbarsky [:bzbarsky]]

> The part that's in the spec explicitly says "do nothing on setting":

That part of the spec is bunk.  I filed https://www.w3.org/Bugs/Public/show_bug.cgi?id=21823

Comment 10

[:Gavin Sharp [email: [e-mail]]]

Well, yes, OK. But in any case the spec doesn't dictate any UI, and this code exists to let apps show UI. So I'd like to kill it, but it's not clear to me now whether SeaMonkey actually opposes that plan or not.

Comment 11

[Anne (:annevk)]

We could kill the preference dom.disable_window_status_change=false. We cannot kill window.status itself.