862917 - Remove window.defaultStatus

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[:Gavin Sharp [email: [e-mail]]]

Setting them has had no effect in Firefox since the aviary days (dom.disable_window_status_change has been true). Recently, the Firefox UI dropped support for enabling that pref (bug 842017).

These attributes aren't specified in HTML5, so we should just completely remove support for the feature from the DOM (and simplify the relevant nsIWebBrowserChrome2/nsIXULBrowserWindow APIs and client implementations).

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

I'd rather just make these no-ops. window.status has been mentioned in many docs, so removing would
probably lead to some obscure problem in some page.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

What kind of compat problems do you foresee? Since it's just a simple property I'm not really sure what kind of issues removing it could cause. Unqualified references to "status"?

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Oh, I was wrong about window.status not being specced:
http://www.whatwg.org/specs/web-apps/current-work/multipage/browsers.html#dom-window-status

That seems like a fine compromise.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: Remove the non-standard window.defaultStatus and the propagation of window.status values to the UI.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Attachment: Remove the non-standard window.defaultStatus.

Comment 6

[Boris Zbarsky [:bzbarsky]]

I didn't change the guts of .status because there are Gecko-based apps that in fact have UI for it...  The decision to drop it should probably have somewhat more public input than this bug.

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 738897 [details] [diff] [review]
Remove the non-standard window.defaultStatus.

Tiny bit scary. I guess we can try and put back dummy .defaultStatus if 
there are problems.

Comment 8

[:Gavin Sharp [email: [e-mail]]]

(In reply to Boris Zbarsky (:bz) from comment #6)
> I didn't change the guts of .status because there are Gecko-based apps that
> in fact have UI for it...  The decision to drop it should probably have
> somewhat more public input than this bug.

What apps? We can CC a SeaMonkey representative to a bug, I don't see this needing much more input than that given the state of the feature.

Comment 9

[:Gavin Sharp [email: [e-mail]]]

Now I filed bug 863339 :) I'll propose a patch on top of these ones.

Comment 10

[Boris Zbarsky [:bzbarsky]]

SeaMonkey was the obvious one, yes.

Comment 11

[Boris Zbarsky [:bzbarsky]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fc6404ba7c74

Comment 12

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/fc6404ba7c74

Comment 13

[Kohei Yoshino]

I've added this bug to the compatibility doc. Please correct the info if wrong.
https://developer.mozilla.org/en-US/docs/Site_Compatibility_for_Firefox_23

Comment 14

[Kohei Yoshino]

https://developer.mozilla.org/en-US/docs/Web/API/window
https://developer.mozilla.org/en-US/docs/Web/API/window.defaultStatus