863595 - [Buri][SOS]NO any prompts during a call, when dial a emergency call from emergency call keypad.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect, P1)

Description

[sync-1]

AU_LINUX_GECKO_ICS_STRAWBERRY_V1.01.00.01.019.077
 Firefox os  v1.0.1
 Mozilla build ID:20130414070204
 
 +++ This bug was initially created as a clone of Bug #443235 +++
 
 DEFECT DESCRIPTION:
 [SOS]NO any prompts during a call, when dial a emergency call from emergency call keypad.
 
  REPRODUCING PROCEDURES:
 1.enable Lock screen and password lock
 2.make a call(10010) -> during the call
 3.press power key to lock screen -> wake up the screen
 4.press Home key switch the call to background -> unlock the screen -> on the password keypad press "Emergency call" -> show the emergency call keypad
 5.dial 112
 6.no any prompts and can not dial out
 
  EXPECTED BEHAVIOUR:
 Pop up some prompts that the user is already in the call.
 
  ASSOCIATE SPECIFICATION:
 
  TEST PLAN REFERENCE:
 
  TOOLS AND PLATFORMS USED:
 
  USER IMPACT:
 
  REPRODUCING RATE:
 
  For FT PR, Please list reference mobile's behavior:
 
 ++++++++++ end of initial bug #443235 description ++++++++++
 
 
 
 CONTACT INFO (Name,Phone number):
 
  DEFECT DESCRIPTION:
 
  REPRODUCING PROCEDURES:
 
  EXPECTED BEHAVIOUR:
 
  ASSOCIATE SPECIFICATION:
 
  TEST PLAN REFERENCE:
 
  TOOLS AND PLATFORMS USED:
 
  USER IMPACT:
 
  REPRODUCING RATE:
 
  For FT PR, Please list reference mobile's behavior:

Comment 1

[sync-1]

Clone from brother

Comment 2

[sync-1]

Attachment: snapshot

Clone from brother

Comment 3

[Cheng-An, XIONG]

if multi dial out call is not support, please disable dialpad when it's already in call.

Comment 4

[Dietrich Ayala (:dietrich)]

Etienne, is this a dupe of a blocker from last week at workweek?

Comment 5

[Etienne Segonzac (:etienne)]

(In reply to Dietrich Ayala (:dietrich) from comment #4)
> Etienne, is this a dupe of a blocker from last week at workweek?

not a dupe, arguably a follow up

Comment 6

[Daniel Coloma:dcoloma]

Could we simply disable the "Emergency Call" if there is already an ongoing call?

Comment 7

[Milan Sreckovic [:milan] (needinfo for best results)]

Etienne, this will probably end up with you in the end anyway.

Comment 8

[Etienne Segonzac (:etienne)]

Attachment: WIP

I'm in favor of displaying an alert when we try to launch the call from the lockscreen.

Disabling the button would involve constantly observing the calls and could really be confusing to the users.

Here is a WIP, without the l10n part.

I'd like to either fix the bug with the needed l10n add, or leave the bug unfixed.

Comment 9

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 742469 [details] [diff] [review]
WIP

Review of attachment 742469 [details] [diff] [review]:
-----------------------------------------------------------------

As Etienne commented, I also prefer the idea of the message, it's the safest solution and the code needed is pretty straight forward.

The WIP looking good to me.

Cheers!

::: apps/system/emergency-call/js/dialer.js
@@ +18,5 @@
> +      var ok = this._alertOK;
> +      alert.hidden = false;
> +      ok.addEvenListener('click', function close() {
> +        ok.removeEventListener('click', close);
> +        alert.hidden = false;

when we click to close the 'alert' message, that 'alert' should be hidden isn't?

Comment 10

[Stephany Wilkes]

Flagged Francis as needinfo to address these UX aspects of comment 8 (and advise on them or propose a different approach, etc.):

"I'm in favor of displaying an alert when we try to launch the call from the lockscreen.

Disabling the button would involve constantly observing the calls and could really be confusing to the users."

Comment 11

[Francis Djabri [:djabber]]

If multi dial out is not supported, then I would argue that the correct behavior would be to allow the user to dial emergency services, but warn the user that by doing so, they will drop the existing call. 

The dialog should read (text to be confirmed): Calling '<number>' will end your current call. Continue? (Options: No/Yes)

Is this possible?

Comment 12

[Anshul]

Francis, if you dial a number when there is another call modem will put the existing call on hold and resume he held call when the emergency call is disconnected. So I don't think it is good to assume that the second call will be dropped.

I will test this behavior with commercial RIL and update tomorrow.

Comment 13

[Francis Djabri [:djabber]]

If the existing call can be put on hold, I agree this should be the expected behavior for this bug. 
If this is not supported, then I would argue that giving the user the option to drop the existing call would be a better outcome than preventing them from calling emergency services while a call is ongoing.

Comment 14

[Anshul]

Francis, I confirmed with commercial RIL that the existing call is put on hold and the emergency call is dialed. There was a little bug in commercial RIL that I fixed and not this scenario works with the exception of the following issues.

- If the dialed number is not an emergency number, RIL send an error messsage "RIL:CallError", "{callIndex:-1, error:'BadNumberError'}", which ends up disconnecting the existing call.
- When dialing the new emergency number, the numbers being pressed are sent as DTMF to the network, which is not correct either.

Please see the attached video of the sequence with commercial RIL.

Comment 15

[Anshul]

Attachment: Dial an emergency number when there is an existing call (working with commercial RIL)

Comment 16

[Etienne Segonzac (:etienne)]

Very interesting, let's see if the default behavior allows us to close this bug once  bug 866481 is fixed.

Comment 17

[Etienne Segonzac (:etienne)]

Can you test again with the patch on bug 866481?

This patch fixes the emergency calls from the lockscreen, and it looks like the RIL does the rest and everything works fine :)

Comment 18

[Anshul]

Etienne, the patch in bug 866481 doesn't seem to fix either of the issues mentioned in my comment #14. The UI glitch in the video turned out to be the RIL issue that I resolved.

Comment 19

[Mingming ZHAO]

(In reply to Etienne Segonzac (:etienne) from comment #17)
> Can you test again with the patch on bug 866481?
> 
> This patch fixes the emergency calls from the lockscreen, and it looks like
> the RIL does the rest and everything works fine :)

Dear Etienne,
I have tried your patch, it did not work.Please refer to the attachment.

Comment 20

[Mingming ZHAO]

Attachment: snapshot

Comment 21

[Mingming ZHAO]

How about solution this bug like android phone's behavior:
Change the "Emergency Call" button to "Return the call" button when
one call established on passcode lock screen.

Comment 22

[Joy]

This abnormal screen is also displayed when try to add 2nd call in contact during a call.
At the first time to swap the call(1st call: active -> hold, 2nd call : alerting -> active), it only updates 2nd call status in gecko layer.

Comment 23

[Etienne Segonzac (:etienne)]

We really need to fix the emergency call from the lockscreen before we take any decision here.

Comment 24

[Stephany Wilkes]

Just checking in on the UX here: Was Francis's UX recommendation taken into account, or is this bug about something else now (per comment 23)?

Comment 25

[Etienne Segonzac (:etienne)]

(In reply to Stephany Wilkes from comment #24)
> Just checking in on the UX here: Was Francis's UX recommendation taken into
> account, or is this bug about something else now (per comment 23)?

We're hoping that the RIL will do exactly what we want (ie. the best case scenario in Francis' comment) once the basic feature is fixed.

Comment 26

[Joe Cheng [:jcheng] (please needinfo)]

(In reply to Etienne Segonzac (:etienne) from comment #23)
> We really need to fix the emergency call from the lockscreen before we take
> any decision here.

Hi Etienne, seem like bug 866481 is resolved (with updated information that it's mistakenly reported as patch not working ealier). What do you suggest as next step? Thanks

Comment 27

[Anshul]

The support for adding a call when in emergency mode is available in commercial RIL in AU AU_LINUX_GECKO_ICS_STRAWBERRY_V1.01.00.01.019.096 or later.

I would prefer that we allow user to place the call through emergency dialer when there is a call and not show the return to call option as Android does but I am okay with either of the approaches.

Comment 28

[Etienne Segonzac (:etienne)]

(In reply to Joe Cheng [:jcheng] from comment #26)
> (In reply to Etienne Segonzac (:etienne) from comment #23)
> > We really need to fix the emergency call from the lockscreen before we take
> > any decision here.
> 
> Hi Etienne, seem like bug 866481 is resolved (with updated information that
> it's mistakenly reported as patch not working ealier). What do you suggest
> as next step? Thanks

Well, it's not landed yet.

I suggest pinging the reviewer to get it reviewed/landed soon so we can move forward on this one :)

Comment 29

[Etienne Segonzac (:etienne)]

So now that bug 870714 landed...if you follow the STR:

- the first call will be put on hold
- the emergency call will be dialed
- the call screen will appear

So, WORKSFORME?

Comment 30

[sarsenyev]

This bug reproduces on the Buri latest build
Emergency phone call is made, but no any information displays that 911 is dialed, just a phone number from the ongoing call

Environmental  Variables:
Buri Build ID: 20130513070209
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/6e1dbf036d34
Gaia: 54dfb62735c81152eef74eb1768e2bf621c0a258

Comment 31

[Mingming ZHAO]

Attachment: video

(In reply to Etienne Segonzac (:etienne) from comment #29)
> So now that bug 870714 landed...if you follow the STR:
> 
> - the first call will be put on hold
> - the emergency call will be dialed
> - the call screen will appear
> 
> So, WORKSFORME?

Etienne, sorry, I am not quite understand your mean. So I recorded a video, please refer to the attachments.Hope it can help you.

By the way our code is based on:
AU_LINUX_GECKO_ICS_STRAWEBRRY_V1.01.00.01.019.094
Firefox os  v1.0.1
Mozilla build ID:20130502070201

Comment 32

[Mingming ZHAO]

Attachment: video

Comment 33

[Mingming ZHAO]

Attachment: video

Comment 34

[Mingming ZHAO]

Attachment: video

Comment 35

[Mingming ZHAO]

Attachment: video

Comment 36

[Etienne Segonzac (:etienne)]

> - the first call will be put on hold
> - the emergency call will be dialed
> - the call screen will appear

The video shows exactly that. And I was under the impression that this was what we wanted to do in the best case scenario (See Comment 12, Comment 13).

I'm not sure what that the blocking issue is anymore.

Comment 37

[Johnny Stenback (:jst)]

Mingming ZHAO, can you please describe exactly what you're expecting to see fixed here, if anything? Thanks!

Comment 38

[Anshul]

Mingming, let me try to summarize what I think you are saying are the issues.

1. As per your comment #30 the emergency call label is not shown. This will be fixes when the support for bug 863281 is available in commercial RIL (ETA 2 days)
2. When the previous call is on hold and the emergency call was active, clicking on the calls wasn't switching the calls. I would need Android logs as per instructions below to debug the issue.
 adb logcat -b radio -b main -v time

Comment 39

[Mingming ZHAO]

Dears,
Through discussions, we can accept the present case that is
> - the first call will be put on hold
> - the emergency call will be dialed
> - the call screen will appear

But why can not switch the two calls?

Comment 40

[Mingming ZHAO]

(In reply to Anshul from comment #38)
> Mingming, let me try to summarize what I think you are saying are the issues.
> 
> 1. As per your comment #30 the emergency call label is not shown. This will
> be fixes when the support for bug 863281 is available in commercial RIL (ETA
> 2 days)

You mean that when dial emergency call (112), it will display "Emergency call" label under the number (112)? And whether the recent call log will also display the "Emergency call" label under the Emergency number?

> 2. When the previous call is on hold and the emergency call was active,
> clicking on the calls wasn't switching the calls. I would need Android logs
> as per instructions below to debug the issue.

Please refer to the attachment "switch-calls.txt".

Comment 41

[Mingming ZHAO]

Attachment: switch calls

Comment 42

[Etienne Segonzac (:etienne)]

(In reply to Mingming ZHAO from comment #39)
> Dears,
> Through discussions, we can accept the present case that is
> > - the first call will be put on hold
> > - the emergency call will be dialed
> > - the call screen will appear
> 
> But why can not switch the two calls?

If this is the issue let's update the description/file a new bug.

Comment 43

[Anshul]

Mingming, from your logs when a dial request is made I should see a switch request, which I don't.

 405 49:01-01 01:02:32.385 D/RIL_QC_B2G(  146): [0193]< GET_CURRENT_CALLS {[id=1,ACTIVE,toa=129,norm,mo,als=0,voc,noevp,10010,cli=0,name='',0,]}

  407 49:01-01 01:02:34.755 D/RIL_QC_B2G(  146): [0194]> GET_CURRENT_CALLS

  452 49:01-01 01:02:40.595 D/RIL_QC_B2G(  146): [0213]> DIAL 112 0

  453 49:01-01 01:02:40.605 D/RIL_QC_B2G(  146): [0213]< DIAL

  454 49:01-01 01:02:40.605 D/RIL_QC_B2G(  146): [0214]> GET_CURRENT_CALLS

  456 49:01-01 01:02:40.605 D/RIL_QC_B2G(  146): [0215]> GET_CURRENT_CALLS

  457 49:01-01 01:02:40.615 D/RIL_QC_B2G(  146): [0214]< GET_CURRENT_CALLS {[id=1,DIALING,toa=129,norm,mo,als=0,voc,noevp,112,cli=0,name='',0,]}

This makes me wonder if you are using an older AU. Could you please let me know which AU you are using. I tried the exact same steps and I don't see the issue. Please provide both the main logs and the radio logs by running the following command
  adb logcat -b radio -b main -v time 

This is a different issue than the one originaly reported by this bug so I suggest if you still see the issue on the latest AU, please file a new bug.

From the videos I can see this issue is resolved so I am marking it fixed.

Comment 44

[Anshul]

Mingming, from your logs when a dial request is made I should see a switch request, which I don't.

 405 49:01-01 01:02:32.385 D/RIL_QC_B2G(  146): [0193]< GET_CURRENT_CALLS {[id=1,ACTIVE,toa=129,norm,mo,als=0,voc,noevp,10010,cli=0,name='',0,]}

  407 49:01-01 01:02:34.755 D/RIL_QC_B2G(  146): [0194]> GET_CURRENT_CALLS

  452 49:01-01 01:02:40.595 D/RIL_QC_B2G(  146): [0213]> DIAL 112 0

  453 49:01-01 01:02:40.605 D/RIL_QC_B2G(  146): [0213]< DIAL

  454 49:01-01 01:02:40.605 D/RIL_QC_B2G(  146): [0214]> GET_CURRENT_CALLS

  456 49:01-01 01:02:40.605 D/RIL_QC_B2G(  146): [0215]> GET_CURRENT_CALLS

  457 49:01-01 01:02:40.615 D/RIL_QC_B2G(  146): [0214]< GET_CURRENT_CALLS {[id=1,DIALING,toa=129,norm,mo,als=0,voc,noevp,112,cli=0,name='',0,]}

This makes me wonder if you are using an older AU. Could you please let me know which AU you are using. I tried the exact same steps and I don't see the issue. Please provide both the main logs and the radio logs by running the following command
  adb logcat -b radio -b main -v time 

This is a different issue than the one originaly reported by this bug so I suggest if you still see the issue on the latest AU, please file a new bug.

From the videos I can see this issue is resolved so I am marking it fixed.