863762 - java.lang.NullPointerException: at org.mozilla.gecko.widget.TopSitesView.editSite(TopSitesView.java)

Status: RESOLVED WONTFIX

(Firefox for Android Graveyard :: General, defect)

Description

[Scoobidiver (away)]

There's one crash in 23.0a1/20130419: bp-c434d748-6ddd-4ead-95b0-e72b32130419.

It might be a regression from bug 838793.

java.lang.NullPointerException
	at org.mozilla.gecko.widget.TopSitesView.editSite(TopSitesView.java:580)
	at org.mozilla.gecko.widget.AboutHome.onContextItemSelected(AboutHome.java:190)
	at android.support.v4.app.FragmentManagerImpl.dispatchContextItemSelected(FragmentManager.java:1967)
	at android.support.v4.app.FragmentActivity.onMenuItemSelected(FragmentActivity.java:362)
	at com.android.internal.policy.impl.PhoneWindow$DialogMenuCallback.onMenuItemSelected(PhoneWindow.java:3633)
	at com.android.internal.view.menu.MenuBuilder.dispatchMenuItemSelected(MenuBuilder.java:735)
	at com.android.internal.view.menu.MenuItemImpl.invoke(MenuItemImpl.java:149)
	at com.android.internal.view.menu.MenuBuilder.performItemAction(MenuBuilder.java:874)
	at com.android.internal.view.menu.MenuDialogHelper.onClick(MenuDialogHelper.java:167)
	at com.android.internal.app.AlertController$AlertParams$3.onItemClick(AlertController.java:941)
	at android.widget.AdapterView.performItemClick(AdapterView.java:298)
	at android.widget.AbsListView.performItemClick(AbsListView.java:1100)
	at android.widget.AbsListView$PerformClick.run(AbsListView.java:2749)
	at android.widget.AbsListView$1.run(AbsListView.java:3423)
	at android.os.Handler.handleCallback(Handler.java:725)
	at android.os.Handler.dispatchMessage(Handler.java:92)
	at android.os.Looper.loop(Looper.java:137)
	at android.app.ActivityThread.main(ActivityThread.java:5226)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at java.lang.reflect.Method.invoke(Method.java:511)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:795)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:562)
	at dalvik.system.NativeStart.main(Native Method)

More reports at:
https://crash-stats.mozilla.com/report/list?signature=java.lang.NullPointerException%3A+at+org.mozilla.gecko.widget.TopSitesView.editSite%28TopSitesView.java%29

Comment 2

[:Margaret Leibovic]

This crash looks like it was caused by getChildAt() returning null (similar to bug 839854), but it seems to have disappeared after April 19. I'm going to mark this as WORKSFORME, since there aren't any new crashes, but it would be nice to know what might have fixed this to help us figure out bug 839854.

Comment 3

[Scoobidiver (away)]

(In reply to :Margaret Leibovic from comment #2)
> it seems to have disappeared after April 19. I'm going to mark this as WORKSFORME
Bug 860320 is #135 crasher in 20.0.1 and #269 in 21.0b6 so I doubt that's enough to qualify it as fixed.

Comment 4

[:Margaret Leibovic]

(In reply to Scoobidiver from comment #3)
> (In reply to :Margaret Leibovic from comment #2)
> > it seems to have disappeared after April 19. I'm going to mark this as WORKSFORME
> Bug 860320 is #135 crasher in 20.0.1 and #269 in 21.0b6 so I doubt that's
> enough to qualify it as fixed.

Okay, but at this point I don't think we're going to land a fix for those versions. Can we close this and mark it as wontfix for 20/21?

Comment 5

[Scoobidiver (away)]

(In reply to :Margaret Leibovic from comment #4)
> Okay, but at this point I don't think we're going to land a fix for those
> versions.
My point was to prove that a low volume crash can exist despite having no recent crash reports in Aurora and Nightly tested by only about 2,000 ADU. In order to know whether it's fixed in 23.0 you need to wait that version switch to Beta.

Comment 6

[Sylvestre Ledru [:Sylvestre]]

Closing because no crash reported since 12 weeks.