860320 - java.lang.NullPointerException: at org.mozilla.gecko.AboutHomeContent.editSite(AboutHomeContent.java)

Status: RESOLVED DUPLICATE of bug 863762

(Firefox for Android Graveyard :: General, defect)

Description

[Scoobidiver (away)]

It's similar to bug 847083.
20.0 (#131) and 21.0 Beta (#259) are currently affected.

Here is a crash report: bp-3c57082b-ea6e-4d8f-bd39-d42b32130409.

java.lang.NullPointerException
	at org.mozilla.gecko.AboutHomeContent.editSite(AboutHomeContent.java:1026)
	at org.mozilla.gecko.BrowserApp.onContextItemSelected(BrowserApp.java:1039)
	at android.app.Activity.onMenuItemSelected(Activity.java:2552)
	at com.android.internal.policy.impl.PhoneWindow$DialogMenuCallback.onMenuItemSelected(PhoneWindow.java:3892)
	at com.android.internal.view.menu.MenuBuilder.dispatchMenuItemSelected(MenuBuilder.java:735)
	at com.android.internal.view.menu.MenuItemImpl.invoke(MenuItemImpl.java:149)
	at com.android.internal.view.menu.MenuBuilder.performItemAction(MenuBuilder.java:874)
	at com.android.internal.view.menu.MenuDialogHelper.onClick(MenuDialogHelper.java:167)
	at com.android.internal.app.AlertController$AlertParams$3.onItemClick(AlertController.java:940)
	at android.widget.AdapterView.performItemClick(AdapterView.java:298)
	at android.widget.AbsListView.performItemClick(AbsListView.java:1088)
	at android.widget.AbsListView$PerformClick.run(AbsListView.java:2861)
	at android.widget.AbsListView$1.run(AbsListView.java:3535)
	at android.os.Handler.handleCallback(Handler.java:615)
	at android.os.Handler.dispatchMessage(Handler.java:92)
	at android.os.Looper.loop(Looper.java:137)
	at android.app.ActivityThread.main(ActivityThread.java:4966)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at java.lang.reflect.Method.invoke(Method.java:511)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:791)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:558)
	at dalvik.system.NativeStart.main(Native Method)

More reports at:
https://crash-stats.mozilla.com/report/list?signature=java.lang.NullPointerException%3A+at+org.mozilla.gecko.AboutHomeContent.editSite%28AboutHomeContent.java%29

Comment 1

[:Margaret Leibovic]

It looks like this would happen if mTopSites is null, and there are a lot of similar places where we're using mTopSites without a null check. I wonder how mTopSites could be null in this case.

Comment 2

[:Margaret Leibovic]

This code has changed, and this crash is now showing up as bug 863762.