863778 - Incorrect message content (in application) and missed SIM icon (in widget) when launching Usage without a SIM

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Cost Control, defect)

Description

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Attachment: Screenshot

Steps to reproduce:
1. Remove SIM from device and restart
2. Unlock device and launch Usage application

Expected message:
 No SIM inserted
 Insert a SIM to enable Usage

Actual message:
 widget-no-sim2-heading
 widget-no-sim2-meta

Build identifier: 20130415230205
Gecko revision: 2e24a451e0a50a5896570e628ce4a49810da49a7
Gaia revision: c614b3f3c956dc1e1adf93cf4cf41511ce75de80

Using build from: https://pvtbuilds.mozilla.org/pub/mozilla.org/b2g/nightly/mozilla-b2g18-unagi-eng/2013/04/2013-04-12-07-02-04/

Comment 1

[Dave Hunt [:davehunt] [he/him] ⌚BST]

My gecko/gaia revisions were inaccurate in comment 0. Here is the result of my bisect:

Last good:
Gecko revision: 2e24a451e0a50a5896570e628ce4a49810da49a7
Gaia revision: c614b3f3c956dc1e1adf93cf4cf41511ce75de80
https://pvtbuilds.mozilla.org/pub/mozilla.org/b2g/nightly/mozilla-b2g18-unagi-eng/2013/04/2013-04-10-07-02-09/

First bad:
Gecko revision: db16b691fbdd26b9c08ea2a7ba8b1025a7cbf037
Gaia revision: 6992012da593f4ce413a57e53aff64babdb5a94f
https://pvtbuilds.mozilla.org/pub/mozilla.org/b2g/nightly/mozilla-b2g18-unagi-eng/2013/04/2013-04-10-23-02-04/

Comment 2

[Dave Hunt [:davehunt] [he/him] ⌚BST]

My guess would be this: https://github.com/mozilla-b2g/gaia/commit/1d6bfba06bb54688466a980d165741470d0c13a4

Comment 3

[Dave Hunt [:davehunt] [he/him] ⌚BST]

I noticed this in the logcat:

E/GeckoConsole(  530): Content JS WARN at app://costcontrol.gaiamobile.org/gaia_build_defer_index.js:1 in consoleWarn: [l10n] #widget-no-sim2-heading is undefined.
E/GeckoConsole(  530): Content JS WARN at app://costcontrol.gaiamobile.org/gaia_build_defer_index.js:1 in consoleWarn: [l10n] #widget-no-sim2-meta is undefined.

Comment 4

[Lukas Blakk [:lsblakk] use ?needinfo]

This looks like a simple fix and a nice user win.

Comment 5

[Evan Tseng [:evanxd]]

Hi all,

I knew the root cause.

We showed the locales message(#widget-no-sim2-heading, #widget-no-sim2-meta) before the localized event was triggered.

So these locales messages were undefined.

Comment 6

[Evan Tseng [:evanxd]]

Attachment: Pointer to GitHub pull request: https://github.com/mozilla-b2g/gaia/pull/9396

Hi Salvador,

Please help me review the patch.

Thanks. :)

Comment 7

[Salvador de la Puente González [:salva]]

Comment on attachment 741658 [details]
Pointer to GitHub pull request: https://github.com/mozilla-b2g/gaia/pull/9396

If you do that, then every time the language is changed the application will be re-initialized. There are some tricky details as well (a missing image, some initialization issues...) so let me steal the bug.

Comment 8

[Salvador de la Puente González [:salva]]

Attachment: L10n issues solved and missing icon recovered

Comment 9

[Salvador de la Puente González [:salva]]

Mmmm, this is not reproducing on v1.0.1 but I was pretty sure it could happen. Returning to leo?

Comment 10

[bhavana bajaj [:bajaj]]

Getting back to leo+ based on comment #4 & since it looks like a regression.

Comment 11

[Evan Tseng [:evanxd]]

Hi Salvador,

Cool!

I learned it.

Thanks. :)

Comment 12

[Salvador de la Puente González [:salva]]

Thank you for spotting it out.

Comment 13

[Evan Tseng [:evanxd]]

No problem. :)

Comment 14

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 741965 [details]
L10n issues solved and missing icon recovered

r+ once addressed the small comment on github.

As you all commented, easy win for the user

Comment 15

[Salvador de la Puente González [:salva]]

Master: e9ddc19b350c11349914f0241357780fe884cc73

Comment 16

[John Ford [:jhford] CET/CEST Berlin Time]

I was not able to uplift this bug to v1-train.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1-train, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1-train
  git cherry-pick -x -m1 e9ddc19b350c11349914f0241357780fe884cc73
  <RESOLVE MERGE CONFLICTS>
  git commit

Comment 17

[Salvador de la Puente González [:salva]]

This bug depends on (in this order):
* Bug 841294 - this does not apply cleanly but it's easy to merge
* Bug 859898 - apply cleanly (asking for approval-gaia)
* Bug 862421 - apply cleanly (asking for approval-gaia)

Once the dependencies were landed, this patch will apply cleanly.

Comment 18

[John Ford [:jhford] CET/CEST Berlin Time]

841294 will not be uplifted to v1-train
859898 is not yet approved for v1-train
862421 is not yet approved for v1-train

It looks like we either need to revisit the decision to not uplift 841294 or we need to rework this patch to apply on v1-train.

Comment 19

[Salvador de la Puente González [:salva]]

Despite it is no my deccision if bug 841294 should be uplifted or not, I recommend it since the code was tested and reviewed and we are only blocking in a l10n issue even Stas recommend us no to blocking on it [1]. We can open a follow up bug to change the key and land both of them on v1-train or we can open a follow up to remove the dot.

[1] https://bugzilla.mozilla.org/show_bug.cgi?id=841294#c9

Comment 20

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifting this without the tests that depend on a feature that'll not be uplifted seems logical to me, but I'd like to get confirmation that from leo+'er.

Bhavana, what are your thoughts on the risk of uplifting this without the tests?

Comment 21

[John Ford [:jhford] CET/CEST Berlin Time]

(In reply to John Ford [:jhford] -- If you expect a reply from me, use needsinfo? instead of CC from comment #20)
> Uplifting this without the tests that depend on a feature that'll not be
> uplifted seems logical to me, but I'd like to get confirmation that from
> leo+'er.
> 
> Bhavana, what are your thoughts on the risk of uplifting this without the
> tests?

sorry, this was for the wrong bug!

Comment 22

[Salvador de la Puente González [:salva]]

After landing all dependencies, this applies cleanly. Thank you guys!

v1-train: 25c80bc0acb1b6b541b3c5c07d8e2301f0d85c8d

Comment 23

[Salvador de la Puente González [:salva]]

(In reply to Salvador de la Puente González [:salva] from comment #22)
> After landing all dependencies, this applies cleanly. Thank you guys!
> 
> v1-train: 25c80bc0acb1b6b541b3c5c07d8e2301f0d85c8d

^^^^ Wrong commit number ^^^^

v1-train: 186d31782d8cadb296661a7d104bc28846d1dfb9