Closed Bug 864262 Opened 7 years ago Closed 7 years ago

Allow to do 32-bits linux builds in x86-64 mock environments

Categories

(Firefox Build System :: General, defect)

x86
Linux
defect
Not set

Tracking

(firefox20 wontfix, firefox21 fixed, firefox22 fixed, firefox23 fixed, firefox-esr17 fixed, b2g18 fixed, b2g18-v1.0.0 wontfix, b2g18-v1.0.1 affected)

RESOLVED FIXED
mozilla23
Tracking Status
firefox20 --- wontfix
firefox21 --- fixed
firefox22 --- fixed
firefox23 --- fixed
firefox-esr17 --- fixed
b2g18 --- fixed
b2g18-v1.0.0 --- wontfix
b2g18-v1.0.1 --- affected

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(1 file, 2 obsolete files)

No description provided.
This is already landed on the "date" branch, where the 32-bits linux builds are done in x86-64 mock environments. It was also tested on try, where the 32-bits linux builds are still done in x86 mock environments. This will allow a smoother transition.
Attachment #740214 - Flags: review?(ted)
Blocks: gcc-4.7
Comment on attachment 740214 [details] [diff] [review]
Allow to do 32-bits linux builds in x86-64 mock environments

Review of attachment 740214 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/config/mozconfigs/linux32/debug
@@ +13,5 @@
> +  CXX="$CXX -m32"
> +  ac_add_options --target=i686-pc-linux
> +  ac_add_options --x-libraries=/usr/lib
> +  export PKG_CONFIG_LIBDIR=/usr/lib/pkgconfig:/usr/share/pkgconfig
> +fi

Would it make sense to stick this whole block in a standalone file and source it?
Attachment #740214 - Flags: review?(ted) → review+
Like this?
Attachment #741333 - Flags: review?(ted)
Attachment #740214 - Attachment is obsolete: true
Comment on attachment 741333 [details] [diff] [review]
Allow to do 32-bits linux builds in x86-64 mock environments

Review of attachment 741333 [details] [diff] [review]:
-----------------------------------------------------------------

Yeah!
Attachment #741333 - Flags: review?(ted) → review+
Attachment #741333 - Attachment is obsolete: true
Comment on attachment 741357 [details] [diff] [review]
Allow to do 32-bits linux builds in x86-64 mock environments

Carrying over r+
Attachment #741357 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/194300c339f4
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
Comment on attachment 741357 [details] [diff] [review]
Allow to do 32-bits linux builds in x86-64 mock environments

[Approval Request Comment]
This is in preparation for switching linux 32-bits builders to a 64-bits environment. This is effectively a no-op when builds use a 32-bits builder, and will allow older branches to be pushed to try with 64-bits builders for 32-bits builds.
Attachment #741357 - Flags: approval-mozilla-release?
Attachment #741357 - Flags: approval-mozilla-esr17?
Attachment #741357 - Flags: approval-mozilla-beta?
Attachment #741357 - Flags: approval-mozilla-b2g18?
Attachment #741357 - Flags: approval-mozilla-aurora?
Comment on attachment 741357 [details] [diff] [review]
Allow to do 32-bits linux builds in x86-64 mock environments

Approving for all except mozilla-release, we'll get it there in a couple weeks when we merge and that branch has very little action so we should be OK.
Attachment #741357 - Flags: approval-mozilla-release?
Attachment #741357 - Flags: approval-mozilla-release-
Attachment #741357 - Flags: approval-mozilla-esr17?
Attachment #741357 - Flags: approval-mozilla-esr17+
Attachment #741357 - Flags: approval-mozilla-beta?
Attachment #741357 - Flags: approval-mozilla-beta+
Attachment #741357 - Flags: approval-mozilla-b2g18?
Attachment #741357 - Flags: approval-mozilla-b2g18+
Attachment #741357 - Flags: approval-mozilla-aurora?
Attachment #741357 - Flags: approval-mozilla-aurora+
I'm assuming that there isn't anything for QA to test here that hasn't already been verified. If that's not the case, please speak up. Thank you.
Depends on: 873904
Depends on: 873334
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.