864262 - Allow to do 32-bits linux builds in x86-64 mock environments

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Allow to do 32-bits linux builds in x86-64 mock environments

This is already landed on the "date" branch, where the 32-bits linux builds are done in x86-64 mock environments. It was also tested on try, where the 32-bits linux builds are still done in x86 mock environments. This will allow a smoother transition.

Comment 2

[(not currently active) Ted Mielczarek]

Comment on attachment 740214 [details] [diff] [review]
Allow to do 32-bits linux builds in x86-64 mock environments

Review of attachment 740214 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/config/mozconfigs/linux32/debug
@@ +13,5 @@
> +  CXX="$CXX -m32"
> +  ac_add_options --target=i686-pc-linux
> +  ac_add_options --x-libraries=/usr/lib
> +  export PKG_CONFIG_LIBDIR=/usr/lib/pkgconfig:/usr/share/pkgconfig
> +fi

Would it make sense to stick this whole block in a standalone file and source it?

Comment 3

[Mike Hommey [:glandium]]

Attachment: Allow to do 32-bits linux builds in x86-64 mock environments

Like this?

Comment 4

[(not currently active) Ted Mielczarek]

Comment on attachment 741333 [details] [diff] [review]
Allow to do 32-bits linux builds in x86-64 mock environments

Review of attachment 741333 [details] [diff] [review]:
-----------------------------------------------------------------

Yeah!

Comment 5

[Mike Hommey [:glandium]]

Attachment: Allow to do 32-bits linux builds in x86-64 mock environments

With a stupid typo fix.

Comment 6

[Mike Hommey [:glandium]]

Comment on attachment 741357 [details] [diff] [review]
Allow to do 32-bits linux builds in x86-64 mock environments

Carrying over r+

Comment 7

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/194300c339f4

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/194300c339f4

Comment 9

[Mike Hommey [:glandium]]

Comment on attachment 741357 [details] [diff] [review]
Allow to do 32-bits linux builds in x86-64 mock environments

[Approval Request Comment]
This is in preparation for switching linux 32-bits builders to a 64-bits environment. This is effectively a no-op when builds use a 32-bits builder, and will allow older branches to be pushed to try with 64-bits builders for 32-bits builds.

Comment 10

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 741357 [details] [diff] [review]
Allow to do 32-bits linux builds in x86-64 mock environments

Approving for all except mozilla-release, we'll get it there in a couple weeks when we merge and that branch has very little action so we should be OK.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/b4df96123e0b
https://hg.mozilla.org/releases/mozilla-beta/rev/f4231489813
https://hg.mozilla.org/releases/mozilla-b2g18/rev/5de28ce425b9
https://hg.mozilla.org/releases/mozilla-esr17/rev/15769b8b99c4

Comment 12

[Matt Wobensmith [:mwobensmith][:matt:]]

I'm assuming that there isn't anything for QA to test here that hasn't already been verified. If that's not the case, please speak up. Thank you.