864291 - Remove "Personas" from UI and Help

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[Jens Hatlak (:InvisibleSmiley)]

The term "Personas", as referring to lightweight themes, is being phased out. We are currently using it in the UI (View/Apply Themes/Get Personas), code, and Help documentation (cf. bug 652328). We can probably leave actual code alone, but UI and Help need updating.

Since we're changing the term, new entity names need to be used.

Affected files:
/suite/common/viewApplyThemeOverlay.xul
/suite/locales/en-US/chrome/common/help/customize_help.xhtml
/suite/locales/en-US/chrome/common/viewApplyThemeOverlay.dtd

And in case we want to change the Get Personas landing page, too:
/suite/locales/en-US/chrome/branding/brand.properties

Comment 1

[Philip Chee]

So what's the current name for the former lightweight themes? I think AMO uses "background themes".

Comment 2

[Jens Hatlak (:InvisibleSmiley)]

(In reply to Philip Chee from comment #1)
> So what's the current name for the former lightweight themes? I think AMO
> uses "background themes".

Glad you brought this up. I would have gone with "lightweight" since that's what it has been referred to before, but actually I think AMO's choice is better. "Lightweight" is putting too much focus on technical/implementation details to me while "background" should be known to the average user (from "background image", think desktop).

Comment 3

[Tony Mechelynck [:tonymec]]

Actually, AMO currently uses "themes" for what used to be called "Personas", and "complete themes" for what used to be called "themes". Compare for instance the following pages (both the URLs and the contents):

https://addons.mozilla.org/en-US/seamonkey/themes/
https://addons.mozilla.org/en-US/seamonkey/complete-themes/

This confused me no end, until I found out (I don't remember how) where the old-style themes had been hidden, since there are no links (that I could find, at least) pointing to the complete-themes page.

Comment 4

[Tony Mechelynck [:tonymec]]

P.S. And when I said the contents, I meant especially the titles, most definitely including the top heading, e.g.

(icon) ADD-ONS
       EXTENSIONS | THEMES | COLLECTIONS | MORE…

Comment 5

[Tony Mechelynck [:tonymec]]

Ah, there: the only link to "complete themes" that I could find today is on the "themes" page, but just lower than the height of the contents of my maximized browser window (i.e., lower down than my 768px screen height minus top and bottom bars from Gnome, top chrome from the browser, and statusbar from browser); and it is much less obvious (IMHO) than all the Personas which take up most of the page.

Comment 6

[Jens Hatlak (:InvisibleSmiley)]

OK so since Personas are called Themes now and Get New Themes and Get Personas now take you to the exact same page (after redirects), I think we can just as well drop Get Personas altogether. Help needs a little updating and then we're done. Agreed?

Comment 7

[Edmund Wong (:ewong)]

Attachment: UI changes (v1)

Comment 8

[Edmund Wong (:ewong)]

Attachment: Help Changes (v1)

Comment 9

[[e-mail]]

Comment on attachment 783152 [details] [diff] [review]
UI changes (v1)

>Bug 864291 - Rename 'Personas' in UI.
This isn't rename any more, it's remove. And that means it needs to be a complete purge of anything mentioning the string "getPersonas" (case sensitive).

Comment 10

[Jens Hatlak (:InvisibleSmiley)]

Comment on attachment 783153 [details] [diff] [review]
Help Changes (v1)

Review of attachment 783153 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry I have to minus this one since you didn't even touch the "Personas" section (which starts with "Note" and is just outside the context of your patch).

::: suite/locales/en-US/chrome/common/help/customize_help.xhtml
@@ +504,4 @@
>    <li>Quit and restart &brandShortName;.</li>
>  </ol>
>  
> +<p>You can get new themes by selecting Get Themes.  This will open a new tab

AFAICS it's actually called Get New Themes.

Nit: Double space within text (here and below)

@@ +504,5 @@
>    <li>Quit and restart &brandShortName;.</li>
>  </ol>
>  
> +<p>You can get new themes by selecting Get Themes.  This will open a new tab
> +  or window to the Get Themes webpage.  Here, you can download the latest

The webpage is not actually called Get Themes (at least right now). How about just "Themes webpage"?

Also "open ... to" sounds strange to me; at least in German that wouldn't work (no, I'm not talking about l10n here, just my feeling). Unless Neil or Ian accept it, maybe use "and load" instead of "to"?

Third, I'd say "download/apply" since lightweight themes are not really downloaded but rather applied right away (AMO uses the phrase "Add to SeaMonkey").

@@ +505,5 @@
>  </ol>
>  
> +<p>You can get new themes by selecting Get Themes.  This will open a new tab
> +  or window to the Get Themes webpage.  Here, you can download the latest
> +  themes which you can apply using the aforementioned procedure.</p>

Well the "aforementioned procedure" is only one of the two alternatives how you can apply a theme (the other one, using the AOM, is described below). Also, lightweight themes get applied directly once you click "Add to SeaMonkey" (and before that, they are applied temporarily while you hover a theme preview image).

Comment 11

[Edmund Wong (:ewong)]

Attachment: UI Changes (v2)

Comment 12

[[e-mail]]

Comment on attachment 784296 [details] [diff] [review]
UI Changes (v2)

> function test() {
>   // Add cookies.
>-  Services.cookies.add("getpersonas.com", "", "name0", "value0",
>-                       false, false, true, parseInt(Date.now() / 1000) + 600);
>   Services.cookies.add("drumbeat.org", "", "name1", "value1",
>                        false, false, true, parseInt(Date.now() / 1000) + 600);
By this logic, you should remove drumbeat.org while you're at it; after all, the site was retired over a year ago...

Comment 13

[[e-mail]]

Comment on attachment 784296 [details] [diff] [review]
UI Changes (v2)

Just leave the tests as they are. r=me on the non-test changes.

Comment 14

[Edmund Wong (:ewong)]

Attachment: UI changes (v3)

Comment 15

[Edmund Wong (:ewong)]

Attachment: Help changes(v2)

Comment 16

[Jens Hatlak (:InvisibleSmiley)]

Comment on attachment 785372 [details] [diff] [review]
Help changes(v2)

Review of attachment 785372 [details] [diff] [review]:
-----------------------------------------------------------------

r- only because I want to see an updated patch.

::: suite/locales/en-US/chrome/common/help/customize_help.xhtml
@@ +504,4 @@
>    <li>Quit and restart &brandShortName;.</li>
>  </ol>
>  
> +<p>You can get new themes by selecting Themes webpage. This will open a new

It's still called Get New Themes, and it's a menu item so leave out "webpage" here (BTW if you kept it, it would require a "the").

@@ +504,5 @@
>    <li>Quit and restart &brandShortName;.</li>
>  </ol>
>  
> +<p>You can get new themes by selecting Themes webpage. This will open a new
> +  tab or window and load the Get New Themes webpage. Here, you can download/apply

Here you should say "Themes webpage", not above.
Also I'd leave out the comma after "Here".
Third, since you're using "apply" again within the same sentence, I'd say just have "download" here.

@@ +506,5 @@
>  
> +<p>You can get new themes by selecting Themes webpage. This will open a new
> +  tab or window and load the Get New Themes webpage. Here, you can download/apply
> +  the latest themes which you can apply using the aforementioned procedure.
> +  The other way is through the Add-ons Manager.  Lightweight themes get

Maybe add " (see below)"?
Nit: double space.

@@ +507,5 @@
> +<p>You can get new themes by selecting Themes webpage. This will open a new
> +  tab or window and load the Get New Themes webpage. Here, you can download/apply
> +  the latest themes which you can apply using the aforementioned procedure.
> +  The other way is through the Add-ons Manager.  Lightweight themes get
> +  applied directly once you click 'Add to SeaMonkey'.</p>

Please use double quotes (twice).

Comment 17

[Edmund Wong (:ewong)]

Attachment: Help changes(v3)

Comment 18

[Jens Hatlak (:InvisibleSmiley)]

Comment on attachment 822900 [details] [diff] [review]
Help changes(v3)

Sorry pal, something went seriously wrong with this patch. Try again?

Comment 19

[Edmund Wong (:ewong)]

Attachment: Help changes(v4)

Comment 20

[Ryan VanderMeulen [:RyanVM]]

Bitrotted, please rebase.

Comment 21

[Edmund Wong (:ewong)]

IanN, InvisibleSmiley.. really sorry for taking this long in getting this bug done; but now that it's done, I'm thinking that this bug might have become either "Invalid" or "WontFix", due in part to the fixing of bug 906083.

IanN, can you please confirm this?

Ironically, Ian's the one who r+'d the other bug. ;P

Comment 22

[Jens Hatlak (:InvisibleSmiley)]

(In reply to Edmund Wong (:ewong) from comment #21)
> IanN, InvisibleSmiley.. really sorry for taking this long in getting this
> bug done; but now that it's done, I'm thinking that this bug might have
> become either "Invalid" or "WontFix", due in part to the fixing of bug
> 906083.

Yeah, I think at least the code changes are obsolete now. Help still needs some updating, though. I guess that part of your patch could almost go in with only s/Get New Themes/Get More Themes/.

Comment 23

[Edmund Wong (:ewong)]

Attachment: Update help for the changes from bug 906083.(v5)

Comment 24

[Edmund Wong (:ewong)]

Just the help patch needs to be checked in.

Comment 25

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/4852f232b25f

Comment 26

[Philip Chee]

Sorry for the drive by lit-crit.

>  Here you can download the latest
>   themes which you can apply using the aforementioned procedure. The other way
>   is through the Add-ons Manager (see below). Lightweight themes get applied
>   directly once you click "Add to SeaMonkey"

Here you can download the latest themes and apply them. Another way to install 
new themes is through the Add-ons Manager. Lightweight themes are applied 
immediately when you select "Add to SeaMonkey".

Comment 27

[Edmund Wong (:ewong)]

(In reply to Philip Chee from comment #26)
> Sorry for the drive by lit-crit.
> 
> >  Here you can download the latest
> >   themes which you can apply using the aforementioned procedure. The other way
> >   is through the Add-ons Manager (see below). Lightweight themes get applied
> >   directly once you click "Add to SeaMonkey"
> 
> Here you can download the latest themes and apply them. Another way to
> install 
> new themes is through the Add-ons Manager. Lightweight themes are applied 
> immediately when you select "Add to SeaMonkey".

Just noticed this post-push comment.  Jens, would this be better?

Comment 28

[Jens Hatlak (:InvisibleSmiley)]

I feel that errors and mistakes need to be corrected, but here I only see that Philip's suggestion is /different/, not that our version was /wrong/. I don't want to go bikeshedding here, but if there really is something wrong here, a native speaker should decide. Ian, the stage is yours.

Comment 29

[Ian Neal]

(In reply to Philip Chee from comment #26)
> Sorry for the drive by lit-crit.
> 
> >  Here you can download the latest
> >   themes which you can apply using the aforementioned procedure. The other way
> >   is through the Add-ons Manager (see below). Lightweight themes get applied
> >   directly once you click "Add to SeaMonkey"
> 
> Here you can download the latest themes and apply them. Another way to
> install 
> new themes is through the Add-ons Manager. Lightweight themes are applied 
> immediately when you select "Add to SeaMonkey".

I think I prefer Philip's suggestion except with the "(see below)" bit still in it.
Any reason why we're using SeaMonkey rather than &brandShortName;? I know it comes from the addons website but doesn't it still pull it from the branding of the product?